CI: repair the SNMP job and make it voting.

The SNMP hardware type does not have a management interface, thus
it's impossible to switch boot device to local. Keep using netboot.

As a nice side effect, this job will keep testing whole disk images
with network boot.

Make the job voting since it's pretty stable when we don't break it.

Change-Id: I559fdccfbaf02396a0a096c50fbb9660c22a4dee

zuul.d/ironic-jobs.yaml

@@ -228,8 +228,8 @@
         s-proxy: True
 
 - job:
-    name: ironic-tempest-ipa-wholedisk-bios-pxe_snmp
-    description: ironic-tempest-ipa-wholedisk-bios-pxe_snmp
+    name: ironic-tempest-wholedisk-bios-snmp-pxe
+    description: SNMP power, no-op management, netboot and whole disk images.
     parent: ironic-base
     timeout: 5400
     vars:
@@ -239,6 +239,9 @@
         IRONIC_TEMPEST_WHOLE_DISK_IMAGE: True
         IRONIC_VM_EPHEMERAL_DISK: 0
         IRONIC_AUTOMATED_CLEAN_ENABLED: False
+        # NOTE(dtantsur): the snmp hardware type does not have a management
+        # interface, thus we cannot switch to local boot on deploy.
+        IRONIC_DEFAULT_BOOT_OPTION: netboot
 
 - job:
     name: ironic-tempest-ipa-partition-uefi-pxe_ipmitool

zuul.d/project.yaml

@@ -18,6 +18,7 @@
             voting: false
         - ironic-tempest-partition-bios-redfish-pxe
         - ironic-tempest-partition-uefi-redfish-vmedia
+        - ironic-tempest-wholedisk-bios-snmp-pxe
         - ironic-tempest-ipa-partition-pxe_ipmitool
         - ironic-tempest-ipa-partition-uefi-pxe_ipmitool
         - ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode
@@ -30,8 +31,6 @@
         # Non-voting jobs
         - ironic-tox-bandit:
             voting: false
-        - ironic-tempest-ipa-wholedisk-bios-pxe_snmp:
-            voting: false
         - ironic-inspector-tempest:
             voting: false
         - ironic-inspector-tempest-managed:
@@ -55,6 +54,7 @@
         # - ironic-grenade-dsvm-multinode-multitenant
         - ironic-tempest-partition-bios-redfish-pxe
         - ironic-tempest-partition-uefi-redfish-vmedia
+        - ironic-tempest-wholedisk-bios-snmp-pxe
         - ironic-tempest-ipa-partition-pxe_ipmitool
         - ironic-tempest-ipa-partition-uefi-pxe_ipmitool
         - ironic-tempest-ipa-wholedisk-direct-tinyipa-multinode