openstack
/
ironic
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(2 comments)

Patch-set: 2
CC: Gerrit User 11655 <11655@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 11655 2024-04-27 01:17:40 +00:00 committed by Gerrit Code Review
parent 540d595a88
commit a38bc87301
1 changed files with 38 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
a302f1be80ad904b836c9b8314a0b13fc7b1b21a Normal file
View File

@ -0,0 +1,38 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "050e23cb_9a1e468c",
"filename": "ironic/drivers/modules/ipmitool.py",
"patchSetId": 2
},
"lineNbr": 74,
"author": {
"id": 11655
},
"writtenOn": "2024-04-27T01:17:40Z",
"side": 1,
"message": "perhaps \"ipmi_use_environment_for_auth\" or something short. I guess I\u0027m thinking something so we\u0027re dealing with more a boolean value as opposed to a explicit option passed through.",
"revId": "a302f1be80ad904b836c9b8314a0b13fc7b1b21a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "7fb220fc_318f1fd2",
"filename": "ironic/drivers/modules/ipmitool.py",
"patchSetId": 2
},
"lineNbr": 449,
"author": {
"id": 11655
},
"writtenOn": "2024-04-27T01:17:40Z",
"side": 1,
"message": "Smart!",
"revId": "a302f1be80ad904b836c9b8314a0b13fc7b1b21a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}