openstack/ironic
Code Issues Proposed changes

Do not log lack of metrics support at WARNING lvl

Browse Source 
We have some drivers, such as SNMP, which do not support metrics.
Environments with these nodes should not get "N" messages for "N" nodes
that can't generate sensor data.

Closes-bug: 2047709
Change-Id: Ibc1f3feb055521214512c8b350d67933491c2550
This commit is contained in:
Jay Faulkner 2023-12-29 10:59:42 -08:00
parent cf7b182ac3
commit b0b7ee4254
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ironic/conductor/manager.py
View File

@ -2626,7 +2626,11 @@ class ConductorManager(base_manager.BaseConductorManager):
sensors_data = task.driver.management.get_sensors_data(
task)
except NotImplementedError:
LOG.warning(
# NOTE(JayF): In mixed deployments with some nodes supporting
# sensor data and others not, logging this at warning level
# creates unreasonable levels of logging noise.
# See https://bugs.launchpad.net/ironic/+bug/2047709
LOG.debug(
'get_sensors_data is not implemented for driver'
' %(driver)s, node_uuid is %(node)s',
{'node': node_uuid, 'driver': driver})