openstack/ironic
Code Issues Proposed changes

Make metrics names a little more consistent

Browse Source 
Some of these metrics decorator were unlabeled without a class which
would result in semi-confusing structures for the metrics counters.

Now, we should be semi-consistent.

Change-Id: Ie2795419991dc941f2a2b2bc0c6116b92d285041
This commit is contained in:
Julia Kreger 2023-01-11 14:49:34 -08:00
parent e011922bac
commit b1643368be
2 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ironic/drivers/modules/agent_base.py
View File

@ -100,7 +100,7 @@ _FASTTRACK_HEARTBEAT_ALLOWED = (states.DEPLOYWAIT, states.CLEANWAIT,
FASTTRACK_HEARTBEAT_ALLOWED = frozenset(_FASTTRACK_HEARTBEAT_ALLOWED)
@METRICS.timer('post_clean_step_hook')
@METRICS.timer('AgentBase.post_clean_step_hook')
def post_clean_step_hook(interface, step):
"""Decorator method for adding a post clean step hook.
@ -128,7 +128,7 @@ def post_clean_step_hook(interface, step):
return decorator
@METRICS.timer('post_deploy_step_hook')
@METRICS.timer('AgentBase.post_deploy_step_hook')
def post_deploy_step_hook(interface, step):
"""Decorator method for adding a post deploy step hook.
@ -279,7 +279,7 @@ def _get_completed_command(task, commands, step_type):
return last_command
@METRICS.timer('log_and_raise_deployment_error')
@METRICS.timer('AgentBase.log_and_raise_deployment_error')
def log_and_raise_deployment_error(task, msg, collect_logs=True, exc=None):
"""Helper method to log the error and raise exception.

9
releasenotes/notes/change-c9c01700dcfd599b.yaml Normal file
View File

@ -0,0 +1,9 @@
---
upgrade:
- |
Two statsd metrics names have been modified to provide structural clarity
and consistency for consumers of statistics metrics. Consumers of metrics
statistics may need to update their dashboards as the
``post_clean_step_hook`` metric is now named
``AgentBase.post_clean_step_hook``, and the ``post_deploy_step_hook`` is
now named ``AgentBase.post_deploy_step_hook``.