From b5b91922581f2150f306c0e00964d3eb42410321 Mon Sep 17 00:00:00 2001
From: Gerrit User 4571 <4571@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Date: Mon, 29 Apr 2024 01:10:08 +0000
Subject: [PATCH] Update patch set 18

Patch Set 18:

(4 comments)

Patch-set: 18
---
 136be235fb0eb80e316d62c573ea2ce269e35877 | 36 ++++++++++++++++++++++++
 3b7a76a52f08346df7f8e9cc260f334d90dfb560 | 18 ++++++++++++
 d68aea2ebecbf98878573f25570af3e0196d6f5f | 18 ++++++++++++
 3 files changed, 72 insertions(+)

diff --git a/136be235fb0eb80e316d62c573ea2ce269e35877 b/136be235fb0eb80e316d62c573ea2ce269e35877
index 84fd1890ea..52b751ec37 100644
--- a/136be235fb0eb80e316d62c573ea2ce269e35877
+++ b/136be235fb0eb80e316d62c573ea2ce269e35877
@@ -34,6 +34,24 @@
       "revId": "136be235fb0eb80e316d62c573ea2ce269e35877",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "16c724ea_1138d1f4",
+        "filename": "ironic/common/cinder.py",
+        "patchSetId": 18
+      },
+      "lineNbr": 98,
+      "author": {
+        "id": 4571
+      },
+      "writtenOn": "2024-04-29T01:10:08Z",
+      "side": 1,
+      "message": "We already use v3, which is achieved by setting service_type\u003dvolumev3:\n\nhttps://opendev.org/openstack/ironic/src/branch/master/ironic/conf/cinder.py#L40\n\nIts just that the sdk also requires explicit version to be requested otherwise it assumes v2",
+      "parentUuid": "5c6e959f_f183307c",
+      "revId": "136be235fb0eb80e316d62c573ea2ce269e35877",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
     {
       "unresolved": false,
       "key": {
@@ -50,6 +68,24 @@
       "message": "I assume this does not need bumping up?",
       "revId": "136be235fb0eb80e316d62c573ea2ce269e35877",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "56b749ef_60e46f01",
+        "filename": "requirements.txt",
+        "patchSetId": 18
+      },
+      "lineNbr": 47,
+      "author": {
+        "id": 4571
+      },
+      "writtenOn": "2024-04-29T01:10:08Z",
+      "side": 1,
+      "message": "Indeed, all required actions didn\u0027t land until 0.99.0",
+      "parentUuid": "611226de_7e0e4aaa",
+      "revId": "136be235fb0eb80e316d62c573ea2ce269e35877",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     }
   ]
 }
\ No newline at end of file
diff --git a/3b7a76a52f08346df7f8e9cc260f334d90dfb560 b/3b7a76a52f08346df7f8e9cc260f334d90dfb560
index ed8aa1480e..d80df72f70 100644
--- a/3b7a76a52f08346df7f8e9cc260f334d90dfb560
+++ b/3b7a76a52f08346df7f8e9cc260f334d90dfb560
@@ -16,6 +16,24 @@
       "message": "BTW the error I\u0027m attempting to fix is here[1], suggestions welcome\n\n  ERROR ironic.conductor.utils [None req-d16a06f8-650e-49be-b121-51086b6402a6 None None] Unexpected error while preparing to deploy to node 8e4acba8-e858-4e72-9c00-d9e5da034e08: keystoneauth1.exceptions.discovery.ImpliedMinVersionMismatch: service_type volumev3 was given which implies major API version 3 but min_version of 2.0 was also given. Please update your code to use the official service_type block-storage.\n\n\nhttps://zuul.opendev.org/t/openstack/build/ae060cf311274044849e44a67a56f213/log/controller/logs/screen-ir-cond.txt#1380",
       "revId": "3b7a76a52f08346df7f8e9cc260f334d90dfb560",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "c8688743_301743c8",
+        "filename": "ironic/conf/cinder.py",
+        "patchSetId": 7
+      },
+      "lineNbr": 45,
+      "author": {
+        "id": 4571
+      },
+      "writtenOn": "2024-04-29T01:10:08Z",
+      "side": 1,
+      "message": "Done",
+      "parentUuid": "c1a73025_23533938",
+      "revId": "3b7a76a52f08346df7f8e9cc260f334d90dfb560",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     }
   ]
 }
\ No newline at end of file
diff --git a/d68aea2ebecbf98878573f25570af3e0196d6f5f b/d68aea2ebecbf98878573f25570af3e0196d6f5f
index b2c02fffb0..5337c37c20 100644
--- a/d68aea2ebecbf98878573f25570af3e0196d6f5f
+++ b/d68aea2ebecbf98878573f25570af3e0196d6f5f
@@ -16,6 +16,24 @@
       "message": "Why was the docstring removed? Did you intend to remove the parameter as well?",
       "revId": "d68aea2ebecbf98878573f25570af3e0196d6f5f",
       "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
+    },
+    {
+      "unresolved": false,
+      "key": {
+        "uuid": "2d9100ea_81c76513",
+        "filename": "ironic/common/cinder.py",
+        "patchSetId": 18
+      },
+      "lineNbr": 48,
+      "author": {
+        "id": 4571
+      },
+      "writtenOn": "2024-04-29T01:10:08Z",
+      "side": 0,
+      "message": "Restored",
+      "parentUuid": "c85cf6c2_fa8ff6e2",
+      "revId": "d68aea2ebecbf98878573f25570af3e0196d6f5f",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
     }
   ]
 }
\ No newline at end of file