Browse Source

Merge "Make bootloader installation failures fatal for whole disk images"

changes/75/824075/2
Zuul 4 months ago committed by Gerrit Code Review
parent
commit
bded82a27e
  1. 19
      ironic/drivers/modules/agent_base.py
  2. 7
      releasenotes/notes/bootloader-install-fatal-6f1b9fed1d2c0ee4.yaml

19
ironic/drivers/modules/agent_base.py

@ -1335,20 +1335,11 @@ class AgentDeployMixin(HeartbeatMixin, AgentOobStepsMixin):
software_raid=software_raid
)
if result['command_status'] == 'FAILED':
if not whole_disk_image:
msg = (_("Failed to install a bootloader when "
"deploying node %(node)s. Error: %(error)s") %
{'node': node.uuid,
'error': agent_client.get_command_error(result)})
log_and_raise_deployment_error(task, msg)
else:
# Its possible the install will fail if the IPA image
# has not been updated, log this and continue
LOG.info('Could not install bootloader for whole disk '
'image for node %(node)s, Error: %(error)s"',
{'node': node.uuid,
'error': agent_client.get_command_error(result)})
return
msg = (_("Failed to install a bootloader when "
"deploying node %(node)s. Error: %(error)s") %
{'node': node.uuid,
'error': agent_client.get_command_error(result)})
log_and_raise_deployment_error(task, msg)
try:
persistent = True

7
releasenotes/notes/bootloader-install-fatal-6f1b9fed1d2c0ee4.yaml

@ -0,0 +1,7 @@
---
upgrade:
- |
Bootloader installation failures are now fatal for whole disk images.
Previously these failures were ignored to facilitate backwards
compatibility with older Ironic Python Agents, however we can now rely on
having a sufficiently modern IPA.
Loading…
Cancel
Save