openstack/ironic
Code Issues Proposed changes

Implement the bios-interface for idrac-wsman driver

Browse Source 
The BIOSInterface implementation for idrac-wsman Hardware Type was
missing and VendorInterface methods were used to configure BIOS instead.
This was not desired since it exposes a lot of vendor intricacies to the
operator and makes the existing mechanism unstable across Ironic releases.

This change introduces the implementation of BIOSInterface with the following
code changes:

1. update IDRACHardware class with supported_bios_interfaces() method
2. update setup.cfg with an entry for idrac-wsman in bios interfaces
3. Implement the DracWSManBIOS class with appropriate methods
4. Unit tests for the work

Change-Id: Ie85e30e2dfdfb1f199ac4d25f165e0cca033a4df
Co-authored-by: Richard Pioso <richard.pioso@dell.com>
Story: 2007400
Task: 38998
This commit is contained in:
noor_muhammad_dell 2020-03-17 18:41:46 +05:00
parent 940cbbc998
commit cb86bd3088
8 changed files with 644 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
doc/source/admin/drivers/idrac.rst
View File

@ -27,6 +27,7 @@ Ironic Features
The ``idrac`` hardware type supports the following Ironic interfaces:
* `BIOS Interface`_: BIOS management
* `Inspect Interface`_: Hardware inspection
* Management Interface: Boot device management
* Power Interface: Power management
@ -51,7 +52,7 @@ configured to use an ``idrac-redfish`` interface implementation, for example::
Enabling
--------
The iDRAC driver supports WSMAN for the inspect, management, power,
The iDRAC driver supports WSMAN for the bios, inspect, management, power,
raid, and vendor interfaces. In addition, it supports Redfish for
the inspect, management, and power interfaces. The iDRAC driver
allows you to mix and match WSMAN and Redfish interfaces.
@ -74,7 +75,7 @@ all using WSMAN, add the following to your ``/etc/ironic/ironic.conf``:
enabled_management_interfaces=idrac-wsman
enabled_power_interfaces=idrac-wsman
To enable all optional features (inspection, RAID, and vendor passthru)
To enable all optional features (BIOS, inspection, RAID, and vendor passthru)
using Redfish where it is supported and WSMAN where not, use the
following configuration:
@ -82,6 +83,7 @@ following configuration:
[DEFAULT]
enabled_hardware_types=idrac
enabled_bios_interfaces=idrac-wsman
enabled_inspect_interfaces=idrac-redfish
enabled_management_interfaces=idrac-redfish
enabled_power_interfaces=idrac-redfish
@ -94,7 +96,7 @@ order:
================ ===================================================
Interface Supported Implementations
================ ===================================================
``bios`` ``no-bios``
``bios`` ``idrac-wsman``, ``no-bios``
``boot`` ``ipxe``, ``pxe``
``console`` ``no-console``
``deploy`` ``iscsi``, ``direct``, ``ansible``, ``ramdisk``
@ -198,6 +200,42 @@ hardware type assuming a mix of Redfish and WSMAN interfaces are used:
for the power interface. The same applies to Redfish. It is currently not
possible to use Redfish for one and WSMAN for the other.
BIOS Interface
==============
The BIOS interface implementation for idrac-wsman allows BIOS to be
configured with the standard clean/deploy step approach.
Example
-------
A clean step to enable ``Virtualization`` and ``SRIOV`` in BIOS of an iDRAC
BMC would be as follows::
{
"target":"clean",
"clean_steps": [
{
"interface": "bios",
"step": "apply_configuration",
"args": {
"settings": [
{
"name": "ProcVirtualization",
"value": "Enabled"
},
{
"name": "SriovGlobalEnable",
"value": "Enabled
}
]
}
}
]
}
To see all the available BIOS parameters on a node with iDRAC BMC, and also
for additional details of BIOS configuration, see :doc:`/admin/bios`.
Inspect Interface
=================

6
ironic/drivers/drac.py
View File

@ -18,6 +18,7 @@ DRAC Driver for remote system management using Dell Remote Access Card.
from oslo_config import cfg
from ironic.drivers import generic
from ironic.drivers.modules.drac import bios
from ironic.drivers.modules.drac import boot
from ironic.drivers.modules.drac import inspect as drac_inspect
from ironic.drivers.modules.drac import management
@ -56,6 +57,11 @@ class IDRACHardware(generic.GenericHardware):
# Optional hardware interfaces
@property
def supported_bios_interfaces(self):
"""List of supported bios interfaces."""
return [bios.DracWSManBIOS, noop.NoBIOS]
@property
def supported_inspect_interfaces(self):
"""List of supported inspect interfaces."""

376
ironic/drivers/modules/drac/bios.py
View File

@ -15,17 +15,393 @@
DRAC BIOS configuration specific methods
"""
from futurist import periodics
from ironic_lib import metrics_utils
from oslo_log import log as logging
from oslo_utils import importutils
from ironic.common import exception
from ironic.common.i18n import _
from ironic.conductor import task_manager
from ironic.conductor import utils as manager_utils
from ironic.conf import CONF
from ironic.drivers import base
from ironic.drivers.modules import deploy_utils
from ironic.drivers.modules.drac import common as drac_common
from ironic.drivers.modules.drac import job as drac_job
from ironic import objects
drac_exceptions = importutils.try_import('dracclient.exceptions')
LOG = logging.getLogger(__name__)
METRICS = metrics_utils.get_metrics_logger(__name__)
class DracWSManBIOS(base.BIOSInterface):
"""BIOSInterface Implementation for iDRAC."""
# argsinfo dict for BIOS clean/deploy steps
_args_info = {
"settings": {
"description": "List of BIOS settings to apply",
"required": True
}
}
def __init__(self):
super(DracWSManBIOS, self).__init__()
if drac_exceptions is None:
raise exception.DriverLoadError(
driver='idrac',
reason=_("Unable to import dracclient.exceptions library"))
@METRICS.timer('DracWSManBIOS.apply_configuration')
@base.clean_step(priority=0, argsinfo=_args_info)
@base.deploy_step(priority=0, argsinfo=_args_info)
def apply_configuration(self, task, settings):
"""Apply the BIOS configuration to the node
:param task: a TaskManager instance containing the node to act on
:param settings: List of BIOS settings to apply
:raises: DRACOperationError upon an error from python-dracclient
:returns: states.CLEANWAIT (cleaning) or states.DEPLOYWAIT (deployment)
if configuration is in progress asynchronously or None if it
is completed.
"""
LOG.debug("Configuring node %(node_uuid)s with BIOS settings:"
" %(settings)s", {"node_uuid": task.node.uuid,
"settings": settings})
node = task.node
# convert ironic settings list to DRAC kwsettings
kwsettings = {s['name']: s['value'] for s in settings}
drac_job.validate_job_queue(node)
client = drac_common.get_drac_client(node)
try:
# Argument validation is done by the dracclient method
# set_bios_settings. No need to do it here.
set_result = client.set_bios_settings(kwsettings)
except drac_exceptions.BaseClientException as exc:
LOG.error("Failed to apply BIOS config on node %(node_uuid)s."
" Error %(error)s", {"node_uuid": task.node.uuid,
"error": exc})
raise exception.DracOperationError(error=exc)
# If no commit is required, we're done
if not set_result['is_commit_required']:
LOG.info("Completed BIOS configuration on node %(node_uuid)s"
" with BIOS settings: %(settings)s",
{
"node_uuid": task.node.uuid,
"settings": settings
})
return
# Otherwise, need to reboot the node as well to commit configuration
else:
LOG.debug("Rebooting node %(node_uuid)s to apply BIOS settings",
{"node_uuid": task.node.uuid})
reboot_needed = set_result['is_reboot_required']
try:
commit_result = client.commit_pending_bios_changes(
reboot=reboot_needed)
except drac_exceptions.BaseClientException as exc:
LOG.error("Failed to commit BIOS changes on node %(node_uuid)s"
". Error %(error)s", {"node_uuid": task.node.uuid,
"error": exc})
raise exception.DracOperationError(error=exc)
# Store JobID for the async job handler _check_node_bios_jobs
driver_internal_info = node.driver_internal_info
driver_internal_info.setdefault(
'bios_config_job_ids', []).append(commit_result)
node.driver_internal_info = driver_internal_info
# This method calls node.save(), bios_config_job_ids will be saved
# automatically
# These flags are for the conductor to manage the asynchronous
# jobs that have been initiated by this method
deploy_utils.set_async_step_flags(
node,
reboot=reboot_needed,
skip_current_step=True,
polling=True)
# Return the clean/deploy state string
return deploy_utils.get_async_step_return_state(node)
@METRICS.timer('DracWSManBIOS._query_bios_config_job_status')
# TODO(noor): Consider patch of CONF to add an entry for BIOS query
# spacing since BIOS jobs could be comparatively shorter in time than
# RAID ones currently using the raid spacing to avoid errors
# spacing parameter for periodic method
@periodics.periodic(
spacing=CONF.drac.query_raid_config_job_status_interval)
def _query_bios_config_job_status(self, manager, context):
"""Periodic task to check the progress of running BIOS config jobs.
:param manager: an instance of Ironic Conductor Manager with
the node list to act on
:param context: context of the request, needed when acquiring
a lock on a node. For access control.
"""
filters = {'reserved': False, 'maintenance': False}
fields = ['driver_internal_info']
node_list = manager.iter_nodes(fields=fields, filters=filters)
for (node_uuid, driver, conductor_group,
driver_internal_info) in node_list:
try:
lock_purpose = 'checking async bios configuration jobs'
job_ids = driver_internal_info.get('bios_config_job_ids')
# Performing read-only/non-destructive work with shared lock
with task_manager.acquire(context, node_uuid,
purpose=lock_purpose,
shared=True) as task:
# skip a node not being managed by idrac driver
if not isinstance(task.driver.bios, DracWSManBIOS):
continue
# skip if nothing to check on this node
if not job_ids:
continue
self._check_node_bios_jobs(task)
except exception.NodeNotFound:
LOG.info("During query_bios_config_job_status, node "
"%(node)s was not found and presumed deleted by "
"another process.", {'node': node_uuid})
except exception.NodeLocked:
LOG.info("During query_bios_config_job_status, node "
"%(node)s was already locked by another process. "
"Skip.", {'node': node_uuid})
def _check_node_bios_jobs(self, task):
"""Check the progress of running BIOS config jobs of a node.
This handles jobs for BIOS set and reset. Handle means,
it checks for job status to not only signify completed jobs but
also handle failures by invoking the 'fail' event, allowing the
conductor to put the node into clean/deploy FAIL state.
:param task: a TaskManager instance with the node to act on
"""
node = task.node
bios_config_job_ids = node.driver_internal_info['bios_config_job_ids']
finished_job_ids = []
# local variable to track job failures
job_failed = False
for config_job_id in bios_config_job_ids:
config_job = drac_job.get_job(node, job_id=config_job_id)
if config_job is None or config_job.status == 'Completed':
finished_job_ids.append(config_job_id)
elif config_job.status == 'Failed':
finished_job_ids.append(config_job_id)
job_failed = True
# If no job has finished, return
if not finished_job_ids:
return
# The finished jobs will require a node reboot, need to update the
# node lock to exclusive, allowing a destructive reboot operation
task.upgrade_lock()
# Cleanup the database with finished jobs, they're no longer needed
self._delete_cached_config_job_ids(node, finished_job_ids)
if not job_failed:
# Cache the new BIOS settings, caching needs to happen here
# since the config steps are async. Decorator won't work.
self.cache_bios_settings(task)
# if no failure, continue with clean/deploy
self._resume_current_operation(task)
else:
# invoke 'fail' event to allow conductor to put the node in
# a clean/deploy fail state
self._set_failed(task, config_job)
def _delete_cached_config_job_ids(self, node, finished_job_ids=None):
"""Remove Job IDs from the driver_internal_info table in database.
:param node: an ironic node object
:param finished_job_ids: a list of finished Job ID strings to remove
"""
if finished_job_ids is None:
finished_job_ids = []
driver_internal_info = node.driver_internal_info
# take out the unfinished job ids from all the jobs
unfinished_job_ids = [job_id for job_id
in driver_internal_info['bios_config_job_ids']
if job_id not in finished_job_ids]
# assign the unfinished job ids back to the total list
# this will clear the finished jobs from the list
driver_internal_info['bios_config_job_ids'] = unfinished_job_ids
node.driver_internal_info = driver_internal_info
node.save()
def _set_failed(self, task, config_job):
"""Set the node in failed state by invoking 'fail' event.
:param task: a TaskManager instance with node to act on
:param config_job: a python-dracclient Job object (named tuple)
"""
LOG.error("BIOS configuration job failed for node %(node)s. "
"Failed config job: %(config_job_id)s. "
"Message: '%(message)s'.",
{'node': task.node_uuid, 'config_job_id': config_job.id,
'message': config_job.message})
task.node.last_error = config_job.message
# tell conductor to handle failure of clean/deploy step
task.process_event('fail')
def _resume_current_operation(self, task):
"""Continue cleaning/deployment of the node.
For asynchronous operations, it is necessary to notify the
conductor manager to continue the cleaning/deployment operation
after a job has finished. This is done through an RPC call. The
notify_conductor_resume_* wrapper methods provide that.
:param task: a TaskManager instance with node to act on
"""
if task.node.clean_step:
manager_utils.notify_conductor_resume_clean(task)
else:
manager_utils.notify_conductor_resume_deploy(task)
@METRICS.timer('DracWSManBIOS.factory_reset')
@base.clean_step(priority=0)
@base.deploy_step(priority=0)
def factory_reset(self, task):
"""Reset the BIOS settings of the node to the factory default.
This uses the Lifecycle Controller configuration to perform
BIOS configuration reset. Leveraging the python-dracclient
methods already available.
:param task: a TaskManager instance containing the node to act on
:raises: DracOperationError on an error from python-dracclient
:returns: states.CLEANWAIT (cleaning) or states.DEPLOYWAIT
(deployment) if reset is in progress asynchronously or None
if it is completed.
"""
node = task.node
drac_job.validate_job_queue(node)
client = drac_common.get_drac_client(node)
lc_bios_reset_attrib = {
"BIOS Reset To Defaults Requested": "True"
}
try:
set_result = client.set_lifecycle_settings(lc_bios_reset_attrib)
except drac_exceptions.BaseClientException as exc:
LOG.error('Failed to reset BIOS on the node %(node_uuid)s.'
' Reason: %(error)s.', {'node_uuid': node.uuid,
'error': exc})
raise exception.DracOperationError(error=exc)
if not set_result['is_commit_required']:
LOG.info("BIOS reset successful on the node "
"%(node_uuid)s", {"node_uuid": node.uuid})
return
else:
# Rebooting the Node is compulsory, LC call returns
# reboot_required=False/Optional, which is not desired
reboot_needed = True
try:
commit_job_id = client.commit_pending_lifecycle_changes(
reboot=reboot_needed)
except drac_exceptions.BaseClientException as exc:
LOG.error('Failed to commit BIOS reset on node'
'%(node_uuid)s. Reason: %(error)s.', {
'node_uuid': node.uuid,
'error': exc})
raise exception.DracOperationError(error=exc)
# Store JobID for the async job handler _check_node_bios_jobs
driver_internal_info = node.driver_internal_info
driver_internal_info.setdefault(
'bios_config_job_ids', []).append(commit_job_id)
node.driver_internal_info = driver_internal_info
# This method calls node.save(), bios_config_job_id will be
# saved automatically
# These flags are for the conductor to manage the asynchronous
# jobs that have been initiated by this method
deploy_utils.set_async_step_flags(
node,
reboot=reboot_needed,
skip_current_step=True,
polling=True)
return deploy_utils.get_async_step_return_state(task.node)
def cache_bios_settings(self, task):
"""Store or update the current BIOS settings for the node.
Get the current BIOS settings and store them in the bios_settings
database table.
:param task: a TaskManager instance containing the node to act on.
:raises: DracOperationError on an error from python-dracclient
"""
node = task.node
node_id = node.id
node_uuid = node.uuid
client = drac_common.get_drac_client(node)
try:
kwsettings = client.list_bios_settings()
except drac_exceptions.BaseClientException as exc:
LOG.error('DRAC driver failed to get the BIOS settings for node '
'%(node_uuid)s. Reason: %(error)s.',
{'node_uuid': node.uuid,
'error': exc})
raise exception.DracOperationError(error=exc)
# convert dracclient BIOS settings into ironic settings list
settings = [{"name": name, "value": attrib.current_value}
for name, attrib in kwsettings.items()]
# Store them in the database table
LOG.debug('Caching BIOS settings for node %(node_uuid)s', {
'node_uuid': node_uuid})
create_list, update_list, delete_list, nochange_list = (
objects.BIOSSettingList.sync_node_setting(
task.context, node_id, settings))
if create_list:
objects.BIOSSettingList.create(
task.context, node_id, create_list)
if update_list:
objects.BIOSSettingList.save(
task.context, node_id, update_list)
if delete_list:
delete_names = [d['name'] for d in delete_list]
objects.BIOSSettingList.delete(
task.context, node_id, delete_names)
# BaseInterface methods implementation
def get_properties(self):
"""Return the properties of the BIOS Interface
:returns: dictionary of <property name>: <property description> entries
"""
return drac_common.COMMON_PROPERTIES
def validate(self, task):
"""Validates the driver-specific information used by the idrac BMC
:param task: a TaskManager instance containing the node to act on
:raises: InvalidParameterValue if some mandatory information
is missing on the node or on invalid inputs
"""
drac_common.parse_driver_info(task.node)
def get_config(node):
"""Get the BIOS configuration.

207
ironic/tests/unit/drivers/modules/drac/test_bios.py
View File

@ -23,14 +23,221 @@ from dracclient import exceptions as drac_exceptions
import mock
from ironic.common import exception
from ironic.common import states
from ironic.conductor import task_manager
from ironic.drivers.modules import deploy_utils
from ironic.drivers.modules.drac import bios as drac_bios
from ironic.drivers.modules.drac import common as drac_common
from ironic.drivers.modules.drac import job as drac_job
from ironic import objects
from ironic.tests.unit.drivers.modules.drac import utils as test_utils
from ironic.tests.unit.objects import utils as obj_utils
INFO_DICT = test_utils.INFO_DICT
class DracWSManBIOSConfigurationTestCase(test_utils.BaseDracTest):
def setUp(self):
super(DracWSManBIOSConfigurationTestCase, self).setUp()
self.node = obj_utils.create_test_node(self.context,
driver='idrac',
driver_info=INFO_DICT)
patch_get_drac_client = mock.patch.object(
drac_common, 'get_drac_client', spec_set=True, autospec=True)
mock_get_drac_client = patch_get_drac_client.start()
self.mock_client = mock_get_drac_client.return_value
self.addCleanup(patch_get_drac_client.stop)
proc_virt_attr = {
'current_value': 'Enabled',
'pending_value': None,
'read_only': False,
'possible_values': ['Enabled', 'Disabled']}
mock_proc_virt_attr = mock.NonCallableMock(spec=[], **proc_virt_attr)
mock_proc_virt_attr.name = 'ProcVirtualization'
self.bios_attrs = {'ProcVirtualization': mock_proc_virt_attr}
self.mock_client.set_lifecycle_settings.return_value = {
"is_commit_required": True
}
self.mock_client.commit_pending_lifecycle_changes.return_value = \
"JID_1234"
self.mock_client.set_bios_settings.return_value = {
"is_commit_required": True,
"is_reboot_required": True
}
self.mock_client.commit_pending_bios_changes.return_value = \
"JID_5678"
@mock.patch.object(drac_common, 'parse_driver_info',
autospec=True)
def test_validate(self, mock_parse_driver_info):
with task_manager.acquire(self.context, self.node.uuid) as task:
task.driver.bios.validate(task)
mock_parse_driver_info.assert_called_once_with(task.node)
def test_get_properties(self):
with task_manager.acquire(self.context, self.node.uuid) as task:
test_properties = task.driver.bios.get_properties()
for each_property in drac_common.COMMON_PROPERTIES:
self.assertIn(each_property, test_properties)
@mock.patch.object(objects, 'BIOSSettingList', autospec=True)
def test_cache_bios_settings_noop(self, mock_BIOSSettingList):
create_list = []
update_list = []
delete_list = []
nochange_list = [{'name': 'ProcVirtualization', 'value': 'Enabled'}]
mock_BIOSSettingList.sync_node_setting.return_value = (
create_list, update_list, delete_list, nochange_list)
self.mock_client.list_bios_settings.return_value = self.bios_attrs
with task_manager.acquire(self.context, self.node.uuid) as task:
kwsettings = self.mock_client.list_bios_settings()
settings = [{"name": name,
"value": attrib.__dict__['current_value']}
for name, attrib in kwsettings.items()]
self.mock_client.list_bios_settings.reset_mock()
task.driver.bios.cache_bios_settings(task)
self.mock_client.list_bios_settings.assert_called_once_with()
mock_BIOSSettingList.sync_node_setting.assert_called_once_with(
task.context, task.node.id, settings)
mock_BIOSSettingList.create.assert_not_called()
mock_BIOSSettingList.save.assert_not_called()
mock_BIOSSettingList.delete.assert_not_called()
def test_cache_bios_settings_fail(self):
exc = drac_exceptions.BaseClientException('boom')
self.mock_client.list_bios_settings.side_effect = exc
with task_manager.acquire(self.context, self.node.uuid,
shared=False) as task:
self.assertRaises(exception.DracOperationError,
task.driver.bios.cache_bios_settings, task)
@mock.patch.object(deploy_utils, 'get_async_step_return_state',
autospec=True)
@mock.patch.object(deploy_utils, 'set_async_step_flags', autospec=True)
@mock.patch.object(drac_bios.DracWSManBIOS, 'cache_bios_settings',
spec_set=True)
@mock.patch.object(drac_job, 'validate_job_queue', spec_set=True,
autospec=True)
def _test_step(self, mock_validate_job_queue, mock_cache_bios_settings,
mock_set_async_step_flags,
mock_get_async_step_return_state):
if self.node.clean_step:
step_data = self.node.clean_step
expected_state = states.CLEANWAIT
mock_get_async_step_return_state.return_value = states.CLEANWAIT
else:
step_data = self.node.deploy_step
expected_state = states.DEPLOYWAIT
mock_get_async_step_return_state.return_value = states.DEPLOYWAIT
data = step_data['argsinfo'].get('settings', None)
step = step_data['step']
if step == 'apply_configuration':
attributes = {s['name']: s['value'] for s in data}
with task_manager.acquire(self.context, self.node.uuid,
shared=False) as task:
info = task.node.driver_internal_info
if step == 'factory_reset':
ret_state = task.driver.bios.factory_reset(task)
attrib = {"BIOS Reset To Defaults Requested": "True"}
self.mock_client.set_lifecycle_settings.\
assert_called_once_with(attrib)
self.mock_client.commit_pending_lifecycle_changes.\
assert_called_once_with(reboot=True)
job_id = self.mock_client.commit_pending_lifecycle_changes()
self.assertIn(job_id, info['bios_config_job_ids'])
if step == 'apply_configuration':
ret_state = task.driver.bios.apply_configuration(task, data)
self.mock_client.set_bios_settings.assert_called_once_with(
attributes)
self.mock_client.commit_pending_bios_changes.\
assert_called_once_with(reboot=True)
job_id = self.mock_client.commit_pending_bios_changes()
self.assertIn(job_id, info['bios_config_job_ids'])
mock_validate_job_queue.assert_called_once_with(task.node)
mock_set_async_step_flags.assert_called_once_with(
task.node, reboot=True, skip_current_step=True, polling=True)
mock_get_async_step_return_state.assert_called_once_with(
task.node)
self.assertEqual(expected_state, ret_state)
def test_factory_reset_clean(self):
self.node.clean_step = {'priority': 100, 'interface': 'bios',
'step': 'factory_reset', 'argsinfo': {}}
self.node.save()
self._test_step()
def test_factory_reset_deploy(self):
self.node.deploy_step = {'priority': 100, 'interface': 'bios',
'step': 'factory_reset', 'argsinfo': {}}
self.node.save()
self._test_step()
def test_apply_configuration_clean(self):
settings = [{'name': 'ProcVirtualization', 'value': 'Enabled'}]
self.node.clean_step = {'priority': 100, 'interface': 'bios',
'step': 'apply_configuration',
'argsinfo': {'settings': settings}}
self.node.save()
self._test_step()
def test_apply_configuration_deploy(self):
settings = [{'name': 'ProcVirtualization', 'value': 'Enabled'}]
self.node.deploy_step = {'priority': 100, 'interface': 'bios',
'step': 'apply_configuration',
'argsinfo': {'settings': settings}}
self.node.save()
self._test_step()
def test_apply_conf_set_fail(self):
exc = drac_exceptions.BaseClientException('boom')
self.mock_client.set_bios_settings.side_affect = exc
settings = [{'name': 'ProcVirtualization', 'value': 'Enabled'}]
with task_manager.acquire(self.context, self.node.uuid) as task:
self.assertRaises(exception.DracOperationError,
task.driver.bios.apply_configuration, task,
settings)
def test_apply_conf_commit_fail(self):
exc = drac_exceptions.BaseClientException('boom')
self.mock_client.commit_pending_bios_changes.side_affect = exc
settings = [{'name': 'ProcVirtualization', 'value': 'Enabled'}]
with task_manager.acquire(self.context, self.node.uuid) as task:
self.assertRaises(exception.DracOperationError,
task.driver.bios.apply_configuration, task,
settings)
def test_factory_reset_set_fail(self):
exc = drac_exceptions.BaseClientException('boom')
self.mock_client.set_lifecycle_settings.side_affect = exc
with task_manager.acquire(self.context, self.node.uuid) as task:
self.assertRaises(exception.DracOperationError,
task.driver.bios.factory_reset, task)
def test_factory_reset_commit_fail(self):
exc = drac_exceptions.BaseClientException('boom')
self.mock_client.commit_pending_lifecycle_changes.side_affect = exc
with task_manager.acquire(self.context, self.node.uuid) as task:
self.assertRaises(exception.DracOperationError,
task.driver.bios.factory_reset, task)
class DracBIOSConfigurationTestCase(test_utils.BaseDracTest):
def setUp(self):

3
ironic/tests/unit/drivers/modules/drac/utils.py
View File

@ -37,7 +37,8 @@ class BaseDracTest(db_base.DbTestCase):
'idrac-wsman', 'fake', 'no-inspect'],
enabled_vendor_interfaces=[
'idrac-wsman', 'fake', 'no-vendor'],
enabled_raid_interfaces=['idrac-wsman', 'fake', 'no-raid'])
enabled_raid_interfaces=['idrac-wsman', 'fake', 'no-raid'],
enabled_bios_interfaces=['idrac-wsman', 'no-bios'])
class DictToObj(object):

4
ironic/tests/unit/drivers/test_drac.py
View File

@ -44,7 +44,9 @@ class IDRACHardwareTestCase(db_base.DbTestCase):
enabled_raid_interfaces=[
'idrac', 'idrac-wsman', 'no-raid'],
enabled_vendor_interfaces=[
'idrac', 'idrac-wsman', 'no-vendor'])
'idrac', 'idrac-wsman', 'no-vendor'],
enabled_bios_interfaces=[
'idrac-wsman', 'no-bios'])
def _validate_interfaces(self, driver, **kwargs):
self.assertIsInstance(

8
releasenotes/notes/idrac-wsman-bios-interface-b39a51828f61eff6.yaml Normal file
View File

@ -0,0 +1,8 @@
---
features:
- |
Implemented the ``BIOS interface`` for the ``idrac`` hardware type.
Primarily, implemented ``factory_reset`` and ``apply_configuration``
clean and deploy steps, as asynchronous operations.
For more details, see story `2007400
<https://storyboard.openstack.org/#!/story/2007400>`_.

1
setup.cfg
View File

@ -54,6 +54,7 @@ ironic.dhcp =
ironic.hardware.interfaces.bios =
fake = ironic.drivers.modules.fake:FakeBIOS
idrac-wsman = ironic.drivers.modules.drac.bios:DracWSManBIOS
ilo = ironic.drivers.modules.ilo.bios:IloBIOS
irmc = ironic.drivers.modules.irmc.bios:IRMCBIOS
no-bios = ironic.drivers.modules.noop:NoBIOS