openstack
/
ironic
Code Issues Proposed changes

Use trailing slash in the agent command URL 

Currently every call results in a redirect /commands -> /commands/

Change-Id: I711a1626ac8fc621114d283d899b6cf7315057f6
This commit is contained in:
Dmitry Tantsur 2020-04-15 10:25:39 +02:00
parent 123cb22c73
commit cc29461d20
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ironic/drivers/modules/agent_client.py
View File

@ -45,7 +45,7 @@ class AgentClient(object):
raise exception.IronicException(_('Agent driver requires '
'agent_url in '
'driver_internal_info'))
return ('%(agent_url)s/%(api_version)s/commands' %
return ('%(agent_url)s/%(api_version)s/commands/' %
{'agent_url': agent_url,
'api_version': CONF.agent.agent_api_version})

3
ironic/tests/unit/drivers/modules/test_agent_client.py
View File

@ -70,7 +70,8 @@ class TestAgentClient(base.TestCase):
def test__get_command_url(self):
command_url = self.client._get_command_url(self.node)
expected = self.node.driver_internal_info['agent_url'] + '/v1/commands'
expected = ('%s/v1/commands/'
% self.node.driver_internal_info['agent_url'])
self.assertEqual(expected, command_url)
def test__get_command_url_fail(self):