openstack
/
ironic
Code Issues Proposed changes

Skip tests that fail occassionally in CI 

These tests fail in CI some 5-10% of the time, leading to unneeded CI
churn and rechecks.

The problem with the intermittant failure is related to how the test
is constructed, not to the code itself.

https://bugs.launchpad.net/ironic/+bug/2024994 has been filed to track
true resolution of this issue, but until then, we should not abuse CI
resources by continuing to run tests.

Depends-On: https://review.opendev.org/c/openstack/ironic/+/886881
Related-Bug: https://bugs.launchpad.net/ironic/+bug/2024994
Change-Id: I9f124b005d346f961f9c95c917d5014988a7f45e
This commit is contained in:
Jay Faulkner 2023-06-25 14:52:34 -07:00
parent 4a570042c9
commit d5e4f013c8
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
ironic/tests/unit/drivers/modules/network/test_common.py
View File

@ -13,6 +13,7 @@
import json
import os
from unittest import mock
from unittest import skip
from oslo_config import cfg
from oslo_utils import uuidutils
@ -1057,6 +1058,7 @@ class TestNeutronVifPortIDMixin(db_base.DbTestCase):
self.interface.port_changed(task, self.port)
self.assertFalse(mac_update_mock.called)
@skip("https://bugs.launchpad.net/ironic/+bug/2024994")
@mock.patch('ironic.dhcp.neutron.NeutronDHCPApi.update_port_dhcp_opts',
autospec=True)
def test_port_changed_client_id(self, dhcp_update_mock):
@ -1074,6 +1076,7 @@ class TestNeutronVifPortIDMixin(db_base.DbTestCase):
mock.ANY, 'fake-id', expected_dhcp_opts, context=task.context)
self.assertEqual(2, what_changed_mock.call_count)
@skip("https://bugs.launchpad.net/ironic/+bug/2024994")
@mock.patch('ironic.dhcp.neutron.NeutronDHCPApi.update_port_dhcp_opts',
autospec=True)
def test_port_changed_extra_add_new_key(self, dhcp_update_mock):
@ -1086,6 +1089,7 @@ class TestNeutronVifPortIDMixin(db_base.DbTestCase):
self.interface.port_changed(task, self.port)
self.assertFalse(dhcp_update_mock.called)
@skip("https://bugs.launchpad.net/ironic/+bug/2024994")
@mock.patch('ironic.dhcp.neutron.NeutronDHCPApi.update_port_dhcp_opts',
autospec=True)
def test_port_changed_client_id_fail(self, dhcp_update_mock):
@ -1111,6 +1115,7 @@ class TestNeutronVifPortIDMixin(db_base.DbTestCase):
task, port)
self.assertEqual(2, what_changed_mock.call_count)
@skip("https://bugs.launchpad.net/ironic/+bug/2024994")
@mock.patch('ironic.dhcp.neutron.NeutronDHCPApi.update_port_dhcp_opts',
autospec=True)
def test_port_changed_client_id_no_vif_id(self, dhcp_update_mock):
@ -1122,6 +1127,7 @@ class TestNeutronVifPortIDMixin(db_base.DbTestCase):
self.interface.port_changed(task, self.port)
self.assertFalse(dhcp_update_mock.called)
@skip("https://bugs.launchpad.net/ironic/+bug/2024994")
@mock.patch('ironic.dhcp.neutron.NeutronDHCPApi.update_port_dhcp_opts',
autospec=True)
def test_port_changed_message_format_failure(self, dhcp_update_mock):