From e95d5a8446aa06740f43ac20933d1f57dddd82d8 Mon Sep 17 00:00:00 2001 From: Mahnoor Asghar Date: Thu, 27 Jun 2024 10:16:10 -0400 Subject: [PATCH] Fix log statement about starting inspection Change-Id: I3e5a63100882774e85235f6f0d8aeb0c2a9610ca --- ironic/drivers/modules/inspector/agent.py | 2 +- ironic/drivers/modules/inspector/interface.py | 11 +++++------ 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/ironic/drivers/modules/inspector/agent.py b/ironic/drivers/modules/inspector/agent.py index baa6201d7f..727058b315 100644 --- a/ironic/drivers/modules/inspector/agent.py +++ b/ironic/drivers/modules/inspector/agent.py @@ -45,7 +45,7 @@ class AgentInspect(common.Common): self.hooks = hooks_base.validate_inspection_hooks() def _start_managed_inspection(self, task): - """Start inspection managed by ironic.""" + """Start inspection with boot managed by ironic.""" ep = deploy_utils.get_ironic_api_url().rstrip('/') if ep.endswith('/v1'): ep = f'{ep}/continue_inspection' diff --git a/ironic/drivers/modules/inspector/interface.py b/ironic/drivers/modules/inspector/interface.py index e0f142370e..aa71ce1787 100644 --- a/ironic/drivers/modules/inspector/interface.py +++ b/ironic/drivers/modules/inspector/interface.py @@ -190,8 +190,7 @@ class Common(base.InspectInterface): def inspect_hardware(self, task): """Inspect hardware to obtain the hardware properties. - This particular implementation only starts inspection using - ironic-inspector. Results will be checked in a periodic task. + Results will be checked in a periodic task. :param task: a task from TaskManager. :returns: states.INSPECTWAIT @@ -214,8 +213,8 @@ class Common(base.InspectInterface): inspect_utils.cache_lookup_addresses(task.node) task.node.save() - LOG.debug('Starting inspection for node %(uuid)s using ' - 'ironic-inspector, booting is managed by %(project)s', + LOG.debug('Starting inspection for node %(uuid)s. Booting is ' + 'managed by %(project)s', {'uuid': task.node.uuid, 'project': 'ironic' if manage_boot else 'ironic-inspector'}) @@ -237,7 +236,7 @@ class Inspector(Common): """In-band inspection via ironic-inspector project.""" def _start_managed_inspection(self, task): - """Start inspection managed by ironic.""" + """Start inspection with boot managed by ironic.""" cli = client.get_client(task.context) endpoint = _get_callback_endpoint(cli) prepare_managed_inspection(task, endpoint) @@ -313,7 +312,7 @@ def _start_inspection(node_uuid, context): def _check_status(task): - """Check inspection status for node given by a task.""" + """Check inspection status from inspector for node given by a task.""" node = task.node if node.provision_state != states.INSPECTWAIT: return