openstack
/
ironic
Code Issues Proposed changes

Merge "Log the traceback of unexpected errors when verifying power credentials"

This commit is contained in:
Zuul 2020-08-05 23:44:54 +00:00 committed by Gerrit Code Review
parent 6026481415 040523ad10
commit f084006293
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ironic/conductor/manager.py
View File

@ -1228,6 +1228,8 @@ class ConductorManager(base_manager.BaseConductorManager):
error = (_('Failed to validate power driver interface for node '
'%(node)s. Error: %(msg)s') %
{'node': node.uuid, 'msg': e})
log_traceback = not isinstance(e, exception.IronicException)
LOG.error(error, exc_info=log_traceback)
else:
try:
power_state = task.driver.power.get_power_state(task)
@ -1235,6 +1237,8 @@ class ConductorManager(base_manager.BaseConductorManager):
error = (_('Failed to get power state for node '
'%(node)s. Error: %(msg)s') %
{'node': node.uuid, 'msg': e})
log_traceback = not isinstance(e, exception.IronicException)
LOG.error(error, exc_info=log_traceback)
if error is None:
if power_state != node.power_state:
@ -1246,7 +1250,6 @@ class ConductorManager(base_manager.BaseConductorManager):
else:
task.process_event('done')
else:
LOG.error(error)
node.last_error = error
task.process_event('fail')