openstack/ironic
Code Issues Proposed changes

Modify do_node_verify to avoid state machine stuck

Browse Source 
do_node_verify function runs vendor-driver-defined verify_step.
However, when vendor verify_step fails, it causes stuck of state
machine at verifying.
This is because do_node_verify function tries to retrieve name
of verify_step through node.verify_step but node doesn't have
verify_step attribute and there is no way to handle exception.

This commit fixes this issue.

Change-Id: Ie2ec6e08214661f7dc61c92de646e2f4d5bb5469
Story: 2010209
Task: 45942
This commit is contained in:
Vanou Ishii 2022-08-03 13:39:48 +09:00
parent 45c9c3029f
commit f6d2b2ed93
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
ironic/conductor/verify.py
View File

@ -63,7 +63,7 @@ def do_node_verify(task):
except Exception as e:
error = ('Node %(node)s failed verify step %(step)s '
'with unexpected error: %(err)s' %
{'node': node.uuid, 'step': node.verify_step,
{'node': node.uuid, 'step': step['step'],
'err': e})
utils.verifying_error_handler(
task, error,