Commit Graph

12735 Commits (master)

Author SHA1 Message Date
Zuul dcea5f5a1d Merge "Fix log message var reference" 2023-12-06 13:00:24 +00:00
Zuul 32f110d7ef Merge "[trivial] remove note on non-voting snmp job" 2023-12-06 00:09:16 +00:00
Zuul 209714010b Merge "Fix volume_name issue in Redfish RAID" 2023-12-05 22:11:15 +00:00
Zuul 5ca5df8217 Merge "Handle internal server errors while configuring secure boot" 2023-12-05 20:39:43 +00:00
Mahnoor Asghar a98681f1d3 Fix volume_name issue in Redfish RAID
Use the 'volume_name' field from the logical_disk in the
target_raid_config field of a node, instead of just 'name' (which is
incorrect as per the Ironic API expectation), to create the RAID volume

Change-Id: Ib8b2589d91be67a848411ab6be852bcb4de58bc7
2023-12-05 16:41:53 +01:00
Zuul 0853a08d1e Merge "Add volume name to Redfish RAID volumes" 2023-12-04 16:31:06 +00:00
Mahnoor Asghar bfaf64b46f Add volume name to Redfish RAID volumes
Change-Id: I12fccda8fee73430fee03a91134fd559ebf40cc9
2023-12-04 11:10:59 +01:00
James Denton 578c02813d Fix log message var reference
Fixes an issue with debug logging referencing node vs node_uuid.

Change-Id: Ic7de9826fbec32038947be89b14f6dfdc2248de4
2023-12-03 06:11:43 -06:00
Zuul 58956b8e6b Merge "Improve logging in the dnsmasq DHCP provider" 2023-12-01 23:20:33 +00:00
Zuul 68863aa452 Merge "fix nits related to image server bauth" 2023-12-01 21:13:12 +00:00
Dmitry Tantsur a6e3a7f50c
Handle internal server errors while configuring secure boot
At least on some Dell machines, the Redfish SecureBoot resource is
unavailable during configuration, GET requests return HTTP 503.
Sushy does retry these, but not for long enough (the error message
suggests at least 30 seconds, which would be too much to just integrate
in Sushy). This change treats internal errors the same way as
mismatching "enabled" value, i.e. just waits.

Change-Id: I676f48de6b6195a69ea76b4e8b45a034220db2fa
2023-12-01 17:36:31 +01:00
Adam Rozman 31f0e17a13 fix nits related to image server bauth
This commit:
  - fixes a few nits that were pointed out after the feature
    was merged
  - doesn't affect the functionality of the feature

Closes-Bug: #2021947
Change-Id: I1dd024b9994df2b367f61cea75eb71fabe57abfd
2023-12-01 11:09:15 +02:00
Riccardo Pittau d6491b0c82 [trivial] remove note on non-voting snmp job
Also fix a couple of yaml lint errors

Change-Id: I47f1734fe9c7af75d8eda61a36b97df0ce360ed0
2023-12-01 09:15:59 +01:00
Zuul 6c9de5324b Merge "Change snmp job to not use a focal node" 2023-12-01 00:49:06 +00:00
Zuul 22f0a206bb Merge "Fix *_by_arch documentation and un-deprecate the options without it" 2023-11-30 20:23:15 +00:00
Zuul b560273c31 Merge "CI: Remove deprecated devstack method" 2023-11-30 19:25:18 +00:00
Julia Kreger 1ffdabed9d Change snmp job to not use a focal node
tl;dr, devstack no longer supports focal, and now errors which
results in the job failing.

Also changes the snmp job to utilize the test_ramdisk_iso
feature, as *opposed* to a full deployment because iPXE
shipped with Ubuntu no longer likes to chain boot in UEFI
mode to a block device. The easiest path, is just to run
a ramdisk in that case, which also sort of mirrors what
users of the SNMP power interface *tend* to do.

Related-Bug: #2034588

Change-Id: I276885b8f0492ead8cea38fe13826123131984ea
2023-11-30 09:02:57 -08:00
Zuul be242dc13b Merge "Generic API for attaching/detaching virtual media" 2023-11-30 14:02:38 +00:00
Zuul 81396cea53 Merge "Document wsgi_service fix from 16a806f" 2023-11-29 11:40:29 +00:00
Steve Baker 2db444bce1 Replace swiftclient usage with openstacksdk
Object create/delete operations translate clearly from swiftclient to
the SDK. Switching the temp URL handling is a little more disruptive but
the result is slightly more centralized and enables key rotation.

Change-Id: I8df2f032224bd5e540139a798a7ab76a1aeebb06
Closes-Bug: #2042493
2023-11-29 12:44:30 +13:00
Jay Faulkner 25bb15aeee Document wsgi_service fix from 16a806f
We fixed a bug in wsgi_service around cleaningo up unix sockets; we
should document the fix in a release note.

Change-Id: I6ecb489ea1a9e6490c5ddca5c7467b0c4324dfd1
2023-11-28 14:17:28 -08:00
Zuul 16a806f941 Merge "Trivial: fix a typo in wsgi_service" 2023-11-28 21:53:03 +00:00
Zuul ce05c68302 Merge "Add missing compatibility between idrac and redfish firmware" 2023-11-28 21:30:49 +00:00
Zuul 8354c28a2d Merge "[trivial] add Python 3.11 mention in setup.cfg" 2023-11-28 19:55:27 +00:00
Zuul 922b904da8 Merge "Deprecate configuration molds" 2023-11-28 19:55:23 +00:00
Dmitry Tantsur 6e10ad9ad7
Add missing compatibility between idrac and redfish firmware
Change-Id: I3026a5c69930825ea2b88587e62b36e8824fa91e
2023-11-28 18:56:56 +01:00
Zuul 28b3f56b2c Merge "implement basic-auth support for user image download process" 2023-11-28 16:05:52 +00:00
Dmitry Tantsur 40edeed615
Improve logging in the dnsmasq DHCP provider
Currently, it logs a lot of entries without context, which won't be
readable when several nodes are deployed at the same time, nor when
someone greps for a node UUID.

Make fewer log entries and add node UUID for context.

While here, modernize the code a bit.

Change-Id: I3a840e47a09e77a9f8d35a7cf400c4bdd4111f91
2023-11-28 16:45:25 +01:00
Zuul 7f4bec112f Merge "Fix Redfish request collecting storage drives" 2023-11-28 15:21:13 +00:00
Mahnoor Asghar facd862a31 Fix Redfish request collecting storage drives
Fix the Redfish request payload collecting physical storage drives

Change-Id: I3b735709aa2f65b606a0747a2edf98f50af39f87
2023-11-28 13:16:45 +01:00
OpenStack Proposal Bot b44d16a155 Imported Translations from Zanata
For more information about this automatic import see:

Change-Id: Ic8640c58a80c49dbfe16b44b637a1fc28b5419e3
2023-11-28 02:52:10 +00:00
Zuul 6431626de8 Merge "Ensure enable_netboot_fallback writes out pxe config on adopt." 2023-11-28 00:51:43 +00:00
Zuul 7f318bc68f Merge "Multiple driver related deprecations" 2023-11-27 19:01:18 +00:00
Julia Kreger 5db871ead6 Deprecate configuration molds
Per the consensus during the 2024.1 PTG, configuration molds
are being deprecated in favor of a to be developed in the future
step templating mechanism.

Change-Id: Ieab94972e89ca9cded7fae225191bd63d9311581
2023-11-27 09:21:38 -08:00
Dmitry Tantsur 203660a0be
Fix *_by_arch documentation and un-deprecate the options without it
First, the *_by_arch options are not a replacement for plain options:
the cpu_arch property is neither required not standardized. This is why
older options with *_by_arch equivalents are not deprecated.

Second, the example in the documentation is wrong: oslo.config does not
use Python dictionaries. Which makes me suspect that the feature has
never been properly tested (indeed, it's not used in the devstack CI,
and Bifrost uses the older options).

Change-Id: If1e633930909ce9d80e14f3ec3daa0bf8d48b7f0
2023-11-27 18:12:58 +01:00
Dmitry Tantsur 01507db18c
Trivial: fix a typo in wsgi_service
Change-Id: Ia7d8ed8b40db7e3d6752e768113ccf52318ee374
2023-11-24 18:51:09 +01:00
Zuul 281cebedd6 Merge "Document new bug deputy role for Ironic" 2023-11-24 08:50:08 +00:00
Zuul 405a1076db Merge "[api-ref] Add firmware fields to driver API" 2023-11-23 16:16:15 +00:00
Zane Bitter 0d59e25cf8 Use per-node external_http_url for boot ISO
When the per-node external_http_url feature was introduced by
c197a2d8b2, it only applied to a config
floppy. This fix ensures that it is also used for the boot ISO, both
when it is generated locally (by _prepare_iso_image()) or just cached
locally (by prepare_remote_image()).

Change-Id: Ic241da6845b4d97fd29888e28cc1d9ee34e182c1
Closes-Bug: #2044314
2023-11-23 23:27:00 +13:00
Dmitry Tantsur 0902912217 Generic API for attaching/detaching virtual media
This patch allows to attach or detach a generic image as
virtual media device after a node has been provisioned.

Closes-Bug: #2033288
Change-Id: I97b68047d769f6fb686c53e89084b5874e02b8c7
2023-11-23 09:55:09 +01:00
Zuul a367151914 Merge "[api-ref] Complete port name and shard documentation" 2023-11-23 01:38:16 +00:00
Julia Kreger 6ac1308050 Multiple driver related deprecations
An outcome of the Ironic 2024.1 PTG was that we would go ahead and
deprecate the ibmc, xclarity, and the wsman interfaces of the idrac
hardware type.

The forward path is Redfish, as evidenced by the idrac hardware
type having both wsman and redfish based interfaces available
for users to choose from.

These changes are being made by the Ironic team due to a lack of
recent upstream contact with any of the related driver maintainers.

Change-Id: Ia4aa99f4987570426bb155af8f437c9ba6013837
2023-11-20 10:46:56 -08:00
Julia Kreger ce300b3de1 CI: Remove deprecated devstack method
Removes get_uefi_ipxe_boot_file from the devstack plugin
as it is no longer used.

Change-Id: I5eed744a4746767b216399b132e98298471b4ab7
2023-11-16 15:16:49 -08:00
Adam Rozman 3ea4bb234c implement basic-auth support for user image download process
This feature was proposed in

Change-Id: I70733fbf6b06c4e99888c6c38212e578c65ef92f
Signed-off-by: Adam Rozman <>
2023-11-13 15:37:27 +02:00
Steve Baker 81acd5df24 Implement drain shutdown support
Sending signal ``SIGUSR2`` to a conductor process will now trigger a
drain shutdown. This is similar to a ``SIGTERM`` graceful shutdown but
the timeout is determined by ``[DEFAULT]drain_shutdown_timeout`` which
defaults to ``1800`` seconds. This is enough time for running tasks on
existing reserved nodes to either complete or reach their own failure

During the drain period the conductor needs to be removed from the hash
ring to prevent new tasks from starting. Other conductors also need to
not fail reserved nodes on the draining conductor which would appear to
be orphaned.  This is achieved by running the conductor keepalive
heartbeat for this period, but setting the ``online`` state to

When this feature was proposed, SIGINT was suggested as the signal to
use to trigger a drain shutdown. However this is already used by
oslo_service fast exit[1] so using this for drain would be a change in
existing behaviour.


Change-Id: I777898f5a14844c9ac9967168f33d55c4f97dfb9
2023-11-13 10:38:18 +13:00
Zuul ff4e836c55 Merge "Add the setting of memcached servers to keystone_authtoken" 2023-11-12 20:14:50 +00:00
Zuul 266f991a13 Merge "Make sqlalchemy-2x job voting again" 2023-11-12 08:31:12 +00:00
Zuul dbd8cf7d1b Merge "Fix unit tests broken by olso.utils" 2023-11-09 22:04:04 +00:00
Takashi Kajinami f42b359bd9 Make sqlalchemy-2x job voting again
... because the new oslo.utils version is now used in CI.

Related-Bug: #2042886
Change-Id: I855103c5ee17db3c690397e3db78139f3264735c
2023-11-10 00:45:02 +09:00
Takashi Kajinami fa8df69194 Fix unit tests broken by olso.utils
Some of the object unit tests grub Mock object unintentionally, and
that results in failure during initializing an versioned object,
because the Mock object does not present its version correctly.

This fixes that problem.

The sqlalchemy-2x job is made non-voting because this job requires
oslo.utils 6.3.0 which is blocked by this problem.

Closes-Bug: #2043116
Related-Bug: #2042886
Change-Id: I1a622ab9c766d46b7eb4442848e91f25b26f6c61
2023-11-10 00:41:20 +09:00