Commit Graph

480 Commits (master)

Author SHA1 Message Date
Dmitry Tantsur 929907d684 Bye-bye iSCSI deploy, you served us well
The iSCSI deploy was very easy to start with, but it has since become
apparently that it suffers from scalability and maintenance issues.
It was deprecated in the Victoria cycle and can now be removed.

Hide the guide to upgrade to hardware types since it's very outdated.

I had to remove the iBMC diagram since my SVG-fu is not enough to fix it.

Change-Id: I2cd6bf7b27fe0be2c08104b0cc37654b506b2e62
2021-05-04 14:28:25 +02:00
Riccardo Pittau 26d08bdda6 Remove qemu-img rootwrap filter
It should be managed by ironic-lib.

Change-Id: I1b17982fdab5611086f8bb7d944db6f51bb032a0
2020-08-18 16:12:57 +02:00
Thomas Bechtold bfb41571b2 Drop rootwrap.d/ironic-lib.filters file
The file is included in the ironic-lib module and there is no
difference (beside some comments) in the files.

For packagers, this solves the problem that ironic-lib and ironic are
currently not installable together given that both packages contain
the same file.

Story: 2006604
Task: 36772
Change-Id: I2d800d4c2616ccd9d9f12a2fe59e259def15dc6b
2020-03-16 23:05:36 +01:00
John Garbutt d336978834 Remove sample policy and config files
Now we have docs, lets point people there rather than attempting to
maintain a copy in tree.

Also update the devstack plugin to know nothing about policy.json, as it
never allowed for customizing the location or the contents anyhow, and
to build ironic.conf from scratch rather than from the sample.

Change-Id: I10a4987204eb335f1fed29d4b1d7f3e075aa1792
2018-02-02 11:21:29 +00:00
Dmitry Tantsur 02378fdcde Deprecate classic drivers
Also address small issues in the release note for the migration
to hardware types.

Change-Id: I32998c5508e01882714a76751482a916d066f938
Partial-Bug: #1690185
2018-01-31 13:26:53 +01:00
Zuul 180234b445 Merge "Update description for config params of 'rescue' interface" 2018-01-28 06:07:14 +00:00
Zuul 0a5de20c2a Merge "Remove python-oneviewclient from oneview hardware type." 2018-01-27 10:43:55 +00:00
Shivanand Tendulker b9b4a55a41 Update description for config params of 'rescue' interface
As ``rescue`` API implementation has merged, we can let users use
configuration parameters related to this feature. This patch fixes
the help messages for the same.

Change-Id: Idab95302011c3bb3f1db560a6a3f9481371e7671
Partial-bug: #1526449
2018-01-27 09:20:04 +00:00
Shivanand Tendulker 4624c572e2 Agent rescue implementation
This implements agent based rescue interface.

Partial-Bug: #1526449

Co-Authored-By: Mario Villaplana <>
Co-Authored-By: Aparna <>
Co-Authored-By: Shivanand Tendulker <>

Change-Id: I9b4c1278dc5fab7888fbfe586c15e31ed3958978
2018-01-25 13:26:33 -05:00
Hugo Nicodemos f8bf0ad51b Remove python-oneviewclient from oneview hardware type.
This patch removes the ``python-oneviewclient`` library from
``oneview`` hardware type since it was migrated to ``hponeview``
and ``python-ilorest-library``.

Change-Id: I3393189abdff6a0e56f54375877cc310d72ff5b1
Closes-Bug: #1693788
2018-01-25 01:30:27 +00:00
John Garbutt 864331a94b API: Node Traits API
Adds basic CRUD on traits, including set and delete of individual

Bumps the API microversion to 1.37.

NOTE: This patch does not implement the advanced filtering outlined in
the OpenStack API working group's tags guidelines[1]. That will be
implemented in a separate microversion as a follow up patch.


Change-Id: I313fa01fbf20bf0ff19f102ea63b02e72ac2b856
Partial-Bug: #1722194
Co-Authored-By: Mark Goddard <>
2018-01-25 00:11:44 +00:00
Zuul 2c630d9337 Merge "Add rescuewait timeout periodic task" 2018-01-23 16:25:40 +00:00
Zuul 6ee297f7a5 Merge "Add rescue related methods to network interface" 2018-01-23 16:00:50 +00:00
Zuul 83e3afbdee Merge "Add XClarity Driver" 2018-01-22 23:30:28 +00:00
Jay Faulkner a9bc2e6ddf Add rescuewait timeout periodic task
Ensure nodes don't get stuck in rescuewait forever when
a rescue ramdisk fails to boot and start heartbeating.

Change-Id: I15a92c0f619505e25768dc2fbc1b2a796f0b38fa
Related-bug: #1526449
Co-Authored-By: Jay Faulkner <>
Co-Authored-By: Mario Villaplana <>
Co-Authored-By: Jesse J. Cook <>
Co-Authored-By: Aparna <>
Co-Authored-By: Shivanand Tendulker <>
2018-01-22 11:38:36 -05:00
Shivanand Tendulker fbee0981ad Add rescue related methods to network interface
Adds methods `add_rescuing_network` and `remove_rescuing_network`
to add/remove rescuing network to `network` interface.
These methods are not added to `flat` network interface.
The 'flat' network uses same network for tenant and provisioning.
It makes sense to use the same for rescuing as well; as opposed
to a separate network like we have for cleaning.

Change-Id: I8f4123bfe7d293e8ff6f3bfc2f25445a39c94c73
Related-bug: #1526449
Co-Authored-By: Jay Faulkner <>
Co-Authored-By: Mario Villaplana <>
Co-Authored-By: Jesse J. Cook <>
Co-Authored-By: Aparna <>
Co-Authored-By: Shivanand Tendulker <>
2018-01-22 11:37:32 -05:00
Rushil Chugh 346a9a3bfc Add XClarity Driver
This patch proposes to add new interfaces for management and power
for the Lenovo XClarity Driver.

Change-Id: Ic2743f9a4959a6165a7ec40f4772afb231205f36
Closes-Bug: #1702508
2018-01-22 08:39:09 -05:00
Ruby Loo fb47f179a9 Add release 10.0 to release mappings
This adds a '10.0' entry to the release mappings -- used for
rolling upgrades.

This is part of the process for preparing for the 10.0 release

Change-Id: I157d77a231022d9c67d076163fb4aff91e830421
2018-01-11 10:07:04 -05:00
Zuul b5563b4384 Merge "Adds rescue_interface to base driver class" 2018-01-09 06:11:20 +00:00
Shivanand Tendulker 433b1fd197 Adds rescue_interface to base driver class
This commit adds `rescue` interface to `BaseDriver` and implements
it for `fake-hardware` hardware type. It adds configuration
parameters '[DEFAULT]/enabled_rescue_interfaces' and
'[DEFAULT]/default_rescue_interface'. The default value of
configuration parameter '[DEFAULT]/enabled_rescue_interfaces' is

It adds new rescue states and a new 'rescue' field to the Node
object. It adds objects.node.Node._convert_to_version().
The method handles converting the new rescue_interface field
between different versions of the Node.

Partial-bug: #1526449
Co-Authored-By: Jay Faulkner <>
Co-Authored-By: Josh Gachnang <>
Co-Authored-By: Jesse J. Cook <>
Co-Authored-By: Mario Villaplana <>
Co-Authored-By: Aparna <>
Co-Authored-By: Shivanand Tendulker <>

Change-Id: I1534247bf207a20a7a58534988192aef392eaff2
2017-12-21 03:01:48 -05:00
Pavlo Shchelokovskyy ce7119eaf3 [ansible] add defaults to config
In a homogeneous hardware deployment that uses the same ramdisk for all
nodes, and possibly the same playbooks for actions with ansible deploy
interface, it is benefitial to make defaults of various `ansible_`
driver_info fields to be configurable via ironic configuration file
to simplify node enrollment.

This patch also deprecates `ansible_deploy_username` and
`ansible_deploy_key_file` options in node's driver_info in favor of
`ansible_username` and `ansible_key_file` respectively.

Change-Id: Ib198c07c1d414c0d78950e5d98a5176e12a7df13
Closes-Bug: #1736409
2017-12-20 10:06:11 +00:00
Zuul 2924c3efb6 Merge "Finalize migration to keystoneauth adapters" 2017-12-20 02:21:54 +00:00
Pavlo Shchelokovskyy ba53acb279 Finalize migration to keystoneauth adapters
removes code that allowed some service sections to not have and use
keystoneauth adapter options.

Also deprecates `[keystone]region_name` option in favor of per-client
option of the same name.

Change-Id: Ifd58947b016bfa93b516dd47a170ba8f5abf277e
Closes-Bug: #1699547
2017-12-19 12:17:35 +02:00
Zuul 547159c893 Merge "Use adapters for neutronclient" 2017-12-18 05:51:38 +00:00
Pavlo Shchelokovskyy 4d43262955 Use adapters for neutronclient
deprecates the following options in [neutron] section:
- url
- url_timeout
- auth_strategy

Changes some internal networking-related functions/methods
to accept a request context as optional keyword argument (defaults to
This allows to pass a global request id to neutron client and
in future will simplify creating a user auth plugin from request
For backward compatibility, when calling those functions/methods
without a request context, a dummy request context will be generated

Change-Id: Ib327c7a141cfbca63b870027ad8e901c0f48bb2d
Partial-Bug: #1699547
2017-12-14 13:36:03 +02:00
Dmitry Tantsur 83dd6a1c0e Auto-detect the defaults for [glance]swift_{account,temp_url_key,endpoint_url}
In many cases, including devstack and TripleO, the swift account to use
is based on the project_id of the 'service' project, so it makes sense
to use it as a default.

Similarly, the temporary URL key can be fetches from Swift, using HEAD
on the account used to access it.

In both cases it is assumed that the same project is used by Ironic
and Glance to access Swift. Explicit values have to be provided

Finally, the endpoint URL can be fetched from the service catalog. Care
is taken to strip the /v1/AUTH_<tenant ID> suffix.

Closes-Bug: #1737714
Change-Id: I701899928f0f780939f17aabc59eb90593ba95f0
2017-12-12 11:48:06 +01:00
Zuul 39a63602c7 Merge "Pin API version during rolling upgrade" 2017-12-07 07:13:53 +00:00
Zuul 6e920c1052 Merge "Fix swiftclient creation" 2017-12-06 22:51:13 +00:00
Pavlo Shchelokovskyy 9ee28252a4 Fix swiftclient creation
in the change I52f1386df45ebe0a43b11fe1583e012dfa3af532
we lost most of swiftclient options in a belief that those are handled
by the keystoneauth session passed to the swiftclient.

In fact though, swiftclient only uses this session to get itself an
endpoint and a token, but it has no SessionClient, and does not use that
passed in session to make further requests to swift itself.

This patch restores all the logic that we had to decompose the session
object loaded from config to options that are passed to swiftclient

Change-Id: I08f382aa9d2ad22f7dbd65f7b54a8dd0a765ba44
Partial-Bug: #1699547
Closes-Bug: #1736158
2017-12-06 14:14:29 +00:00
Ruby Loo feac8cfb78 Pin API version during rolling upgrade
During a rolling upgrade, when the new services are pinned to the
old release, the API version will also be pinned to the old release.
This will prevent users from accessing new features that may not quite

The .sample was updated to reflect the change to the help string for
the [DEFAULT]/pin_release_version configuration option. The update also
pulled in changes for other options, from other (non-ironic) libraries.

Change-Id: I38a0f106b589945fb62071f3dfe5bff43c6fee93
Partial-Bug: #1708549
2017-12-04 10:17:30 -05:00
Zuul 65a969118a Merge "Add additional capabilities discovery for iRMC driver" 2017-11-30 20:00:30 +00:00
Zuul 259a2057ef Merge "ironic.conf.sample includes default_resource_class" 2017-11-27 19:32:48 +00:00
Zuul 52f20d1565 Merge "Add ansible deploy interface" 2017-11-27 18:14:15 +00:00
Ruby Loo b5f3dfc288 ironic.conf.sample includes default_resource_class
This updates ironic.conf.sample to include the new configuration
option default_resource_class. This is a followup to

Change-Id: I7615167c331f7db16b27575affb5c4ea66228a5f
Related-Bug: #1732190
2017-11-27 09:19:35 -05:00
Nguyen Hung Phuong 7adbf11bb8 Add additional capabilities discovery for iRMC driver
This update enhances iRMC out-of-band hardware inspection for
FUJITSU PRIMERGY bare metal nodes having iRMC S4 and beyond.

The capabilities are server_model, rom_firmware_version,
pci_gpu_devices, trusted_boot and irmc_firmware_version.

Co-authored-By: Nguyen Van Trung <>

Change-Id: I1958e18a5b9d933e2aa405b200bac7717f146611
Closes-Bug: #1637422
2017-11-21 17:49:42 +07:00
Pavlo Shchelokovskyy 303ac3f835 Use adapters for inspectorclient
Inspector-client is a bit lacking behind other clients, as it does not
have Adapter-based SessionClient and thus does not support all
adapter-related options.
That's why we construct a session and an adapter from config section,
use adapter to resolve inspector API from service catalog
(or return the fixed endpoint_override one)
and then pass the session and inspector API endpoint to client.

This patch also deprecates `[inspector]service_url` in favor of

As a side-effect, addressig inspector service now supports both regions
and interfaces to specify entry in service catalog.

Also, inspectorclient calls are now being made with the user token
(wrapped with a service token) when there is a token in the task's
request context.

Change-Id: I21836e712fa9764468ac2654525554b5b4f03741
Partial-Bug: #1699547
2017-11-21 09:33:08 +02:00
Pavlo Shchelokovskyy 3e84bdb6db Use adapters for cinderclient
deprecates the `[cinder]url` option in favor of

Change-Id: Idd02e8cf0892965a3138479e49ec40cfeda7c96d
Partial-Bug: #1699547
2017-11-21 09:32:21 +02:00
Zuul b9ebc7f121 Merge "Rework keystone auth for glance" 2017-11-20 17:38:10 +00:00
Pavlo Shchelokovskyy 63e0ff2f6c Rework keystone auth for glance
this patch changes the way glance client is instantiated, using
keystoneauth sessions and adapters.

In order to support glance API endpoint discovery from keystone catalog
and more unified way of client loading,
many options in `[glance]` config sections are deprecated,
mostly those that specified a (set of) glance API endpoint(s)
or parts of glance API address.
Instead, a single option `[glance]endpoint_override` must be used when
required to access a specific (possibly load-balanced)
glance API endpoint without discovering it from keystone catalog.

Another set of deprecated options are those that are duplicating
keystoneauth session options in [glance] section.

Also, intrinsic support for parsing the glance API URL from image ref
set to the full glance REST path to the image is removed as it was not
working any way since an 'http(s)://' image ref is not treated
as a glance image.

Change-Id: I6a93b71ac097e951dfc93fd1ee4d7ef483514f2c
Partial-Bug: #1699547
Closes-Bug: #1699542
2017-11-17 11:40:14 -05:00
Ruby Loo 36580fb496 Add 9.2 to release mappings
As part of the process for doing an ironic release, we need to
add the new release to the release mappings as documented in
This is needed for rolling upgrades to work.

This adds ironic 9.2 to the release mappings.

Change-Id: Id1ace223c91c2e63529c16450f7c0a92eaca521b
2017-11-15 16:00:38 -05:00
Pavlo Shchelokovskyy 9b1a7ceb4b Add ansible deploy interface
this patch pulls the ansible deploy interface code
and related ansible playbooks and auxiliary files
from ironic-staging-drivers project into main ironic tree.

As discussed in the spec, the use of ramdisk callbacks
(lookup and hearbeats) is now mandatory with this deploy interface.
Playbooks and modules were updated to require Ansible>=2.4,
and custom Ansible module for executing 'parted' was replaced
with usage of built-in Ansible module.

The custom Ansible callback plugin now uses journald logger
by default to adapt to the default DevStack setup.

Documentation and devstack plugin changes enabling automated
testing of this interface will be proposed in followup patches.

Change-Id: I43f54688287953ccb1c2836437aea76236e6560b
Related-Bug: #1526308
2017-11-09 10:30:56 +00:00
Pavlo Shchelokovskyy 44b78219e8 Remove some deprecated glance options
glance_host, glance_port and glance_protocol options in [glance]
config section were deprecated during Pike and can be removed already.

Change-Id: I93739a17cfaf1cee5fa23f3fc24325d63f68aa74
2017-11-07 09:59:48 +00:00
Hironori Shiina b709f5e909 Remove unnesessary description for config parameters in cinder group
Now that the BFV implementation with iPXE was completed, the
parameters in [cinder] group can be exposed. This patch fixes the help

Change-Id: I9f20d478334901140f7c1639d8f0bb0612ae5de0
Related-Bug: #1559691
2017-10-30 19:30:23 +09:00
Hironori Shiina 5c72286338 Update ironic.sample.conf
Updates ironic.sample.conf since some help messages were updated in a
few oslo libraries.

Change-Id: I535cbd5a1b1722cb6fc9bba02327fd7fa59a19c0
2017-10-30 19:23:21 +09:00
Zuul 6d14576744 Merge "Disallow rolling upgrade from Ocata to Queens" 2017-10-18 16:14:22 +00:00
Ruby Loo 7f64a501c3 Disallow rolling upgrade from Ocata to Queens
Now that we've released Pike and master is open for Queens
development, we need to remove the release mapping information
for Ocata, to prevent unsupported rolling upgrades from
Ocata to Queens. We only support rolling upgrades from Pike
to Queens (master).

Change-Id: I440b9a4c8ef6024a47b66b0de4fd841b7f15df2e
2017-10-10 15:37:07 -04:00
Lance Bragstad 297ef395e4 Use DocumentedRuleDefault instead of RuleDefault
The policy-and-docs-in-code Queens goal outlines the work
required for projects to move policy into code and document the
operations and defaults.

This commit replaces occurrences of RuleDefault
with DocumentedRuleDefault where appropriate,
which requires additional attributes when used that supply more
documentation in rendered policy files.
Using DocumentedRuleDefault produces more descriptive generated policy
descriptons in 'configuration' section of ironic docs.

Change-Id: Idc35a5fbe2583e5fd712108a48eb9cec7cbecb76
Closes-Bug: #1716772
2017-09-25 18:29:08 +03:00
Pavlo Shchelokovskyy 308e414a57 Introduce keystoneauth adapters for clients
Currently ironic explicitly or implicitly sets the API urls
for most services in the config.
This is quite fragile and we should move to discovery from
the keystone catalog eventually.

To support this, this patch registers `keystoneauth1.adapter.Adapter`
options to all config sections for service clients auth.
Among others it exports `interfaces` option that we set to
['internal', 'public'] by default.
Other exported options are `service_type`, `service_name`, `region_name`
and `endpoint_override`.
The latter will eventually be used by all clients to specify a specific
endpoint to use (for example in noauth mode).

Effectively this patch starts to move all clients code to load client
configuration from config for all of auth, session and adapter.

The first to move is [service_catalog] section, with [conductor]api_url
option being deprecated in favor of [service_catalog]endpoint_override.
A sane default of 'service_type' = 'baremetal' is set for this config
section as well.

More patches moving other clients to consume these new options and
deprecate some other options will follow.

Change-Id: I1283ef3b4d736ac089df0cc74a5850a93b24b6ab
Partial-Bug: #1699547
Related-Bug: #1699542
2017-08-22 06:07:19 +00:00
Jenkins 880d1378cc Merge "Add 9.1 to release_mappings" 2017-08-21 11:59:21 +00:00
Félix Bouliane 4acc0ed4ce Make SNMP UDP transport settings configurable
SNMP timeout and retries are now configurable through ironic.conf. This
allows to have custom configurations when certain PDUs are slower than

The config defaults are the same defaults that cmdgen.UdpTransportTarget
uses (1.0 second timeout and 5 retries). The config is now reflecting
these defaults.

Closes-Bug: #1640932
Change-Id: I2490902ad2e39e8e4dc34484799a0dae96bc57f8
2017-08-18 14:42:21 +00:00