- python-subunit is not used directly anywhere
and it is dependency of both testrepository and os-testr
(probably was used by some tox wrapper script before)
- python-ironicclient is not used anywhere
(probably should've been used by functional tests,
but we still have none of those).
Change-Id: I42aeb75dab18d90d60792f070599532fd3d9af10
Update test-requirements.txt to use latest versions of:
* flake8-import-order
* hacking
Enable the following off-by-default checks:
* [H204] Use assert(Not)Equal to check for equality.
* [H205] Use assert(Greater|Less)(Equal) for comparison.
Fix code that failed H204 and H205. In this case the fix was to add:
# noqa
As we want to ensure that these particular tests are calling the
desired comparison operators.
Change-Id: If9cba62c832e301ac81320f9142e91319f0e40a9
Since pbr already landed and the old version of hacking seems not
work very well with pbr>=2, we should update it to match global
requirement.
Partial-Bug: #1668848
Change-Id: I635dbf199bad59c72401a4de1de5200132746f6f
Use the flake8 plugin flake8-import-order to check import ordering. It
can do it automatically and don't need reviewers to check it.
Change-Id: I821fd7467f6c5cc1487149297f26e4ad539cf25d
Use hacking 0.12.0
Use the new checks that are available:
[H106] Don’t put vim configuration in source files.
[H203] Use assertIs(Not)None to check for None.
[H904] Delay string interpolations at logging calls.
Fix code so tests pass.
Change-Id: I902e999687b066800e18fafd091571bf718b15f4
Depends-On: I2aa44b62f900d4dfd67701b01eadd0523fbfaf07
This installs the basic directories and content pointing to the current
Ironic Installation Guide. Simply having this in our repo will not lead
to it being published, this is only the first step. Having these items
in our repository is a good first step to building out our install
guide.
Change-Id: I6a0e69bd3b6f5074ae61505f82f27bcf9df84bab
Partial-bug: #1612278
Update the hacking test-requirement to match openstack/requirements
global-requirements.txt
Remove author lines from some files to fix error:
[H105] Don't use author tags. As we use version control instead
The hacking requirement is not updated by the proposal bot.
Change-Id: I8a35a7ebd811c477c893c7b5e854c46acc075af0
os-api-ref is released on pypi now, so we can move to using it instead
of our in tree version.
Change-Id: If353f4a2e553fa3da3b2a4c920e233f51365b77c
Depends-On: I0e615d36a2e5a8fa0d83f20bdcc2c33ad868ebd5
This patch is enabling the doc8 style checker for the *.rst files in
Ironic.
Since this patch is just the first stab at enabling this new check two
errors are currently being ignored by doc8 because of the number of
occurrences in our docs:
* D000 - Duplicated target names. We do have many links with generic
names scattered around the docs (e.g "see", "link")
* D001 - Line's too long
These errors will be fixed in a following patch.
Change-Id: I32fb5a3104b9773c55a80a84dd81e49c567c76ac
In order to save gate resources we could just run bashate as part of the
the pep8 command.
The tox bashate command is removed and bashate is added as a dependency
in the test-requirements.txt file.
Change-Id: I75df4103c0154c5424b8781c1db3480336a5e1d2