86 lines
2.9 KiB
Plaintext
86 lines
2.9 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b7daa9ec_105e8344",
|
|
"filename": "ironic/common/cinder.py",
|
|
"patchSetId": 11
|
|
},
|
|
"lineNbr": 40,
|
|
"author": {
|
|
"id": 11655
|
|
},
|
|
"writtenOn": "2024-04-19T04:33:09Z",
|
|
"side": 1,
|
|
"message": "Yeah, it can\u0027t be the auth, into the session alone, you have to create a combined payload. See my next comment.",
|
|
"range": {
|
|
"startLine": 40,
|
|
"startChar": 51,
|
|
"endLine": 40,
|
|
"endChar": 69
|
|
},
|
|
"revId": "2f5772d70f20101787a6edb758c5baa6a8e3fc94",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "023ed94b_3a64f142",
|
|
"filename": "ironic/common/cinder.py",
|
|
"patchSetId": 11
|
|
},
|
|
"lineNbr": 40,
|
|
"author": {
|
|
"id": 4571
|
|
},
|
|
"writtenOn": "2024-04-23T22:32:36Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "b7daa9ec_105e8344",
|
|
"range": {
|
|
"startLine": 40,
|
|
"startChar": 51,
|
|
"endLine": 40,
|
|
"endChar": 69
|
|
},
|
|
"revId": "2f5772d70f20101787a6edb758c5baa6a8e3fc94",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "07d7cccd_52343723",
|
|
"filename": "ironic/common/cinder.py",
|
|
"patchSetId": 11
|
|
},
|
|
"lineNbr": 52,
|
|
"author": {
|
|
"id": 11655
|
|
},
|
|
"writtenOn": "2024-04-19T04:33:09Z",
|
|
"side": 1,
|
|
"message": "so basically the issue here is your going to need to spawn a connection with more than just the client config. You\u0027ll need to basically build up the user auth token context (via context.auth_token) *and* the service_auth which can just be from the parameters in ironic.conf.\n\nTo do so you would create a new auth dictionary using the service_token.ServiceTokenAuthWrapper(user_auth, service_auth)\n\nhttps://github.com/openstack/openstacksdk/blob/master/openstack/connection.py#L174-L212\n\nThe big difference there is we chose not to create a new service_user configuration object which nova decided to do, since realistically we also had the original auth data and the service *also* represented our credentials.",
|
|
"revId": "2f5772d70f20101787a6edb758c5baa6a8e3fc94",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "677ecc42_2c6936e5",
|
|
"filename": "ironic/common/cinder.py",
|
|
"patchSetId": 11
|
|
},
|
|
"lineNbr": 52,
|
|
"author": {
|
|
"id": 4571
|
|
},
|
|
"writtenOn": "2024-04-23T22:32:36Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "07d7cccd_52343723",
|
|
"revId": "2f5772d70f20101787a6edb758c5baa6a8e3fc94",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |