485 lines
22 KiB
Python
485 lines
22 KiB
Python
#
|
|
# Copyright 2014 OpenStack Foundation
|
|
# All Rights Reserved
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import mock
|
|
from neutronclient.common import exceptions as neutron_client_exc
|
|
from neutronclient.v2_0 import client
|
|
from oslo_utils import uuidutils
|
|
|
|
from ironic.common import dhcp_factory
|
|
from ironic.common import exception
|
|
from ironic.common import pxe_utils
|
|
from ironic.conductor import task_manager
|
|
from ironic.dhcp import neutron
|
|
from ironic.tests.unit.conductor import mgr_utils
|
|
from ironic.tests.unit.db import base as db_base
|
|
from ironic.tests.unit.objects import utils as object_utils
|
|
|
|
|
|
class TestNeutron(db_base.DbTestCase):
|
|
|
|
def setUp(self):
|
|
super(TestNeutron, self).setUp()
|
|
mgr_utils.mock_the_extension_manager(driver='fake')
|
|
self.config(
|
|
cleaning_network_uuid='00000000-0000-0000-0000-000000000000',
|
|
group='neutron')
|
|
self.config(enabled_drivers=['fake'])
|
|
self.config(dhcp_provider='neutron',
|
|
group='dhcp')
|
|
self.config(url='test-url',
|
|
url_timeout=30,
|
|
retries=2,
|
|
group='neutron')
|
|
self.config(insecure=False,
|
|
certfile='test-file',
|
|
admin_user='test-admin-user',
|
|
admin_tenant_name='test-admin-tenant',
|
|
admin_password='test-admin-password',
|
|
auth_uri='test-auth-uri',
|
|
group='keystone_authtoken')
|
|
self.node = object_utils.create_test_node(self.context)
|
|
self.ports = [
|
|
object_utils.create_test_port(
|
|
self.context, node_id=self.node.id, id=2,
|
|
uuid='1be26c0b-03f2-4d2e-ae87-c02d7f33c782',
|
|
address='52:54:00:cf:2d:32')]
|
|
# Very simple neutron port representation
|
|
self.neutron_port = {'id': '132f871f-eaec-4fed-9475-0d54465e0f00',
|
|
'mac_address': '52:54:00:cf:2d:32'}
|
|
|
|
dhcp_factory.DHCPFactory._dhcp_provider = None
|
|
|
|
def test__build_client_invalid_auth_strategy(self):
|
|
self.config(auth_strategy='wrong_config', group='neutron')
|
|
token = 'test-token-123'
|
|
self.assertRaises(exception.ConfigInvalid,
|
|
neutron._build_client,
|
|
token=token)
|
|
|
|
@mock.patch.object(client.Client, "__init__")
|
|
def test__build_client_with_token(self, mock_client_init):
|
|
token = 'test-token-123'
|
|
expected = {'timeout': 30,
|
|
'retries': 2,
|
|
'insecure': False,
|
|
'ca_cert': 'test-file',
|
|
'token': token,
|
|
'endpoint_url': 'test-url',
|
|
'auth_strategy': None}
|
|
|
|
mock_client_init.return_value = None
|
|
neutron._build_client(token=token)
|
|
mock_client_init.assert_called_once_with(**expected)
|
|
|
|
@mock.patch.object(client.Client, "__init__")
|
|
def test__build_client_without_token(self, mock_client_init):
|
|
expected = {'timeout': 30,
|
|
'retries': 2,
|
|
'insecure': False,
|
|
'ca_cert': 'test-file',
|
|
'endpoint_url': 'test-url',
|
|
'username': 'test-admin-user',
|
|
'tenant_name': 'test-admin-tenant',
|
|
'password': 'test-admin-password',
|
|
'auth_url': 'test-auth-uri'}
|
|
|
|
mock_client_init.return_value = None
|
|
neutron._build_client(token=None)
|
|
mock_client_init.assert_called_once_with(**expected)
|
|
|
|
@mock.patch.object(client.Client, "__init__")
|
|
def test__build_client_with_region(self, mock_client_init):
|
|
expected = {'timeout': 30,
|
|
'retries': 2,
|
|
'insecure': False,
|
|
'ca_cert': 'test-file',
|
|
'endpoint_url': 'test-url',
|
|
'username': 'test-admin-user',
|
|
'tenant_name': 'test-admin-tenant',
|
|
'password': 'test-admin-password',
|
|
'auth_url': 'test-auth-uri',
|
|
'region_name': 'test-region'}
|
|
|
|
self.config(region_name='test-region',
|
|
group='keystone')
|
|
mock_client_init.return_value = None
|
|
neutron._build_client(token=None)
|
|
mock_client_init.assert_called_once_with(**expected)
|
|
|
|
@mock.patch.object(client.Client, "__init__")
|
|
def test__build_client_noauth(self, mock_client_init):
|
|
self.config(auth_strategy='noauth', group='neutron')
|
|
expected = {'ca_cert': 'test-file',
|
|
'insecure': False,
|
|
'endpoint_url': 'test-url',
|
|
'timeout': 30,
|
|
'retries': 2,
|
|
'auth_strategy': 'noauth'}
|
|
|
|
mock_client_init.return_value = None
|
|
neutron._build_client(token=None)
|
|
mock_client_init.assert_called_once_with(**expected)
|
|
|
|
@mock.patch.object(client.Client, 'update_port')
|
|
@mock.patch.object(client.Client, "__init__")
|
|
def test_update_port_dhcp_opts(self, mock_client_init, mock_update_port):
|
|
opts = [{'opt_name': 'bootfile-name',
|
|
'opt_value': 'pxelinux.0'},
|
|
{'opt_name': 'tftp-server',
|
|
'opt_value': '1.1.1.1'},
|
|
{'opt_name': 'server-ip-address',
|
|
'opt_value': '1.1.1.1'}]
|
|
port_id = 'fake-port-id'
|
|
expected = {'port': {'extra_dhcp_opts': opts}}
|
|
|
|
mock_client_init.return_value = None
|
|
api = dhcp_factory.DHCPFactory()
|
|
api.provider.update_port_dhcp_opts(port_id, opts)
|
|
mock_update_port.assert_called_once_with(port_id, expected)
|
|
|
|
@mock.patch.object(client.Client, 'update_port')
|
|
@mock.patch.object(client.Client, "__init__")
|
|
def test_update_port_dhcp_opts_with_exception(self, mock_client_init,
|
|
mock_update_port):
|
|
opts = [{}]
|
|
port_id = 'fake-port-id'
|
|
mock_client_init.return_value = None
|
|
mock_update_port.side_effect = (
|
|
neutron_client_exc.NeutronClientException())
|
|
|
|
api = dhcp_factory.DHCPFactory()
|
|
self.assertRaises(
|
|
exception.FailedToUpdateDHCPOptOnPort,
|
|
api.provider.update_port_dhcp_opts,
|
|
port_id, opts)
|
|
|
|
@mock.patch.object(client.Client, 'update_port')
|
|
@mock.patch.object(client.Client, '__init__')
|
|
def test_update_port_address(self, mock_client_init, mock_update_port):
|
|
address = 'fe:54:00:77:07:d9'
|
|
port_id = 'fake-port-id'
|
|
expected = {'port': {'mac_address': address}}
|
|
mock_client_init.return_value = None
|
|
|
|
api = dhcp_factory.DHCPFactory()
|
|
api.provider.update_port_address(port_id, address)
|
|
mock_update_port.assert_called_once_with(port_id, expected)
|
|
|
|
@mock.patch.object(client.Client, 'update_port')
|
|
@mock.patch.object(client.Client, '__init__')
|
|
def test_update_port_address_with_exception(self, mock_client_init,
|
|
mock_update_port):
|
|
address = 'fe:54:00:77:07:d9'
|
|
port_id = 'fake-port-id'
|
|
mock_client_init.return_value = None
|
|
|
|
api = dhcp_factory.DHCPFactory()
|
|
mock_update_port.side_effect = (
|
|
neutron_client_exc.NeutronClientException())
|
|
self.assertRaises(exception.FailedToUpdateMacOnPort,
|
|
api.provider.update_port_address,
|
|
port_id, address)
|
|
|
|
@mock.patch('ironic.dhcp.neutron.NeutronDHCPApi.update_port_dhcp_opts')
|
|
@mock.patch('ironic.common.network.get_node_vif_ids')
|
|
def test_update_dhcp(self, mock_gnvi, mock_updo):
|
|
mock_gnvi.return_value = {'port-uuid': 'vif-uuid'}
|
|
with task_manager.acquire(self.context,
|
|
self.node.uuid) as task:
|
|
opts = pxe_utils.dhcp_options_for_instance(task)
|
|
api = dhcp_factory.DHCPFactory()
|
|
api.update_dhcp(task, opts)
|
|
mock_updo.assert_called_once_with('vif-uuid', opts,
|
|
token=self.context.auth_token)
|
|
|
|
@mock.patch('ironic.dhcp.neutron.NeutronDHCPApi.update_port_dhcp_opts')
|
|
@mock.patch('ironic.common.network.get_node_vif_ids')
|
|
def test_update_dhcp_no_vif_data(self, mock_gnvi, mock_updo):
|
|
mock_gnvi.return_value = {}
|
|
with task_manager.acquire(self.context,
|
|
self.node.uuid) as task:
|
|
api = dhcp_factory.DHCPFactory()
|
|
self.assertRaises(exception.FailedToUpdateDHCPOptOnPort,
|
|
api.update_dhcp, task, self.node)
|
|
self.assertFalse(mock_updo.called)
|
|
|
|
@mock.patch('ironic.dhcp.neutron.NeutronDHCPApi.update_port_dhcp_opts')
|
|
@mock.patch('ironic.common.network.get_node_vif_ids')
|
|
def test_update_dhcp_some_failures(self, mock_gnvi, mock_updo):
|
|
# confirm update is called twice, one fails, but no exception raised
|
|
mock_gnvi.return_value = {'p1': 'v1', 'p2': 'v2'}
|
|
exc = exception.FailedToUpdateDHCPOptOnPort('fake exception')
|
|
mock_updo.side_effect = [None, exc]
|
|
with task_manager.acquire(self.context,
|
|
self.node.uuid) as task:
|
|
api = dhcp_factory.DHCPFactory()
|
|
api.update_dhcp(task, self.node)
|
|
mock_gnvi.assert_called_once_with(task)
|
|
self.assertEqual(2, mock_updo.call_count)
|
|
|
|
@mock.patch('ironic.dhcp.neutron.NeutronDHCPApi.update_port_dhcp_opts')
|
|
@mock.patch('ironic.common.network.get_node_vif_ids')
|
|
def test_update_dhcp_fails(self, mock_gnvi, mock_updo):
|
|
# confirm update is called twice, both fail, and exception is raised
|
|
mock_gnvi.return_value = {'p1': 'v1', 'p2': 'v2'}
|
|
exc = exception.FailedToUpdateDHCPOptOnPort('fake exception')
|
|
mock_updo.side_effect = [exc, exc]
|
|
with task_manager.acquire(self.context,
|
|
self.node.uuid) as task:
|
|
api = dhcp_factory.DHCPFactory()
|
|
self.assertRaises(exception.FailedToUpdateDHCPOptOnPort,
|
|
api.update_dhcp,
|
|
task, self.node)
|
|
mock_gnvi.assert_called_once_with(task)
|
|
self.assertEqual(2, mock_updo.call_count)
|
|
|
|
def test__get_fixed_ip_address(self):
|
|
port_id = 'fake-port-id'
|
|
expected = "192.168.1.3"
|
|
api = dhcp_factory.DHCPFactory().provider
|
|
port_data = {
|
|
"id": port_id,
|
|
"network_id": "3cb9bc59-5699-4588-a4b1-b87f96708bc6",
|
|
"admin_state_up": True,
|
|
"status": "ACTIVE",
|
|
"mac_address": "fa:16:3e:4c:2c:30",
|
|
"fixed_ips": [
|
|
{
|
|
"ip_address": "192.168.1.3",
|
|
"subnet_id": "f8a6e8f8-c2ec-497c-9f23-da9616de54ef"
|
|
}
|
|
],
|
|
"device_id": 'bece68a3-2f8b-4e66-9092-244493d6aba7',
|
|
}
|
|
fake_client = mock.Mock()
|
|
fake_client.show_port.return_value = {'port': port_data}
|
|
result = api._get_fixed_ip_address(port_id, fake_client)
|
|
self.assertEqual(expected, result)
|
|
fake_client.show_port.assert_called_once_with(port_id)
|
|
|
|
def test__get_fixed_ip_address_invalid_ip(self):
|
|
port_id = 'fake-port-id'
|
|
api = dhcp_factory.DHCPFactory().provider
|
|
port_data = {
|
|
"id": port_id,
|
|
"network_id": "3cb9bc59-5699-4588-a4b1-b87f96708bc6",
|
|
"admin_state_up": True,
|
|
"status": "ACTIVE",
|
|
"mac_address": "fa:16:3e:4c:2c:30",
|
|
"fixed_ips": [
|
|
{
|
|
"ip_address": "invalid.ip",
|
|
"subnet_id": "f8a6e8f8-c2ec-497c-9f23-da9616de54ef"
|
|
}
|
|
],
|
|
"device_id": 'bece68a3-2f8b-4e66-9092-244493d6aba7',
|
|
}
|
|
fake_client = mock.Mock()
|
|
fake_client.show_port.return_value = {'port': port_data}
|
|
self.assertRaises(exception.InvalidIPv4Address,
|
|
api._get_fixed_ip_address,
|
|
port_id, fake_client)
|
|
fake_client.show_port.assert_called_once_with(port_id)
|
|
|
|
def test__get_fixed_ip_address_with_exception(self):
|
|
port_id = 'fake-port-id'
|
|
api = dhcp_factory.DHCPFactory().provider
|
|
|
|
fake_client = mock.Mock()
|
|
fake_client.show_port.side_effect = (
|
|
neutron_client_exc.NeutronClientException())
|
|
self.assertRaises(exception.FailedToGetIPAddressOnPort,
|
|
api._get_fixed_ip_address, port_id, fake_client)
|
|
fake_client.show_port.assert_called_once_with(port_id)
|
|
|
|
@mock.patch('ironic.dhcp.neutron.NeutronDHCPApi._get_fixed_ip_address')
|
|
@mock.patch('ironic.common.network.get_node_vif_ids')
|
|
def test__get_port_ip_address(self, mock_gnvi, mock_gfia):
|
|
expected = "192.168.1.3"
|
|
port = object_utils.create_test_port(self.context,
|
|
node_id=self.node.id,
|
|
address='aa:bb:cc:dd:ee:ff',
|
|
uuid=uuidutils.generate_uuid(),
|
|
extra={'vif_port_id':
|
|
'test-vif-A'},
|
|
driver='fake')
|
|
mock_gnvi.return_value = {port.uuid: 'vif-uuid'}
|
|
mock_gfia.return_value = expected
|
|
with task_manager.acquire(self.context,
|
|
self.node.uuid) as task:
|
|
api = dhcp_factory.DHCPFactory().provider
|
|
result = api._get_port_ip_address(task, port.uuid,
|
|
mock.sentinel.client)
|
|
mock_gnvi.assert_called_once_with(task)
|
|
self.assertEqual(expected, result)
|
|
mock_gfia.assert_called_once_with('vif-uuid', mock.sentinel.client)
|
|
|
|
@mock.patch('ironic.dhcp.neutron.NeutronDHCPApi._get_fixed_ip_address')
|
|
@mock.patch('ironic.common.network.get_node_vif_ids')
|
|
def test__get_port_ip_address_with_exception(self, mock_gnvi, mock_gfia):
|
|
expected = "192.168.1.3"
|
|
port = object_utils.create_test_port(self.context,
|
|
node_id=self.node.id,
|
|
address='aa:bb:cc:dd:ee:ff',
|
|
uuid=uuidutils.generate_uuid(),
|
|
extra={'vif_port_id':
|
|
'test-vif-A'},
|
|
driver='fake')
|
|
mock_gnvi.return_value = None
|
|
mock_gfia.return_value = expected
|
|
with task_manager.acquire(self.context,
|
|
self.node.uuid) as task:
|
|
api = dhcp_factory.DHCPFactory().provider
|
|
self.assertRaises(exception.FailedToGetIPAddressOnPort,
|
|
api._get_port_ip_address, task, port,
|
|
mock.sentinel.client)
|
|
mock_gnvi.assert_called_once_with(task)
|
|
|
|
@mock.patch('ironic.dhcp.neutron.NeutronDHCPApi._get_port_ip_address')
|
|
def test_get_ip_addresses(self, get_ip_mock):
|
|
ip_address = '10.10.0.1'
|
|
expected = [ip_address]
|
|
|
|
get_ip_mock.return_value = ip_address
|
|
|
|
with task_manager.acquire(self.context, self.node.uuid) as task:
|
|
api = dhcp_factory.DHCPFactory().provider
|
|
result = api.get_ip_addresses(task)
|
|
get_ip_mock.assert_called_once_with(task, self.ports[0].uuid,
|
|
mock.ANY)
|
|
self.assertEqual(expected, result)
|
|
|
|
@mock.patch.object(client.Client, 'create_port')
|
|
def test_create_cleaning_ports(self, create_mock):
|
|
# Ensure we can create cleaning ports for in band cleaning
|
|
create_mock.return_value = {'port': self.neutron_port}
|
|
expected = {self.ports[0].uuid: self.neutron_port['id']}
|
|
api = dhcp_factory.DHCPFactory().provider
|
|
|
|
with task_manager.acquire(self.context, self.node.uuid) as task:
|
|
ports = api.create_cleaning_ports(task)
|
|
self.assertEqual(expected, ports)
|
|
create_mock.assert_called_once_with({'port': {
|
|
'network_id': '00000000-0000-0000-0000-000000000000',
|
|
'admin_state_up': True, 'mac_address': self.ports[0].address}})
|
|
|
|
@mock.patch.object(neutron.NeutronDHCPApi, '_rollback_cleaning_ports')
|
|
@mock.patch.object(client.Client, 'create_port')
|
|
def test_create_cleaning_ports_fail(self, create_mock, rollback_mock):
|
|
# Check that if creating a port fails, the ports are cleaned up
|
|
create_mock.side_effect = neutron_client_exc.ConnectionFailed
|
|
api = dhcp_factory.DHCPFactory().provider
|
|
|
|
with task_manager.acquire(self.context, self.node.uuid) as task:
|
|
self.assertRaises(exception.NodeCleaningFailure,
|
|
api.create_cleaning_ports,
|
|
task)
|
|
create_mock.assert_called_once_with({'port': {
|
|
'network_id': '00000000-0000-0000-0000-000000000000',
|
|
'admin_state_up': True, 'mac_address': self.ports[0].address}})
|
|
rollback_mock.assert_called_once_with(task)
|
|
|
|
@mock.patch.object(neutron.NeutronDHCPApi, '_rollback_cleaning_ports')
|
|
@mock.patch.object(client.Client, 'create_port')
|
|
def test_create_cleaning_ports_fail_delayed(self, create_mock,
|
|
rollback_mock):
|
|
"""Check ports are cleaned up on failure to create them
|
|
|
|
This test checks that the port clean-up occurs
|
|
when the port create call was successful,
|
|
but the port in fact was not created.
|
|
|
|
"""
|
|
# NOTE(pas-ha) this is trying to emulate the complex port object
|
|
# with both methods and dictionary access with methods on elements
|
|
mockport = mock.MagicMock()
|
|
create_mock.return_value = mockport
|
|
# fail only on second 'or' branch to fool lazy eval
|
|
# and actually execute both expressions to assert on both mocks
|
|
mockport.get.return_value = True
|
|
mockitem = mock.Mock()
|
|
mockport.__getitem__.return_value = mockitem
|
|
mockitem.get.return_value = None
|
|
api = dhcp_factory.DHCPFactory().provider
|
|
|
|
with task_manager.acquire(self.context, self.node.uuid) as task:
|
|
self.assertRaises(exception.NodeCleaningFailure,
|
|
api.create_cleaning_ports,
|
|
task)
|
|
create_mock.assert_called_once_with({'port': {
|
|
'network_id': '00000000-0000-0000-0000-000000000000',
|
|
'admin_state_up': True, 'mac_address': self.ports[0].address}})
|
|
rollback_mock.assert_called_once_with(task)
|
|
mockport.get.assert_called_once_with('port')
|
|
mockitem.get.assert_called_once_with('id')
|
|
mockport.__getitem__.assert_called_once_with('port')
|
|
|
|
@mock.patch.object(client.Client, 'create_port')
|
|
def test_create_cleaning_ports_bad_config(self, create_mock):
|
|
# Check an error is raised if the cleaning network is not set
|
|
self.config(cleaning_network_uuid=None, group='neutron')
|
|
api = dhcp_factory.DHCPFactory().provider
|
|
|
|
with task_manager.acquire(self.context, self.node.uuid) as task:
|
|
self.assertRaises(exception.InvalidParameterValue,
|
|
api.create_cleaning_ports, task)
|
|
|
|
@mock.patch.object(client.Client, 'delete_port')
|
|
@mock.patch.object(client.Client, 'list_ports')
|
|
def test_delete_cleaning_ports(self, list_mock, delete_mock):
|
|
# Ensure that we can delete cleaning ports, and that ports with
|
|
# different macs don't get deleted
|
|
other_port = {'id': '132f871f-eaec-4fed-9475-0d54465e0f01',
|
|
'mac_address': 'aa:bb:cc:dd:ee:ff'}
|
|
list_mock.return_value = {'ports': [self.neutron_port, other_port]}
|
|
api = dhcp_factory.DHCPFactory().provider
|
|
|
|
with task_manager.acquire(self.context, self.node.uuid) as task:
|
|
api.delete_cleaning_ports(task)
|
|
list_mock.assert_called_once_with(
|
|
network_id='00000000-0000-0000-0000-000000000000')
|
|
delete_mock.assert_called_once_with(self.neutron_port['id'])
|
|
|
|
@mock.patch.object(client.Client, 'list_ports')
|
|
def test_delete_cleaning_ports_list_fail(self, list_mock):
|
|
# Check that if listing ports fails, the node goes to cleanfail
|
|
list_mock.side_effect = neutron_client_exc.ConnectionFailed
|
|
api = dhcp_factory.DHCPFactory().provider
|
|
|
|
with task_manager.acquire(self.context, self.node.uuid) as task:
|
|
self.assertRaises(exception.NodeCleaningFailure,
|
|
api.delete_cleaning_ports,
|
|
task)
|
|
list_mock.assert_called_once_with(
|
|
network_id='00000000-0000-0000-0000-000000000000')
|
|
|
|
@mock.patch.object(client.Client, 'delete_port')
|
|
@mock.patch.object(client.Client, 'list_ports')
|
|
def test_delete_cleaning_ports_delete_fail(self, list_mock, delete_mock):
|
|
# Check that if deleting ports fails, the node goes to cleanfail
|
|
list_mock.return_value = {'ports': [self.neutron_port]}
|
|
delete_mock.side_effect = neutron_client_exc.ConnectionFailed
|
|
api = dhcp_factory.DHCPFactory().provider
|
|
|
|
with task_manager.acquire(self.context, self.node.uuid) as task:
|
|
self.assertRaises(exception.NodeCleaningFailure,
|
|
api.delete_cleaning_ports,
|
|
task)
|
|
list_mock.assert_called_once_with(
|
|
network_id='00000000-0000-0000-0000-000000000000')
|
|
delete_mock.assert_called_once_with(self.neutron_port['id'])
|