openstack
/
ironic
Code Issues Proposed changes
ironic/ironic/tests/unit/drivers/modules
History
Dmitry Tantsur 0500fe1072 Avoid unnecessary validation in boot interfaces 
Interfaces should only validate values they're going to use. Boot
interfaces do not care about image properties when local boot is used
(which is the default), so they shouldn't validate them. The deploy
interface has to provide validation for images.

This change fixes PXE, iPXE and redfish-virtual-media, although other
boot interfaces may need a similar change. We also need to refactor
handling instance_info in deploy_utils, but that can wait until the
iSCSI deploy removal.

Also refactor unit tests for redfish-virtual-media.

Story: #2008874
Task: #42418
Change-Id: Ida21f21d6435c0d7fa46cb5b1161f034ad8956ee
(cherry picked from commit e6bb99cd8f)
 		2021-05-10 15:45:16 +00:00
..
ansible agent_client: support custom TLS certificates 2020-08-06 15:00:22 +02:00
drac Fix idrac-wsman BIOS factory_reset result finding 2021-04-21 06:20:08 -04:00
ibmc Use unittest mock instead of 3rd party mock in test_raid 2020-07-06 09:29:34 +02:00
ilo Always add 'boot_method' vmedia in redfish/ilo vmedia boot 2021-03-29 10:41:47 -07:00
intel_ipmi Deprecate the iscsi deploy interface 2020-09-22 15:39:36 +02:00
irmc Merge "Lazy-load node details from the DB" 2021-03-05 17:50:31 +00:00
network Remove extra/vif_port_id 2021-03-22 12:04:18 -07:00
redfish Avoid unnecessary validation in boot interfaces 2021-05-10 15:45:16 +00:00
storage Enforce autospec in test_cinder 2020-08-06 18:17:50 +02:00
xclarity Enforce autospec in xclarity tests 2020-08-07 17:47:14 +02:00
__init__.py Move unit tests to correct directory 2015-09-30 17:47:19 -07:00
test_agent.py Remove a pause before cleaning when fast-tracking 2021-04-28 12:23:27 +00:00
test_agent_base.py Replace retrying with tenacity 2021-02-15 17:11:33 +01:00
test_agent_client.py Fix deployment when executing a command fails after the command starts 2021-05-07 18:03:47 +02:00
test_agent_power.py Fix time usage in unit tests for agent power interface 2020-08-12 10:00:14 -07:00
test_boot_mode_utils.py Make boot_mode more consistent with other capabilities 2021-02-02 12:06:17 +01:00
test_console_utils.py Enforce autospec in test_console_utils 2021-03-08 19:16:08 +01:00
test_deploy_utils.py Remove a pause before cleaning when fast-tracking 2021-04-28 12:23:27 +00:00
test_image_cache.py Merge "Guard conductor from consuming all of the ram" 2021-02-12 18:11:57 +00:00
test_image_utils.py Provide an option to not cache bootable iso ramdisks 2021-05-05 21:04:25 +00:00
test_inspect_utils.py Switch to unittest mock 2020-04-30 19:04:17 +02:00
test_inspector.py Use OOB inspection to fetch MACs for IB inspection 2021-02-11 17:03:18 +10:00
test_ipmitool.py Automaticaly set cipher suite 2021-03-29 05:50:25 +02:00
test_ipxe.py Avoid unnecessary validation in boot interfaces 2021-05-10 15:45:16 +00:00
test_iscsi_deploy.py Allow running RAID cleaning steps with in-band cleaning 2021-03-23 16:34:41 -04:00
test_noop.py Switch to unittest mock 2020-04-30 19:04:17 +02:00
test_noop_mgmt.py Switch to unittest mock 2020-04-30 19:04:17 +02:00
test_pxe.py Avoid unnecessary validation in boot interfaces 2021-05-10 15:45:16 +00:00
test_snmp.py Enforce autospec in test_snmp 2020-06-05 18:50:49 +02:00