Hervé Beraud
faca47ae98
Ironic has fully removed its usage of eventlet. This change introduces a new hacking check to ban any new eventlet imports from being added to the codebase. This follows the post-migration guidance from the eventlet removal documentation: https://removal.eventlet.org/guide/post-migration-guidance/#hacking-checks Generated-By: gemini-cli and gemini-2.5-pro Change-Id: I48ac535325f68ba0b2a9f50aec4ce19ac6265e77 Signed-off-by: Hervé Beraud <hberaud@redhat.com>
66 lines
2.2 KiB
Python
66 lines
2.2 KiB
Python
# Copyright 2018 FUJITSU LIMITED
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import re
|
|
|
|
from hacking import core
|
|
|
|
# N323: Found use of _() without explicit import of _!
|
|
|
|
|
|
UNDERSCORE_IMPORT_FILES = []
|
|
|
|
|
|
string_translation = re.compile(r"[^_]*_\(\s*('|\")")
|
|
translated_log = re.compile(
|
|
r"(.)*LOG\.(audit|error|info|warn|warning|critical|exception)"
|
|
r"\(\s*_\(\s*('|\")")
|
|
underscore_import_check = re.compile(r"(.)*import _(.)*")
|
|
# We need this for cases where they have created their own _ function.
|
|
custom_underscore_check = re.compile(r"(.)*_\s*=\s*(.)*")
|
|
|
|
|
|
# I319: eventlet import not allowed
|
|
_eventlet_re = re.compile(r"\b(import|from)\s+eventlet\b")
|
|
|
|
|
|
@core.flake8ext
|
|
def check_explicit_underscore_import(logical_line, filename):
|
|
"""Check for explicit import of the _ function
|
|
|
|
We need to ensure that any files that are using the _() function
|
|
to translate logs are explicitly importing the _ function. We
|
|
can't trust unit test to catch whether the import has been
|
|
added so we need to check for it here.
|
|
|
|
"""
|
|
|
|
# Build a list of the files that have _ imported. No further
|
|
# checking needed once it is found.
|
|
if filename in UNDERSCORE_IMPORT_FILES:
|
|
pass
|
|
elif (underscore_import_check.match(logical_line)
|
|
or custom_underscore_check.match(logical_line)):
|
|
UNDERSCORE_IMPORT_FILES.append(filename)
|
|
elif (translated_log.match(logical_line)
|
|
or string_translation.match(logical_line)):
|
|
yield (0, "N323: Found use of _() without explicit import of _!")
|
|
|
|
|
|
@core.flake8ext
|
|
def no_eventlet_imports(logical_line):
|
|
"""Check for eventlet imports."""
|
|
if _eventlet_re.search(logical_line):
|
|
yield 0, "I319: eventlet import not allowed"
|