ironic/add-agent-api-error-77ec6c272390c488.yaml at 5dff46a700a78c95cf9c5ca274920c7fca68ec0c - ironic - OpenDev: Free Software Needs Free Tools

openstack/ironic

Jim Rollenhagen 22ea3fb3b7 Fail deploy if agent returns >= 400

Currently the status code returned by IPA's POST /v1/commands API is
completely ignored by Ironic. This causes deploys to get stuck, as
future heartbeats will see that the command has not yet been accepted
and will continue to wait.

If IPA returns an error code to Ironic's agent client, we should bubble
that exception up, causing a deploy failure higher in the chain.

This adds an AgentAPIError exception class, and raises it when the agent
returns a 400 status code or higher when issuing a command.

Co-Authored-By: Jay Faulkner <jay@jvf.cc>

Related-bug: 1542506
Change-Id: I07fb8115d254e877d8781207eaec203e3fdf8ad6

2017-11-09 22:10:58 -08:00

5 lines

168 B

YAML

Raw Blame History

 ---
 fixes:
   - Fixes propagation of HTTP errors from **ironic-python-agent** commands. Now
     an operation is aborted on receiving HTTP error status from the ramdisk.