ironic/conductor_early_import-fd29fa8b89089977.yaml at 91b0f738347cdbcb87c320e80023657b1824b6a5 - ironic - OpenDev: Free Software Needs Free Tools

openstack/ironic

Ruby Loo ec202c444b Separate WSGIService from RPCService

This patch fixes a problem which prevented Ironic from honoring the
interval values configuration for the periodic tasks. Since the interval
values are passed to a decorator, the configuration options should be
evaluated prior to importing the module which contains the periodic tasks.

In our case this was not happening due to the chain of imports going
from ironic.cmd.conductor -> ironic.common.service -> ironic.api.app
-> ... -> ironic.conductor.manager. This caused the @periodic
decorators to be evaluated before the configuration options were loaded.

This patch breaks that chain of imports by separating the WSGIService
and RPCService classes into two separate files. The conductor uses the
RPCService, and since it is now in a separate file from WSGIService, it
no longer pulls in ironic.api.app, ..., and ironic.conductor.manager.
(ironic.api.app was being imported because WSGIService needed it.)

Change-Id: Ie318e7bb2d2c2d971a796ab8960be33fccbd88f3
Closes-Bug: #1562258
Co-Authored-By: Lucas Alvares Gomes <lucasagomes@gmail.com>

2016-09-15 11:14:20 -04:00

6 lines

210 B

YAML

Raw Blame History

 ---
 fixes:
   - Fixes a bug which prevented the ironic-conductor service from
     using the interval values from the configuration options, for
     the periodic tasks. Instead, the default values had been used.