ironic/releasenotes/notes/firmware-fail-c6f6c70220373033.yaml
Dmitry Tantsur 23745d97fe
Fix two severe errors in the firmware caching code
First, it tries to create components even if the current version is not
known and fails with a database constraint error (because the initial
version cannot be NULL). Can be reproduced with sushy-tools before
37f118237a

Second, unexpected exceptions are not handled in the caching code, so
any of them will cause the node to get stuck in cleaning forever.

On top of that, the caching code is missing a metrics decorator.

This change does not update any unit tests because none currently exist.

Change-Id: Iaa242ca6aa6138fcdaaf63b763708e2f1e559cb0
2023-12-08 18:11:03 +01:00

9 lines
282 B
YAML

---
fixes:
- |
Nodes no longer get stuck in cleaning when the firmware components caching
code raises an unexpected exception.
- |
Prevents a database constraints error on caching firmware components
when a supported component does not have the current version.