109 lines
3.3 KiB
Plaintext
109 lines
3.3 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "d33fa175_da64fe4d",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 18
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 11655
|
|
},
|
|
"writtenOn": "2024-04-24T14:17:24Z",
|
|
"side": 1,
|
|
"message": "Overall LGTM with the exception of this likely needs a release note. We\u0027re changing the client library, we\u0027re dropping a requirement. Might just be good to communicate as operational context to users.",
|
|
"revId": "136be235fb0eb80e316d62c573ea2ce269e35877",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "587da3cd_98f3882d",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 18
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 4571
|
|
},
|
|
"writtenOn": "2024-04-29T01:10:27Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "d33fa175_da64fe4d",
|
|
"revId": "136be235fb0eb80e316d62c573ea2ce269e35877",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "5c6e959f_f183307c",
|
|
"filename": "ironic/common/cinder.py",
|
|
"patchSetId": 18
|
|
},
|
|
"lineNbr": 98,
|
|
"author": {
|
|
"id": 10239
|
|
},
|
|
"writtenOn": "2024-04-26T12:58:39Z",
|
|
"side": 1,
|
|
"message": "I wonder if the change to use version 3 explicitly is also release note worthy. Or did we use v3 before as well?",
|
|
"revId": "136be235fb0eb80e316d62c573ea2ce269e35877",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "16c724ea_1138d1f4",
|
|
"filename": "ironic/common/cinder.py",
|
|
"patchSetId": 18
|
|
},
|
|
"lineNbr": 98,
|
|
"author": {
|
|
"id": 4571
|
|
},
|
|
"writtenOn": "2024-04-29T01:10:08Z",
|
|
"side": 1,
|
|
"message": "We already use v3, which is achieved by setting service_type\u003dvolumev3:\n\nhttps://opendev.org/openstack/ironic/src/branch/master/ironic/conf/cinder.py#L40\n\nIts just that the sdk also requires explicit version to be requested otherwise it assumes v2",
|
|
"parentUuid": "5c6e959f_f183307c",
|
|
"revId": "136be235fb0eb80e316d62c573ea2ce269e35877",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "611226de_7e0e4aaa",
|
|
"filename": "requirements.txt",
|
|
"patchSetId": 18
|
|
},
|
|
"lineNbr": 47,
|
|
"author": {
|
|
"id": 10239
|
|
},
|
|
"writtenOn": "2024-04-26T12:58:39Z",
|
|
"side": 1,
|
|
"message": "I assume this does not need bumping up?",
|
|
"revId": "136be235fb0eb80e316d62c573ea2ce269e35877",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "56b749ef_60e46f01",
|
|
"filename": "requirements.txt",
|
|
"patchSetId": 18
|
|
},
|
|
"lineNbr": 47,
|
|
"author": {
|
|
"id": 4571
|
|
},
|
|
"writtenOn": "2024-04-29T01:10:08Z",
|
|
"side": 1,
|
|
"message": "Indeed, all required actions didn\u0027t land until 0.99.0",
|
|
"parentUuid": "611226de_7e0e4aaa",
|
|
"revId": "136be235fb0eb80e316d62c573ea2ce269e35877",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |