46f9192234
For rolling upgrades, we added a 'version' column to all the
DB object tables. However, we forgot to save the version value
for conductor objects. This patch addresses that.
Change-Id: Ic366f771491774f9708c9a81ab76dc13757d852b
Partial-Bug: #1526283
(cherry picked from commit 8a98228251
)
153 lines
6.9 KiB
Python
153 lines
6.9 KiB
Python
# coding=utf-8
|
|
#
|
|
# Copyright 2013 Hewlett-Packard Development Company, L.P.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import datetime
|
|
|
|
import mock
|
|
from oslo_utils import timeutils
|
|
|
|
from ironic import objects
|
|
from ironic.objects import base
|
|
from ironic.objects import fields
|
|
from ironic.tests.unit.db import base as db_base
|
|
from ironic.tests.unit.db import utils as db_utils
|
|
|
|
|
|
class TestConductorObject(db_base.DbTestCase):
|
|
|
|
def setUp(self):
|
|
super(TestConductorObject, self).setUp()
|
|
self.fake_conductor = (
|
|
db_utils.get_test_conductor(updated_at=timeutils.utcnow()))
|
|
|
|
def test_load(self):
|
|
host = self.fake_conductor['hostname']
|
|
with mock.patch.object(self.dbapi, 'get_conductor',
|
|
autospec=True) as mock_get_cdr:
|
|
mock_get_cdr.return_value = self.fake_conductor
|
|
objects.Conductor.get_by_hostname(self.context, host)
|
|
mock_get_cdr.assert_called_once_with(host)
|
|
|
|
def test_save(self):
|
|
host = self.fake_conductor['hostname']
|
|
with mock.patch.object(self.dbapi, 'get_conductor',
|
|
autospec=True) as mock_get_cdr:
|
|
mock_get_cdr.return_value = self.fake_conductor
|
|
c = objects.Conductor.get_by_hostname(self.context, host)
|
|
c.hostname = 'another-hostname'
|
|
self.assertRaises(NotImplementedError,
|
|
c.save, self.context)
|
|
mock_get_cdr.assert_called_once_with(host)
|
|
|
|
def test_touch(self):
|
|
host = self.fake_conductor['hostname']
|
|
with mock.patch.object(self.dbapi, 'get_conductor',
|
|
autospec=True) as mock_get_cdr:
|
|
with mock.patch.object(self.dbapi, 'touch_conductor',
|
|
autospec=True) as mock_touch_cdr:
|
|
mock_get_cdr.return_value = self.fake_conductor
|
|
c = objects.Conductor.get_by_hostname(self.context, host)
|
|
c.touch(self.context)
|
|
mock_get_cdr.assert_called_once_with(host)
|
|
mock_touch_cdr.assert_called_once_with(host)
|
|
|
|
def test_refresh(self):
|
|
host = self.fake_conductor['hostname']
|
|
t0 = self.fake_conductor['updated_at']
|
|
t1 = t0 + datetime.timedelta(seconds=10)
|
|
returns = [dict(self.fake_conductor, updated_at=t0),
|
|
dict(self.fake_conductor, updated_at=t1)]
|
|
expected = [mock.call(host), mock.call(host)]
|
|
with mock.patch.object(self.dbapi, 'get_conductor',
|
|
side_effect=returns,
|
|
autospec=True) as mock_get_cdr:
|
|
c = objects.Conductor.get_by_hostname(self.context, host)
|
|
# ensure timestamps have tzinfo
|
|
datetime_field = fields.DateTimeField()
|
|
self.assertEqual(
|
|
datetime_field.coerce(datetime_field, 'updated_at', t0),
|
|
c.updated_at)
|
|
c.refresh()
|
|
self.assertEqual(
|
|
datetime_field.coerce(datetime_field, 'updated_at', t1),
|
|
c.updated_at)
|
|
self.assertEqual(expected, mock_get_cdr.call_args_list)
|
|
self.assertEqual(self.context, c._context)
|
|
|
|
@mock.patch.object(base.IronicObject, 'get_target_version')
|
|
def _test_register(self, mock_target_version, update_existing=False):
|
|
mock_target_version.return_value = '1.5'
|
|
host = self.fake_conductor['hostname']
|
|
drivers = self.fake_conductor['drivers']
|
|
with mock.patch.object(self.dbapi, 'register_conductor',
|
|
autospec=True) as mock_register_cdr:
|
|
mock_register_cdr.return_value = self.fake_conductor
|
|
c = objects.Conductor.register(self.context, host, drivers,
|
|
update_existing=update_existing)
|
|
|
|
self.assertIsInstance(c, objects.Conductor)
|
|
mock_register_cdr.assert_called_once_with(
|
|
{'drivers': drivers,
|
|
'hostname': host,
|
|
'version': '1.5'},
|
|
update_existing=update_existing)
|
|
|
|
def test_register(self):
|
|
self._test_register()
|
|
|
|
def test_register_update_existing_true(self):
|
|
self._test_register(update_existing=True)
|
|
|
|
@mock.patch.object(objects.Conductor, 'unregister_all_hardware_interfaces')
|
|
def test_unregister(self, mock_unreg_ifaces):
|
|
host = self.fake_conductor['hostname']
|
|
with mock.patch.object(self.dbapi, 'get_conductor',
|
|
autospec=True) as mock_get_cdr:
|
|
with mock.patch.object(self.dbapi, 'unregister_conductor',
|
|
autospec=True) as mock_unregister_cdr:
|
|
mock_get_cdr.return_value = self.fake_conductor
|
|
c = objects.Conductor.get_by_hostname(self.context, host)
|
|
c.unregister()
|
|
mock_unregister_cdr.assert_called_once_with(host)
|
|
mock_unreg_ifaces.assert_called_once_with()
|
|
|
|
def test_register_hardware_interfaces(self):
|
|
host = self.fake_conductor['hostname']
|
|
self.config(default_deploy_interface='iscsi')
|
|
with mock.patch.object(self.dbapi, 'get_conductor',
|
|
autospec=True) as mock_get_cdr:
|
|
with mock.patch.object(self.dbapi,
|
|
'register_conductor_hardware_interfaces',
|
|
autospec=True) as mock_register:
|
|
mock_get_cdr.return_value = self.fake_conductor
|
|
c = objects.Conductor.get_by_hostname(self.context, host)
|
|
args = ('hardware-type', 'deploy', ['iscsi', 'direct'],
|
|
'iscsi')
|
|
c.register_hardware_interfaces(*args)
|
|
mock_register.assert_called_once_with(c.id, *args)
|
|
|
|
def test_unregister_all_hardware_interfaces(self):
|
|
host = self.fake_conductor['hostname']
|
|
with mock.patch.object(self.dbapi, 'get_conductor',
|
|
autospec=True) as mock_get_cdr:
|
|
with mock.patch.object(self.dbapi,
|
|
'unregister_conductor_hardware_interfaces',
|
|
autospec=True) as mock_unregister:
|
|
mock_get_cdr.return_value = self.fake_conductor
|
|
c = objects.Conductor.get_by_hostname(self.context, host)
|
|
c.unregister_all_hardware_interfaces()
|
|
mock_unregister.assert_called_once_with(c.id)
|