Update patch set 3
Patch Set 3: Code-Review-1 (2 comments) zengchen thanks looks good Please resolve the comments and we can merge it Patch-set: 3 Label: Code-Review=-1
This commit is contained in:
parent
2bafc58b2a
commit
09e8490856
|
@ -0,0 +1,50 @@
|
||||||
|
{
|
||||||
|
"comments": [
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "3a7e1126_67a56da0",
|
||||||
|
"filename": "devstack/plugin.sh",
|
||||||
|
"patchSetId": 3
|
||||||
|
},
|
||||||
|
"lineNbr": 31,
|
||||||
|
"author": {
|
||||||
|
"id": 13070
|
||||||
|
},
|
||||||
|
"writtenOn": "2015-12-19T18:43:33Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "I am not sure protect is the best value for the \"type\"\n\nI think that \"data-protect\" or data-protection are better",
|
||||||
|
"range": {
|
||||||
|
"startLine": 31,
|
||||||
|
"startChar": 43,
|
||||||
|
"endLine": 31,
|
||||||
|
"endChar": 50
|
||||||
|
},
|
||||||
|
"revId": "8b8dabc6aaabe8ccf08cdbbf773168e395ae15a7",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": false
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"key": {
|
||||||
|
"uuid": "3a7e1126_87cdf986",
|
||||||
|
"filename": "devstack/plugin.sh",
|
||||||
|
"patchSetId": 3
|
||||||
|
},
|
||||||
|
"lineNbr": 35,
|
||||||
|
"author": {
|
||||||
|
"id": 13070
|
||||||
|
},
|
||||||
|
"writtenOn": "2015-12-19T18:43:33Z",
|
||||||
|
"side": 1,
|
||||||
|
"message": "Why is the internal URL different-- without the $(tenant_id)s\n\nI think that Public admin and internal should all be the same at the moment",
|
||||||
|
"range": {
|
||||||
|
"startLine": 35,
|
||||||
|
"startChar": 73,
|
||||||
|
"endLine": 35,
|
||||||
|
"endChar": 74
|
||||||
|
},
|
||||||
|
"revId": "8b8dabc6aaabe8ccf08cdbbf773168e395ae15a7",
|
||||||
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||||
|
"unresolved": false
|
||||||
|
}
|
||||||
|
]
|
||||||
|
}
|
Loading…
Reference in New Issue