openstack
/
karbor
Code Issues Proposed changes

Implement network protection plugin(for DeleteOperation) 

Closes-Bug: 1699702

Change-Id: Ia44909ec8f8595fa41a9d8ded63059902807251d
This commit is contained in:
chenhuayi2 2017-06-26 16:13:14 +08:00 committed by chenhuayi
parent 9299ff11c8
commit 1786df4594
2 changed files with 77 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
karbor/services/protection/protection_plugins/network/neutron_protection_plugin.py
View File

@ -541,6 +541,34 @@ class RestoreOperation(protection_plugin.Operation):
)
class DeleteOperation(protection_plugin.Operation):
def on_main(self, checkpoint, resource, cntxt, parameters, **kwargs):
network_id = self._get_network_id(cntxt)
bank_section = checkpoint.get_resource_bank_section(network_id)
LOG.info("Deleting network backup, network_id: %s.", network_id)
try:
bank_section.update_object("status",
constants.RESOURCE_STATUS_DELETING)
objects = bank_section.list_objects()
for obj in objects:
if obj == "status":
continue
bank_section.delete_object(obj)
bank_section.update_object("status",
constants.RESOURCE_STATUS_DELETED)
except Exception as err:
# update resource_definition backup_status
LOG.error("Delete backup failed, network_id: %s.", network_id)
bank_section.update_object("status",
constants.RESOURCE_STATUS_ERROR)
raise exception.DeleteBackupFailed(
reason=err,
resource_id=network_id,
resource_type=self._SUPPORT_RESOURCE_TYPES)
class NeutronProtectionPlugin(protection_plugin.ProtectionPlugin):
_SUPPORT_RESOURCE_TYPES = [constants.NETWORK_RESOURCE_TYPE]

49
karbor/tests/unit/protection/test_neutron_protection_plugin.py
View File

@ -340,3 +340,52 @@ class NeutronProtectionPluginTest(base.TestCase):
call_hooks(protect_operation, self.checkpoint, resource, self.cntxt,
{})
@mock.patch('karbor.services.protection.clients.neutron.create')
def test_delete_backup(self, mock_neutron_create):
resource = Resource(id="network_id_1",
type=constants.NETWORK_RESOURCE_TYPE,
name="test")
fake_bank._plugin._objects[
"/resource_data/checkpoint_id/network_id_1/metadata"] = {
"resource_id": "network_id_1",
"network_metadata": {
"id": "9b68fb64-39d4-4d41-8cc9-f27846c6e5f5",
"router:external": False,
"admin_state_up": True,
"mtu": 1500
},
"subnet_metadata": {
"id": "808c3b3f-3d79-4c5b-a5b6-95dd07abeb2d",
"network_id": "9b68fb64-39d4-4d41-8cc9-f27846c6e5f5",
"host_routes": [],
"dns_nameservers": []
},
"port_metadata": {
"id": "2b34c97a-4ccc-44c0-bc50-b7bbfc3508eb",
"admin_state_up": True,
"allowed_address_pairs": [],
"fixed_ips": [{"subnet_id": "3d79-4c5b-a5b6-95dd07abeb2d",
"ip_address": "192.168.21.3"}]
},
"router_metadata": {
"id": "4c0e-4ed8-8d39-e27b7c1b7ae8",
"admin_state_up": True,
"availability_zone_hints": [],
"fixed_ips": {"network_id": "9bb2-4b8f-9eea-e45563efc420",
"enable_snat": True
}
},
"security-group_metadata": {
"id": "4ccc-44c0-bc50-b7bbfc3508eb",
"description": "Default security group",
"security_group_rules": []
}
}
delete_operation = self.plugin.get_delete_operation(resource)
mock_neutron_create.return_value = self.neutron_client
call_hooks(delete_operation, self.checkpoint, resource, self.cntxt,
{})