openstack
/
karbor
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: Code-Review-1

(2 comments)

Patch-set: 2
Reviewer: Gerrit User 11904 <11904@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 11904 2015-12-18 01:32:44 +00:00 committed by Gerrit Code Review
parent 064e23c5d4
commit 2be4016d57
1 changed files with 50 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
2bd6db516f468ef9a77053359bcc3b6d982594b9 Normal file
View File

@ -0,0 +1,50 @@
{
"comments": [
{
"key": {
"uuid": "3a7e1126_afedae26",
"filename": "/COMMIT_MSG",
"patchSetId": 2
},
"lineNbr": 7,
"author": {
"id": 11904
},
"writtenOn": "2015-12-18T01:32:44Z",
"side": 1,
"message": "s/tenat_name/tenant_name/\n\nWould also be good to reformat this to meet the OpenStack commit message guidelines (summary no more the 50 characters, description no more than 72, etc.)\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Summary_of_Git_commit_message_structure",
"range": {
"startLine": 7,
"startChar": 10,
"endLine": 7,
"endChar": 20
},
"revId": "2bd6db516f468ef9a77053359bcc3b6d982594b9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a7e1126_6ff7c6f5",
"filename": "/COMMIT_MSG",
"patchSetId": 2
},
"lineNbr": 10,
"author": {
"id": 11904
},
"writtenOn": "2015-12-18T01:32:44Z",
"side": 1,
"message": "Needs space before \"Otherwise\"",
"range": {
"startLine": 10,
"startChar": 36,
"endLine": 10,
"endChar": 45
},
"revId": "2bd6db516f468ef9a77053359bcc3b6d982594b9",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}