openstack
/
karbor
Code Issues Proposed changes

Update patch set 7 

Patch Set 7: Code-Review-1

(3 comments)

Patch-set: 7
Label: Code-Review=-1
This commit is contained in:
Gerrit User 13070 2015-12-25 07:06:04 +00:00 committed by Gerrit Code Review
parent 3c4c644546
commit 32fbf79108
1 changed files with 73 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

73
cc6508c656856234179e882b6ade5a8866733c80 Normal file
View File

@ -0,0 +1,73 @@
{
"comments": [
{
"key": {
"uuid": "1a7b0d38_42f2ff70",
"filename": "MANIFEST.in",
"patchSetId": 7
},
"lineNbr": 4,
"author": {
"id": 13070
},
"writtenOn": "2015-12-25T07:06:04Z",
"side": 1,
"message": "Usually there a empty line between the include and exclude",
"range": {
"startLine": 4,
"startChar": 0,
"endLine": 4,
"endChar": 7
},
"revId": "cc6508c656856234179e882b6ade5a8866733c80",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a7b0d38_f0071a1a",
"filename": "smaug/common/config.py",
"patchSetId": 7
},
"lineNbr": 35,
"author": {
"id": 13070
},
"writtenOn": "2015-12-25T07:06:04Z",
"side": 1,
"message": "are we using this option ? Where ? \n\ndo we need to keep track about the deprecated_name ?",
"range": {
"startLine": 35,
"startChar": 16,
"endLine": 35,
"endChar": 26
},
"revId": "cc6508c656856234179e882b6ade5a8866733c80",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a7b0d38_bb0653cc",
"filename": "smaug/utils.py",
"patchSetId": 7
},
"lineNbr": 78,
"author": {
"id": 13070
},
"writtenOn": "2015-12-25T07:06:04Z",
"side": 1,
"message": "I think that all of our time calculation should be done with TZ-aware datetime \n\nWhy did you set the the with_timezone to False I think it should be True",
"range": {
"startLine": 78,
"startChar": 32,
"endLine": 78,
"endChar": 45
},
"revId": "cc6508c656856234179e882b6ade5a8866733c80",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}