Update patch set 2
Patch Set 2: (15 comments) Again, most comments focus on the provider creation procedure. Is this the decision of v1: admin won't compose providers from plugins, but protection service will load provider (composition of plugins) from config file? Patch-set: 2 Label: Verified=0
This commit is contained in:
Gerrit User 19346
Gerrit Code Review
parent
f4aa6446c1
commit
37a588248b
|
|
@ -17,6 +17,24 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa69d971_c540690a",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 7,
|
||||
"author": {
|
||||
"id": 19346
|
||||
},
|
||||
"writtenOn": "2015-12-30T02:24:53Z",
|
||||
"side": 1,
|
||||
"message": "Thanks for reminder!\nWill correct in next patch set.",
|
||||
"parentUuid": "1a7b0d38_f3f05693",
|
||||
"revId": "4d00e9075b28f25a58dc81d00f3e2d55a529e178",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1a7b0d38_5054c051",
|
||||
|
|
@ -40,6 +58,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa69d971_a56f7591",
|
||||
"filename": "doc/source/protection-service/class_diagram.pu",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 12,
|
||||
"author": {
|
||||
"id": 19346
|
||||
},
|
||||
"writtenOn": "2015-12-30T02:24:53Z",
|
||||
"side": 1,
|
||||
"message": "Ok, will remove this mark. It seems safe to make it as plain instance in side internal services.",
|
||||
"parentUuid": "1a7b0d38_5054c051",
|
||||
"range": {
|
||||
"startLine": 12,
|
||||
"startChar": 6,
|
||||
"endLine": 12,
|
||||
"endChar": 51
|
||||
},
|
||||
"revId": "4d00e9075b28f25a58dc81d00f3e2d55a529e178",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1a7b0d38_506da02f",
|
||||
|
|
@ -63,6 +105,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa69d971_65697d8b",
|
||||
"filename": "doc/source/protection-service/class_diagram.pu",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 13,
|
||||
"author": {
|
||||
"id": 19346
|
||||
},
|
||||
"writtenOn": "2015-12-30T02:24:53Z",
|
||||
"side": 1,
|
||||
"message": "hmm, about the parameter, I just followed one style as planttext sample.\nSure, will correct the stereotypes.",
|
||||
"parentUuid": "1a7b0d38_506da02f",
|
||||
"range": {
|
||||
"startLine": 13,
|
||||
"startChar": 3,
|
||||
"endLine": 13,
|
||||
"endChar": 42
|
||||
},
|
||||
"revId": "4d00e9075b28f25a58dc81d00f3e2d55a529e178",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1a7b0d38_d4064e1b",
|
||||
|
|
@ -86,6 +152,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa69d971_050521c1",
|
||||
"filename": "doc/source/protection-service/class_diagram.pu",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 14,
|
||||
"author": {
|
||||
"id": 19346
|
||||
},
|
||||
"writtenOn": "2015-12-30T02:24:53Z",
|
||||
"side": 1,
|
||||
"message": "will follow Saggi\u0027s suggestion.",
|
||||
"parentUuid": "1a7b0d38_d4064e1b",
|
||||
"range": {
|
||||
"startLine": 14,
|
||||
"startChar": 3,
|
||||
"endLine": 14,
|
||||
"endChar": 19
|
||||
},
|
||||
"revId": "4d00e9075b28f25a58dc81d00f3e2d55a529e178",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1a7b0d38_fc46e34d",
|
||||
|
|
@ -109,6 +199,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa69d971_85f911cb",
|
||||
"filename": "doc/source/protection-service/class_diagram.pu",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 16,
|
||||
"author": {
|
||||
"id": 19346
|
||||
},
|
||||
"writtenOn": "2015-12-30T02:24:53Z",
|
||||
"side": 1,
|
||||
"message": "hmm, I understand you guys idea. So for the first step, admin won\u0027t compose a provider but protection service will load provider from config file.",
|
||||
"parentUuid": "1a7b0d38_fc46e34d",
|
||||
"range": {
|
||||
"startLine": 15,
|
||||
"startChar": 2,
|
||||
"endLine": 16,
|
||||
"endChar": 44
|
||||
},
|
||||
"revId": "4d00e9075b28f25a58dc81d00f3e2d55a529e178",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1a7b0d38_5cc857a8",
|
||||
|
|
@ -132,6 +246,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa69d971_450319b9",
|
||||
"filename": "doc/source/protection-service/class_diagram.pu",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 21,
|
||||
"author": {
|
||||
"id": 19346
|
||||
},
|
||||
"writtenOn": "2015-12-30T02:24:53Z",
|
||||
"side": 1,
|
||||
"message": "same answer above",
|
||||
"parentUuid": "1a7b0d38_5cc857a8",
|
||||
"range": {
|
||||
"startLine": 20,
|
||||
"startChar": 2,
|
||||
"endLine": 21,
|
||||
"endChar": 57
|
||||
},
|
||||
"revId": "4d00e9075b28f25a58dc81d00f3e2d55a529e178",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1a7b0d38_3cceab82",
|
||||
|
|
@ -155,6 +293,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa69d971_052c4149",
|
||||
"filename": "doc/source/protection-service/class_diagram.pu",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 23,
|
||||
"author": {
|
||||
"id": 19346
|
||||
},
|
||||
"writtenOn": "2015-12-30T02:24:53Z",
|
||||
"side": 1,
|
||||
"message": "got it",
|
||||
"parentUuid": "1a7b0d38_3cceab82",
|
||||
"range": {
|
||||
"startLine": 22,
|
||||
"startChar": 2,
|
||||
"endLine": 23,
|
||||
"endChar": 58
|
||||
},
|
||||
"revId": "4d00e9075b28f25a58dc81d00f3e2d55a529e178",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1a7b0d38_1c988f77",
|
||||
|
|
@ -178,6 +340,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa69d971_253145a3",
|
||||
"filename": "doc/source/protection-service/class_diagram.pu",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 25,
|
||||
"author": {
|
||||
"id": 19346
|
||||
},
|
||||
"writtenOn": "2015-12-30T02:24:53Z",
|
||||
"side": 1,
|
||||
"message": "same answer above.",
|
||||
"parentUuid": "1a7b0d38_1c988f77",
|
||||
"range": {
|
||||
"startLine": 25,
|
||||
"startChar": 2,
|
||||
"endLine": 25,
|
||||
"endChar": 48
|
||||
},
|
||||
"revId": "4d00e9075b28f25a58dc81d00f3e2d55a529e178",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1a7b0d38_508920c8",
|
||||
|
|
@ -201,6 +387,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa69d971_05d3e139",
|
||||
"filename": "doc/source/protection-service/class_diagram.pu",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 32,
|
||||
"author": {
|
||||
"id": 19346
|
||||
},
|
||||
"writtenOn": "2015-12-30T02:24:53Z",
|
||||
"side": 1,
|
||||
"message": "hmm, I understand you guys idea. So for the first step, admin won\u0027t compose a provider but protection service will load provider from config file.\nIn my mind, cloud admin would compose the provider from plugins.\nIs this the decision for v1?",
|
||||
"parentUuid": "1a7b0d38_508920c8",
|
||||
"range": {
|
||||
"startLine": 32,
|
||||
"startChar": 6,
|
||||
"endLine": 32,
|
||||
"endChar": 51
|
||||
},
|
||||
"revId": "4d00e9075b28f25a58dc81d00f3e2d55a529e178",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1a7b0d38_d096703e",
|
||||
|
|
@ -224,6 +434,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa69d971_25d86553",
|
||||
"filename": "doc/source/protection-service/class_diagram.pu",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 49,
|
||||
"author": {
|
||||
"id": 19346
|
||||
},
|
||||
"writtenOn": "2015-12-30T02:24:53Z",
|
||||
"side": 1,
|
||||
"message": "will remove it",
|
||||
"parentUuid": "1a7b0d38_d096703e",
|
||||
"range": {
|
||||
"startLine": 49,
|
||||
"startChar": 0,
|
||||
"endLine": 49,
|
||||
"endChar": 2
|
||||
},
|
||||
"revId": "4d00e9075b28f25a58dc81d00f3e2d55a529e178",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1a7b0d38_9428c6e3",
|
||||
|
|
@ -247,6 +481,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa69d971_256385b3",
|
||||
"filename": "doc/source/protection-service/class_diagram.pu",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 82,
|
||||
"author": {
|
||||
"id": 19346
|
||||
},
|
||||
"writtenOn": "2015-12-30T02:24:53Z",
|
||||
"side": 1,
|
||||
"message": "we need serialize checkpoint to persist it as a value into object storage (bank).",
|
||||
"parentUuid": "1a7b0d38_9428c6e3",
|
||||
"range": {
|
||||
"startLine": 82,
|
||||
"startChar": 6,
|
||||
"endLine": 82,
|
||||
"endChar": 26
|
||||
},
|
||||
"revId": "4d00e9075b28f25a58dc81d00f3e2d55a529e178",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1a7b0d38_70977c3a",
|
||||
|
|
@ -270,6 +528,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa69d971_c5dce948",
|
||||
"filename": "doc/source/protection-service/class_diagram.pu",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 86,
|
||||
"author": {
|
||||
"id": 19346
|
||||
},
|
||||
"writtenOn": "2015-12-30T02:24:53Z",
|
||||
"side": 1,
|
||||
"message": "will remove it",
|
||||
"parentUuid": "1a7b0d38_70977c3a",
|
||||
"range": {
|
||||
"startLine": 86,
|
||||
"startChar": 0,
|
||||
"endLine": 86,
|
||||
"endChar": 1
|
||||
},
|
||||
"revId": "4d00e9075b28f25a58dc81d00f3e2d55a529e178",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1a7b0d38_909c685e",
|
||||
|
|
@ -293,6 +575,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa69d971_e5e1edff",
|
||||
"filename": "doc/source/protection-service/class_diagram.pu",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 88,
|
||||
"author": {
|
||||
"id": 19346
|
||||
},
|
||||
"writtenOn": "2015-12-30T02:24:53Z",
|
||||
"side": 1,
|
||||
"message": "will remove it",
|
||||
"parentUuid": "1a7b0d38_909c685e",
|
||||
"range": {
|
||||
"startLine": 88,
|
||||
"startChar": 0,
|
||||
"endLine": 88,
|
||||
"endChar": 1
|
||||
},
|
||||
"revId": "4d00e9075b28f25a58dc81d00f3e2d55a529e178",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1a7b0d38_b4dce273",
|
||||
|
|
@ -316,6 +622,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa69d971_85e7d111",
|
||||
"filename": "doc/source/protection-service/class_diagram.pu",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 103,
|
||||
"author": {
|
||||
"id": 19346
|
||||
},
|
||||
"writtenOn": "2015-12-30T02:24:53Z",
|
||||
"side": 1,
|
||||
"message": "hmm, I understand you guys idea. So for the first step, admin won\u0027t compose a provider but protection service will load provider from config file.\nIn my mind, cloud admin would compose the provider from plugins.\nIs this the decision for v1?",
|
||||
"parentUuid": "1a7b0d38_b4dce273",
|
||||
"range": {
|
||||
"startLine": 103,
|
||||
"startChar": 3,
|
||||
"endLine": 103,
|
||||
"endChar": 20
|
||||
},
|
||||
"revId": "4d00e9075b28f25a58dc81d00f3e2d55a529e178",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1a7b0d38_143936a4",
|
||||
|
|
@ -339,6 +669,30 @@
|
|||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fa69d971_a5e4550d",
|
||||
"filename": "doc/source/protection-service/class_diagram.pu",
|
||||
"patchSetId": 2
|
||||
},
|
||||
"lineNbr": 124,
|
||||
"author": {
|
||||
"id": 19346
|
||||
},
|
||||
"writtenOn": "2015-12-30T02:24:53Z",
|
||||
"side": 1,
|
||||
"message": "hmm, I understand you guys idea. So for the first step, admin won\u0027t compose a provider but protection service will load provider from config file.\nIn my mind, cloud admin would compose the provider from plugins.\nIs this the decision for v1?",
|
||||
"parentUuid": "1a7b0d38_143936a4",
|
||||
"range": {
|
||||
"startLine": 124,
|
||||
"startChar": 3,
|
||||
"endLine": 124,
|
||||
"endChar": 18
|
||||
},
|
||||
"revId": "4d00e9075b28f25a58dc81d00f3e2d55a529e178",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "1a7b0d38_f45caa7e",
|
||||
|
|
|
|||
Loading…
Reference in New Issue