openstack/karbor
Code Issues Proposed changes

Merge "Add unit test for plan api"

Browse Source
This commit is contained in:
Zuul 2019-05-10 01:31:56 +00:00 committed by Gerrit Code Review
commit 39bdc2a891
1 changed files with 40 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

40
karbor/tests/unit/api/v1/test_plans.py
View File

@ -198,6 +198,12 @@ class PlanApiTest(base.TestCase):
exc.HTTPBadRequest, self.controller.show, exc.HTTPBadRequest, self.controller.show,
req, "1") req, "1")
def test_plan_show_InvalidPlanId(self):
req = fakes.HTTPRequest.blank('/v1/plans')
self.assertRaises(
exc.HTTPNotFound, self.controller.show,
req, "2a9ce1f3-cc1a-4516-9435-0ebb13caa398")
@mock.patch( @mock.patch(
'karbor.api.v1.plans.PlansController._plan_get') 'karbor.api.v1.plans.PlansController._plan_get')
def test_plan_delete(self, moak_plan_get): def test_plan_delete(self, moak_plan_get):
@ -211,6 +217,24 @@ class PlanApiTest(base.TestCase):
exc.HTTPBadRequest, self.controller.delete, exc.HTTPBadRequest, self.controller.delete,
req, "1") req, "1")
def test_plan_delete_InvalidPlanId(self):
req = fakes.HTTPRequest.blank('/v1/plans')
self.assertRaises(
exc.HTTPNotFound, self.controller.delete,
req, "2a9ce1f3-cc1a-4516-9435-0ebb13caa398")
@mock.patch(
'karbor.api.v1.plans.PlansController._plan_get')
def test_plan_delete_authorize_failed(
self, mock_plan_get):
plan = self._plan_in_request_body()
plan['project_id'] = DEFAULT_PROJECT_ID
req = fakes.HTTPRequest.blank('/v1/plans')
mock_plan_get.return_value = plan
self.assertRaises(exception.PolicyNotAuthorized,
self.controller.delete, req,
"2a9ce1f3-cc1a-4516-9435-0ebb13caa398")
@mock.patch( @mock.patch(
'karbor.api.v1.plans.PlansController._plan_get') 'karbor.api.v1.plans.PlansController._plan_get')
def test_plan_update_InvalidStatus( def test_plan_update_InvalidStatus(
@ -227,6 +251,22 @@ class PlanApiTest(base.TestCase):
"2a9ce1f3-cc1a-4516-9435-0ebb13caa398", "2a9ce1f3-cc1a-4516-9435-0ebb13caa398",
body=body) body=body)
@mock.patch(
'karbor.api.v1.plans.PlansController._plan_get')
def test_plan_update_InvalidInput(
self, mock_plan_get):
plan = self._plan_update_request_body(
name=DEFAULT_NAME,
status=constants.PLAN_STATUS_SUSPENDED,
resources=DEFAULT_RESOURCES)
body = {"plan": plan}
req = fakes.HTTPRequest.blank('/v1/plans')
mock_plan_get.return_value = plan
self.assertRaises(exception.InvalidInput,
self.controller.update, req,
"2a9ce1f3-cc1a-4516-9435-0ebb13caa398",
body=body)
def _plan_in_request_body(self, name=DEFAULT_NAME, def _plan_in_request_body(self, name=DEFAULT_NAME,
description=DEFAULT_DESCRIPTION, description=DEFAULT_DESCRIPTION,
provider_id=DEFAULT_PROVIDER_ID, provider_id=DEFAULT_PROVIDER_ID,