Update patch set 1

Patch Set 1: Code-Review-1 (7 comments) Hi Yinwei, Thank you for doing the design for the protection service First i just submitted a patch for the spec folder Please submit this according to the template https://review.openstack.org/#/c/261913/ The images are placed correctly and need to be referenced from the rst I just started doing the review Saggi and me will finish the review today Please add all the group as reviewers so you get more reviews Patch-set: 1 Label: Code-Review=-1
2015-12-28 07:53:33 +00:00 · 2015-12-28 07:53:33 +00:00 · 5c1ad3054c
parent 117e44543c
commit 5c1ad3054c
1 changed files with 165 additions and 0 deletions
--- a/165
+++ b/165
@ -0,0 +1,165 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "1a7b0d38_093db8c3",
+        "filename": "doc/source/protection-service/class_diagram.pu",
+        "patchSetId": 1
+      },
+      "lineNbr": 13,
+      "author": {
+        "id": 13070
+      },
+      "writtenOn": "2015-12-28T07:53:33Z",
+      "side": 1,
+      "message": "I think that the RPC should reflect the manual API  call to do protect that is \n\nPOST /provider/\u003cuuid\u003echeckpoint \n\nso it should be something like Provider_create_checkpoint (provider id , plan id/info)",
+      "range": {
+        "startLine": 13,
+        "startChar": 3,
+        "endLine": 13,
+        "endChar": 19
+      },
+      "revId": "e6453811d9c0b2964329f1c340b95e0da515e72d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "1a7b0d38_4e10a659",
+        "filename": "doc/source/protection-service/class_diagram.pu",
+        "patchSetId": 1
+      },
+      "lineNbr": 15,
+      "author": {
+        "id": 13070
+      },
+      "writtenOn": "2015-12-28T07:53:33Z",
+      "side": 1,
+      "message": "I do not think we need to expose this to the API in first phase",
+      "range": {
+        "startLine": 15,
+        "startChar": 3,
+        "endLine": 15,
+        "endChar": 24
+      },
+      "revId": "e6453811d9c0b2964329f1c340b95e0da515e72d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "1a7b0d38_2e5e7a44",
+        "filename": "doc/source/protection-service/class_diagram.pu",
+        "patchSetId": 1
+      },
+      "lineNbr": 21,
+      "author": {
+        "id": 13070
+      },
+      "writtenOn": "2015-12-28T07:53:33Z",
+      "side": 1,
+      "message": "Bank is currently internal to the provider no need to pass this info on the RPC, this info is not exposed to the user.\nThe admin can create a frendly name for the provider that reflect the bank",
+      "range": {
+        "startLine": 21,
+        "startChar": 3,
+        "endLine": 21,
+        "endChar": 27
+      },
+      "revId": "e6453811d9c0b2964329f1c340b95e0da515e72d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "1a7b0d38_ce7fb6a9",
+        "filename": "doc/source/protection-service/class_diagram.pu",
+        "patchSetId": 1
+      },
+      "lineNbr": 22,
+      "author": {
+        "id": 13070
+      },
+      "writtenOn": "2015-12-28T07:53:33Z",
+      "side": 1,
+      "message": "This is Admin API in the first version we will not need  RPC as our plan is to configure this in the configuration file",
+      "range": {
+        "startLine": 22,
+        "startChar": 3,
+        "endLine": 22,
+        "endChar": 27
+      },
+      "revId": "e6453811d9c0b2964329f1c340b95e0da515e72d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "1a7b0d38_4e3986f1",
+        "filename": "doc/source/protection-service/class_diagram.pu",
+        "patchSetId": 1
+      },
+      "lineNbr": 23,
+      "author": {
+        "id": 13070
+      },
+      "writtenOn": "2015-12-28T07:53:33Z",
+      "side": 1,
+      "message": "Admin currently configuration",
+      "range": {
+        "startLine": 23,
+        "startChar": 3,
+        "endLine": 23,
+        "endChar": 27
+      },
+      "revId": "e6453811d9c0b2964329f1c340b95e0da515e72d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "1a7b0d38_2e251ac0",
+        "filename": "doc/source/protection-service/class_diagram.pu",
+        "patchSetId": 1
+      },
+      "lineNbr": 25,
+      "author": {
+        "id": 13070
+      },
+      "writtenOn": "2015-12-28T07:53:33Z",
+      "side": 1,
+      "message": "again not exposed to the API in v1 in next phase should be Admin",
+      "range": {
+        "startLine": 25,
+        "startChar": 3,
+        "endLine": 25,
+        "endChar": 27
+      },
+      "revId": "e6453811d9c0b2964329f1c340b95e0da515e72d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "1a7b0d38_ce91f6f2",
+        "filename": "doc/source/protection-service/class_diagram.pu",
+        "patchSetId": 1
+      },
+      "lineNbr": 49,
+      "author": {
+        "id": 13070
+      },
+      "writtenOn": "2015-12-28T07:53:33Z",
+      "side": 1,
+      "message": "please remove the white spaces",
+      "range": {
+        "startLine": 49,
+        "startChar": 0,
+        "endLine": 49,
+        "endChar": 2
+      },
+      "revId": "e6453811d9c0b2964329f1c340b95e0da515e72d",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}