openstack
/
karbor
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: Code-Review-1

(6 comments)

Patch-set: 2
Label: Code-Review=-1
This commit is contained in:
Gerrit User 2023 2015-12-28 15:29:00 +00:00 committed by Gerrit Code Review
parent 2107e72d18
commit 68133c6dae
1 changed files with 138 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

138
4d00e9075b28f25a58dc81d00f3e2d55a529e178
View File

@ -17,6 +17,52 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a7b0d38_5054c051",
"filename": "doc/source/protection-service/class_diagram.pu",
"patchSetId": 2
},
"lineNbr": 12,
"author": {
"id": 2023
},
"writtenOn": "2015-12-28T15:29:00Z",
"side": 1,
"message": "Why is this a singleton? Other managers in OpenStack are just plain instances.",
"range": {
"startLine": 12,
"startChar": 6,
"endLine": 12,
"endChar": 51
},
"revId": "4d00e9075b28f25a58dc81d00f3e2d55a529e178",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a7b0d38_506da02f",
"filename": "doc/source/protection-service/class_diagram.pu",
"patchSetId": 2
},
"lineNbr": 13,
"author": {
"id": 2023
},
"writtenOn": "2015-12-28T15:29:00Z",
"side": 1,
"message": "* parameters go inside the ().\n* stereotypes should be marked as stereotypes. unless you actually mean to make the methods names that way.\n\nExample:\n + \u003c\u003crpc call\u003e\u003e protection(backup_lan: BackupPlan): void",
"range": {
"startLine": 13,
"startChar": 3,
"endLine": 13,
"endChar": 42
},
"revId": "4d00e9075b28f25a58dc81d00f3e2d55a529e178",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a7b0d38_fc46e34d",
@ -108,6 +154,98 @@
"revId": "4d00e9075b28f25a58dc81d00f3e2d55a529e178",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a7b0d38_508920c8",
"filename": "doc/source/protection-service/class_diagram.pu",
"patchSetId": 2
},
"lineNbr": 32,
"author": {
"id": 2023
},
"writtenOn": "2015-12-28T15:29:00Z",
"side": 1,
"message": "What is this for? The user never queries about the available plugins.",
"range": {
"startLine": 32,
"startChar": 6,
"endLine": 32,
"endChar": 51
},
"revId": "4d00e9075b28f25a58dc81d00f3e2d55a529e178",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a7b0d38_d096703e",
"filename": "doc/source/protection-service/class_diagram.pu",
"patchSetId": 2
},
"lineNbr": 49,
"author": {
"id": 2023
},
"writtenOn": "2015-12-28T15:29:00Z",
"side": 1,
"message": "rouge space",
"range": {
"startLine": 49,
"startChar": 0,
"endLine": 49,
"endChar": 2
},
"revId": "4d00e9075b28f25a58dc81d00f3e2d55a529e178",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a7b0d38_70977c3a",
"filename": "doc/source/protection-service/class_diagram.pu",
"patchSetId": 2
},
"lineNbr": 86,
"author": {
"id": 2023
},
"writtenOn": "2015-12-28T15:29:00Z",
"side": 1,
"message": "rouge space",
"range": {
"startLine": 86,
"startChar": 0,
"endLine": 86,
"endChar": 1
},
"revId": "4d00e9075b28f25a58dc81d00f3e2d55a529e178",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a7b0d38_909c685e",
"filename": "doc/source/protection-service/class_diagram.pu",
"patchSetId": 2
},
"lineNbr": 88,
"author": {
"id": 2023
},
"writtenOn": "2015-12-28T15:29:00Z",
"side": 1,
"message": "rouge space",
"range": {
"startLine": 88,
"startChar": 0,
"endLine": 88,
"endChar": 1
},
"revId": "4d00e9075b28f25a58dc81d00f3e2d55a529e178",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}