openstack
/
karbor
Code Issues Proposed changes

Update patch set 7 

Patch Set 7: Code-Review-1

(7 comments)

Patch-set: 7
Label: Code-Review=-1
This commit is contained in:
Gerrit User 16203 2015-12-18 18:48:54 +00:00 committed by Gerrit Code Review
parent 2aa43bab6e
commit 691b979006
1 changed files with 137 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

137
186ccdba2f7ffa08aa728eebbeb44cf3c5ad8847
View File

@ -1,5 +1,102 @@
{
"comments": [
{
"key": {
"uuid": "3a7e1126_9dc9dd28",
"filename": "doc/source/readme.rst",
"patchSetId": 7
},
"lineNbr": 1,
"author": {
"id": 16203
},
"writtenOn": "2015-12-18T18:48:54Z",
"side": 1,
"message": "This image isn\u0027t the newest.",
"revId": "186ccdba2f7ffa08aa728eebbeb44cf3c5ad8847",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a7e1126_6f001702",
"filename": "doc/source/readme.rst",
"patchSetId": 7
},
"lineNbr": 107,
"author": {
"id": 16203
},
"writtenOn": "2015-12-18T18:48:54Z",
"side": 1,
"message": "plans -\u003e plan",
"range": {
"startLine": 107,
"startChar": 15,
"endLine": 107,
"endChar": 20
},
"revId": "186ccdba2f7ffa08aa728eebbeb44cf3c5ad8847",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a7e1126_7d019169",
"filename": "doc/source/readme.rst",
"patchSetId": 7
},
"lineNbr": 145,
"author": {
"id": 16203
},
"writtenOn": "2015-12-18T18:48:54Z",
"side": 1,
"message": "This link seems invalid.",
"revId": "186ccdba2f7ffa08aa728eebbeb44cf3c5ad8847",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a7e1126_97fd553c",
"filename": "doc/source/readme.rst",
"patchSetId": 7
},
"lineNbr": 192,
"author": {
"id": 16203
},
"writtenOn": "2015-12-18T18:48:54Z",
"side": 1,
"message": "Shouldn\u0027t here be provider ID? Cause Bank isn\u0027t visible for user.",
"revId": "186ccdba2f7ffa08aa728eebbeb44cf3c5ad8847",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a7e1126_b702d109",
"filename": "doc/source/readme.rst",
"patchSetId": 7
},
"lineNbr": 193,
"author": {
"id": 16203
},
"writtenOn": "2015-12-18T18:48:54Z",
"side": 1,
"message": "Delete this redundant \u0027a\u0027",
"range": {
"startLine": 193,
"startChar": 31,
"endLine": 193,
"endChar": 32
},
"revId": "186ccdba2f7ffa08aa728eebbeb44cf3c5ad8847",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a7e1126_1479662f",
@ -22,6 +119,46 @@
"revId": "186ccdba2f7ffa08aa728eebbeb44cf3c5ad8847",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a7e1126_ba8cf87f",
"filename": "doc/source/readme.rst",
"patchSetId": 7
},
"lineNbr": 203,
"author": {
"id": 16203
},
"writtenOn": "2015-12-18T18:48:54Z",
"side": 1,
"message": "Delete this redundant \u0027a\u0027",
"range": {
"startLine": 203,
"startChar": 31,
"endLine": 203,
"endChar": 32
},
"revId": "186ccdba2f7ffa08aa728eebbeb44cf3c5ad8847",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3a7e1126_dd1e85ba",
"filename": "doc/source/readme.rst",
"patchSetId": 7
},
"lineNbr": 253,
"author": {
"id": 16203
},
"writtenOn": "2015-12-18T18:48:54Z",
"side": 1,
"message": "And Protectable management as well.",
"revId": "186ccdba2f7ffa08aa728eebbeb44cf3c5ad8847",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}