Update patch set 15

Patch Set 15: Code-Review-1 (9 comments) i suggest to think the each class name over, let them be more understandable Patch-set: 15 Label: Code-Review=-1
2015-12-16 10:19:23 +00:00 · 2015-12-16 10:19:23 +00:00 · 84a70a57d0
parent 8a78d2c7e1
commit 84a70a57d0
1 changed files with 157 additions and 0 deletions
--- a/157
+++ b/157
@ -0,0 +1,157 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "5a710552_67d5fb41",
+        "filename": "doc/source/api/bank.md",
+        "patchSetId": 15
+      },
+      "lineNbr": 30,
+      "author": {
+        "id": 15069
+      },
+      "writtenOn": "2015-12-16T10:19:23Z",
+      "side": 1,
+      "message": "please see the comments of previous version.",
+      "revId": "3cbe3390d300e64a293526dcafa021c0765cbb60",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5a710552_ab2fdcf4",
+        "filename": "doc/source/api/class_diagram.pu",
+        "patchSetId": 15
+      },
+      "lineNbr": 8,
+      "author": {
+        "id": 15069
+      },
+      "writtenOn": "2015-12-16T10:19:23Z",
+      "side": 1,
+      "message": "what\u0027s the parameter used for?",
+      "revId": "3cbe3390d300e64a293526dcafa021c0765cbb60",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5a710552_6b71f4df",
+        "filename": "doc/source/api/class_diagram.pu",
+        "patchSetId": 15
+      },
+      "lineNbr": 52,
+      "author": {
+        "id": 15069
+      },
+      "writtenOn": "2015-12-16T10:19:23Z",
+      "side": 1,
+      "message": "why not used one enum parameter?",
+      "revId": "3cbe3390d300e64a293526dcafa021c0765cbb60",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5a710552_ab1cbc77",
+        "filename": "doc/source/api/class_diagram.pu",
+        "patchSetId": 15
+      },
+      "lineNbr": 63,
+      "author": {
+        "id": 15069
+      },
+      "writtenOn": "2015-12-16T10:19:23Z",
+      "side": 1,
+      "message": "s/BackupPlan/BackupPlanOperation",
+      "revId": "3cbe3390d300e64a293526dcafa021c0765cbb60",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5a710552_a62713b5",
+        "filename": "doc/source/api/class_diagram.pu",
+        "patchSetId": 15
+      },
+      "lineNbr": 69,
+      "author": {
+        "id": 15069
+      },
+      "writtenOn": "2015-12-16T10:19:23Z",
+      "side": 1,
+      "message": "s/DeleteCheckpoints/DeleteCheckpointsOperation",
+      "revId": "3cbe3390d300e64a293526dcafa021c0765cbb60",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5a710552_e6351bda",
+        "filename": "doc/source/api/class_diagram.pu",
+        "patchSetId": 15
+      },
+      "lineNbr": 77,
+      "author": {
+        "id": 15069
+      },
+      "writtenOn": "2015-12-16T10:19:23Z",
+      "side": 1,
+      "message": "s/description/comments",
+      "revId": "3cbe3390d300e64a293526dcafa021c0765cbb60",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5a710552_065f070f",
+        "filename": "doc/source/api/class_diagram.pu",
+        "patchSetId": 15
+      },
+      "lineNbr": 79,
+      "author": {
+        "id": 15069
+      },
+      "writtenOn": "2015-12-16T10:19:23Z",
+      "side": 1,
+      "message": "miss ResourceType definition",
+      "revId": "3cbe3390d300e64a293526dcafa021c0765cbb60",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5a710552_66428b12",
+        "filename": "doc/source/api/class_diagram.pu",
+        "patchSetId": 15
+      },
+      "lineNbr": 105,
+      "author": {
+        "id": 15069
+      },
+      "writtenOn": "2015-12-16T10:19:23Z",
+      "side": 1,
+      "message": "is this a Operation too?",
+      "revId": "3cbe3390d300e64a293526dcafa021c0765cbb60",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "5a710552_060067a9",
+        "filename": "doc/source/api/class_diagram.pu",
+        "patchSetId": 15
+      },
+      "lineNbr": 110,
+      "author": {
+        "id": 15069
+      },
+      "writtenOn": "2015-12-16T10:19:23Z",
+      "side": 1,
+      "message": "string type or DateTime? suggest to keep the same as line36.",
+      "revId": "3cbe3390d300e64a293526dcafa021c0765cbb60",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}