openstack
/
karbor
Code Issues Proposed changes

fix for get 'force' parameter from parameters 

When we use parameter.get('force',False), if 'force' in parameters,
we will get a string 'True' or 'False', which type is not boolean.

This will affect later judgment.

Change-Id: Iaab3aee377857dc1d431531dc150520365a93482
This commit is contained in:
fudunwei 2020-10-28 09:08:34 +08:00
parent fcca3935af
commit 9619340e3a
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
karbor/services/protection/protection_plugins/share/share_snapshot_plugin.py
View File

@ -137,7 +137,7 @@ class ProtectOperation(protection_plugin.Operation):
}
snapshot_name = parameters.get('snapshot_name', None)
description = parameters.get('description', None)
force = parameters.get('force', False)
force = False if parameters.get('force', 'False') == 'False' else True
try:
snapshot_id = self._create_snapshot(manila_client, share_id,
snapshot_name,

2
karbor/services/protection/protection_plugins/volume/cinder_protection_plugin.py
View File

@ -202,7 +202,7 @@ class ProtectOperation(protection_plugin.Operation):
description = parameters.get('description', None)
backup_mode = parameters.get('backup_mode', "full")
container = parameters.get('container', None)
force = parameters.get('force', False)
force = False if parameters.get('force', 'False') == 'False' else True
incremental = False
if backup_mode == "incremental":
incremental = True

2
karbor/services/protection/protection_plugins/volume/volume_snapshot_plugin.py
View File

@ -136,7 +136,7 @@ class ProtectOperation(protection_plugin.Operation):
}
snapshot_name = parameters.get('snapshot_name', None)
description = parameters.get('description', None)
force = parameters.get('force', False)
force = False if parameters.get('force', 'False') == 'False' else True
try:
snapshot_id = self._create_snapshot(cinder_client, volume_id,
snapshot_name,