openstack
/
karbor
Code Issues Proposed changes

Update patch set 9 

Patch Set 9:

(16 comments)

Patch-set: 9
Label: Verified=0
This commit is contained in:
Gerrit User 16203 2015-11-17 03:20:24 +00:00 committed by Gerrit Code Review
parent cbf40bfd75
commit a1c0db75ae
1 changed files with 272 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

272
b6a0fca796f9f24e9e23f4ace97442f856e354bb
View File

@ -1,5 +1,39 @@
{
"comments": [
{
"key": {
"uuid": "ba8a016a_5ea18f93",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 9
},
"lineNbr": 60,
"author": {
"id": 16203
},
"writtenOn": "2015-11-17T03:20:24Z",
"side": 1,
"message": "Lack a tenant_id",
"revId": "b6a0fca796f9f24e9e23f4ace97442f856e354bb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_613f16b5",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 9
},
"lineNbr": 114,
"author": {
"id": 16203
},
"writtenOn": "2015-11-17T03:20:24Z",
"side": 1,
"message": "This API only creates one protection definition.\nNo need to return as a list.",
"revId": "b6a0fca796f9f24e9e23f4ace97442f856e354bb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_e898e96c",
@ -84,6 +118,244 @@
"revId": "b6a0fca796f9f24e9e23f4ace97442f856e354bb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_61c2b687",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 9
},
"lineNbr": 213,
"author": {
"id": 16203
},
"writtenOn": "2015-11-17T03:20:24Z",
"side": 1,
"message": "The format of this response example seems a little confusing.",
"revId": "b6a0fca796f9f24e9e23f4ace97442f856e354bb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_c4637019",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 9
},
"lineNbr": 271,
"author": {
"id": 16203
},
"writtenOn": "2015-11-17T03:20:24Z",
"side": 1,
"message": "Should contain the plan_id.",
"revId": "b6a0fca796f9f24e9e23f4ace97442f856e354bb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_04309800",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 9
},
"lineNbr": 291,
"author": {
"id": 16203
},
"writtenOn": "2015-11-17T03:20:24Z",
"side": 1,
"message": "No parameter above for name.",
"revId": "b6a0fca796f9f24e9e23f4ace97442f856e354bb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_a4174c50",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 9
},
"lineNbr": 293,
"author": {
"id": 16203
},
"writtenOn": "2015-11-17T03:20:24Z",
"side": 1,
"message": "plan-id -\u003e plan_id",
"revId": "b6a0fca796f9f24e9e23f4ace97442f856e354bb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_a440ac57",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 9
},
"lineNbr": 294,
"author": {
"id": 16203
},
"writtenOn": "2015-11-17T03:20:24Z",
"side": 1,
"message": "No parameter above for comments.",
"revId": "b6a0fca796f9f24e9e23f4ace97442f856e354bb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_c72612ba",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 9
},
"lineNbr": 295,
"author": {
"id": 16203
},
"writtenOn": "2015-11-17T03:20:24Z",
"side": 1,
"message": "Should contain operation_type.",
"revId": "b6a0fca796f9f24e9e23f4ace97442f856e354bb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_27535ee3",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 9
},
"lineNbr": 311,
"author": {
"id": 16203
},
"writtenOn": "2015-11-17T03:20:24Z",
"side": 1,
"message": "Suggest to add a filter by trigger_id as well.",
"revId": "b6a0fca796f9f24e9e23f4ace97442f856e354bb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_c7d05256",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 9
},
"lineNbr": 318,
"author": {
"id": 16203
},
"writtenOn": "2015-11-17T03:20:24Z",
"side": 1,
"message": "schedule -\u003e schedules",
"revId": "b6a0fca796f9f24e9e23f4ace97442f856e354bb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_e787965f",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 9
},
"lineNbr": 322,
"author": {
"id": 16203
},
"writtenOn": "2015-11-17T03:20:24Z",
"side": 1,
"message": "plan-id -\u003e plan_id",
"revId": "b6a0fca796f9f24e9e23f4ace97442f856e354bb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_27327ef2",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 9
},
"lineNbr": 324,
"author": {
"id": 16203
},
"writtenOn": "2015-11-17T03:20:24Z",
"side": 1,
"message": "Should contain operation_type.",
"revId": "b6a0fca796f9f24e9e23f4ace97442f856e354bb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_e7d8f655",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 9
},
"lineNbr": 342,
"author": {
"id": 16203
},
"writtenOn": "2015-11-17T03:20:24Z",
"side": 1,
"message": "Should be \u0027name of the trigger\u0027",
"revId": "b6a0fca796f9f24e9e23f4ace97442f856e354bb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_c7ba92e1",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 9
},
"lineNbr": 343,
"author": {
"id": 16203
},
"writtenOn": "2015-11-17T03:20:24Z",
"side": 1,
"message": "The same as above.",
"revId": "b6a0fca796f9f24e9e23f4ace97442f856e354bb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_a7118eae",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 9
},
"lineNbr": 346,
"author": {
"id": 16203
},
"writtenOn": "2015-11-17T03:20:24Z",
"side": 1,
"message": "I think we could encounter the scenario that one resource\u0027s protection action depends on the finish event of another resource\u0027s proteciton action.\nSo maybe we need an event trigger type.",
"revId": "b6a0fca796f9f24e9e23f4ace97442f856e354bb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_87124a61",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 9
},
"lineNbr": 374,
"author": {
"id": 16203
},
"writtenOn": "2015-11-17T03:20:24Z",
"side": 1,
"message": "plan_id and bank_id doesn\u0027t need to specify together,\nbecause a plan only has one corresponding bank.\nSo maybe plan_id is optional.",
"revId": "b6a0fca796f9f24e9e23f4ace97442f856e354bb",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}