Update patch set 18

Patch Set 18: Code-Review-1

(2 comments)

Same comment on bank.md from patch17 to patch18, pls.take a look at it.

Patch-set: 18
Label: Code-Review=-1
This commit is contained in:
Gerrit User 19346 2015-12-23 01:49:54 +00:00 committed by Gerrit Code Review
parent 54304d1245
commit ac9b36783e
1 changed files with 38 additions and 0 deletions

View File

@ -0,0 +1,38 @@
{
"comments": [
{
"key": {
"uuid": "1a7b0d38_66098195",
"filename": "doc/source/api/bank.md",
"patchSetId": 18
},
"lineNbr": 44,
"author": {
"id": 19346
},
"writtenOn": "2015-12-23T01:49:54Z",
"side": 1,
"message": "Protection_definition has been replaced by Protectable, need update here?",
"revId": "d192b3e1a8b323e22f379c90c7f6052747d2c273",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a7b0d38_661741a4",
"filename": "doc/source/api/bank.md",
"patchSetId": 18
},
"lineNbr": 51,
"author": {
"id": 19346
},
"writtenOn": "2015-12-23T01:49:54Z",
"side": 1,
"message": "Not sure if I got the point to backup the dependency into bank. \nJust a generic question: shall we have another two protectable type:\n1.volume_attachment to describe the information which volume attached to which vm with which device path;\n2.network_attachment to describe which network the vm attached to with which ip which network interface;\nWe need this information to re-organize those resource we restored, otherwise user has no way to assemble all parts together. And HEAT also uses attachment to orchestrate the stack building work.",
"revId": "d192b3e1a8b323e22f379c90c7f6052747d2c273",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}