From b68009787a77da17286f3f6093a9aa9e0ce5771b Mon Sep 17 00:00:00 2001 From: liushuai Date: Mon, 1 Apr 2019 15:41:30 +0800 Subject: [PATCH] fix check parameters error Closes-Bug #1822537 Change-Id: I2955a83b8c9e525b810aa5f17f9ee0f677d9bcec --- karbor/api/v1/plans.py | 2 +- karbor/tests/unit/api/v1/test_plans.py | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/karbor/api/v1/plans.py b/karbor/api/v1/plans.py index e6b5152a..24304b83 100644 --- a/karbor/api/v1/plans.py +++ b/karbor/api/v1/plans.py @@ -308,7 +308,7 @@ class PlansController(wsgi.Controller): for key in valid_update_keys.intersection(plan): update_dict[key] = plan[key] - if update_dict is None: + if not update_dict: msg = _("Missing updated parameters in request body.") raise exc.HTTPBadRequest(explanation=msg) diff --git a/karbor/tests/unit/api/v1/test_plans.py b/karbor/tests/unit/api/v1/test_plans.py index 0b5f5272..3867dd1a 100644 --- a/karbor/tests/unit/api/v1/test_plans.py +++ b/karbor/tests/unit/api/v1/test_plans.py @@ -126,6 +126,10 @@ class PlanApiTest(base.TestCase): self.assertRaises( exception.ValidationError, self.controller.update, req, "2a9ce1f3-cc1a-4516-9435-0ebb13caa398", body=body) + body = {"plan": {}} + self.assertRaises( + exc.HTTPBadRequest, self.controller.update, + req, "2a9ce1f3-cc1a-4516-9435-0ebb13caa398", body=body) def test_plan_update_InvalidId(self): plan = self._plan_update_request_body()