From e482ebe18c13e6cb0eafbda0a563aed0512ae705 Mon Sep 17 00:00:00 2001
From: helei <helei@cmss.chinamobile.com>
Date: Thu, 14 Nov 2019 12:29:34 +0800
Subject: [PATCH] Add unit test for services api

Change-Id: I0a4cec43c76d64191c5e962674ba31b5d6a834a3
Signed-off-by: helei <helei@cmss.chinamobile.com>
---
 karbor/tests/unit/api/v1/test_services.py | 54 +++++++++++++++++++++++
 1 file changed, 54 insertions(+)

diff --git a/karbor/tests/unit/api/v1/test_services.py b/karbor/tests/unit/api/v1/test_services.py
index 1873b9ef..91b952f1 100644
--- a/karbor/tests/unit/api/v1/test_services.py
+++ b/karbor/tests/unit/api/v1/test_services.py
@@ -93,3 +93,57 @@ class ServiceApiTest(base.TestCase):
             "fake_id",
             body
         )
+
+    @mock.patch('karbor.objects.service.Service.get_by_id')
+    def test_service_update_with_service_not_found(self,
+                                                   mock_get_by_id):
+        body = {
+            "status": 'disabled',
+            'disabled_reason': 'reason'
+        }
+        req = fakes.HTTPRequest.blank('/v1/os-services/1',
+                                      use_admin_context=True)
+        mock_get_by_id.side_effect = exception.ServiceNotFound
+        self.assertRaises(
+            exc.HTTPNotFound,
+            self.controller.update,
+            req,
+            "fake_id",
+            body
+        )
+
+    @mock.patch('karbor.objects.service.Service.get_by_id')
+    def test_service_update_with_invalid_disabled_reason(self, mock_get_by_id):
+        req = fakes.HTTPRequest.blank('/v1/os-services/1',
+                                      use_admin_context=True)
+        body = {
+            "status": 'enabled',
+            'disabled_reason': 'reason'
+        }
+        mock_service = mock.MagicMock(
+            binary='karbor-operationengine', save=mock.MagicMock())
+        mock_get_by_id.return_value = mock_service
+        self.assertRaises(
+            exc.HTTPBadRequest,
+            self.controller.update,
+            req,
+            "fake_id",
+            body
+        )
+
+    @mock.patch('karbor.utils.service_is_up')
+    @mock.patch('karbor.objects.service.Service.get_by_id')
+    def test_service_update_with_enabled_status(
+            self, mock_get_by_id, mock_service_is_up):
+        req = fakes.HTTPRequest.blank('/v1/os-services/1',
+                                      use_admin_context=True)
+        body = {
+            "status": 'enabled'
+        }
+        mock_service = mock.MagicMock(
+            binary='karbor-operationengine', save=mock.MagicMock())
+        mock_get_by_id.return_value = mock_service
+        mock_service_is_up.return_value = True
+        self.controller.update(req, "fake_id", body)
+        self.assertTrue(mock_get_by_id.called)
+        self.assertTrue(mock_service.save.called)