openstack/karbor
Code Issues Proposed changes

Update patch set 20

Browse Source 
Patch Set 20:

(4 comments)

Patch-set: 20
This commit is contained in:
Gerrit User 15069 2015-12-29 10:35:56 +00:00 committed by Gerrit Code Review
parent 8159050946
commit f342e463af
1 changed files with 90 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

90
088ba3ef967b5635793b004c3094e08a6cf9b223
View File

@ -47,6 +47,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a7b0d38_2d4c20c7",
"filename": "doc/source/api/api_examples.md",
"patchSetId": 20
},
"lineNbr": 62,
"author": {
"id": 15069
},
"writtenOn": "2015-12-29T10:35:56Z",
"side": 1,
"message": "i think here is to list all the checkpoints not providers,do you mean only admin can use this API?",
"parentUuid": "1a7b0d38_b7c7ff96",
"range": {
"startLine": 62,
"startChar": 16,
"endLine": 62,
"endChar": 25
},
"revId": "088ba3ef967b5635793b004c3094e08a6cf9b223",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a7b0d38_6b6f782b",
@ -82,6 +106,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a7b0d38_0dce042e",
"filename": "doc/source/api/api_examples.md",
"patchSetId": 20
},
"lineNbr": 165,
"author": {
"id": 15069
},
"writtenOn": "2015-12-29T10:35:56Z",
"side": 1,
"message": "ok, but it seems that Cinder still uses the \u0027tenant_id\u0027,how do think about the integration with Cinder?",
"parentUuid": "1a7b0d38_17f5b355",
"revId": "088ba3ef967b5635793b004c3094e08a6cf9b223",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a7b0d38_2bfad043",
@ -223,6 +265,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a7b0d38_8d943443",
"filename": "doc/source/api/class_diagram.pu",
"patchSetId": 20
},
"lineNbr": 48,
"author": {
"id": 15069
},
"writtenOn": "2015-12-29T10:35:56Z",
"side": 1,
"message": "i do not think i completely understand what\u0027s the responsibility of this class",
"parentUuid": "1a7b0d38_92121156",
"range": {
"startLine": 48,
"startChar": 6,
"endLine": 48,
"endChar": 19
},
"revId": "088ba3ef967b5635793b004c3094e08a6cf9b223",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a7b0d38_5ed35804",
@ -410,6 +476,30 @@
"revId": "088ba3ef967b5635793b004c3094e08a6cf9b223",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "1a7b0d38_4d508cd4",
"filename": "doc/source/api/class_diagram.pu",
"patchSetId": 20
},
"lineNbr": 105,
"author": {
"id": 15069
},
"writtenOn": "2015-12-29T10:35:56Z",
"side": 1,
"message": "agree",
"parentUuid": "1a7b0d38_d237394b",
"range": {
"startLine": 105,
"startChar": 4,
"endLine": 105,
"endChar": 12
},
"revId": "088ba3ef967b5635793b004c3094e08a6cf9b223",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}