openstack
/
karbor
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(8 comments)

Patch-set: 5
Label: Verified=0
This commit is contained in:
Gerrit User 16203 2015-11-13 09:58:49 +00:00 committed by Gerrit Code Review
parent 6fa18b2629
commit f34c7f3287
1 changed files with 140 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

140
156d8c747caa3914c1c6228591c1cc7618c4e657 Normal file
View File

@ -0,0 +1,140 @@
{
"comments": [
{
"key": {
"uuid": "da85f559_215cc3ec",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 5
},
"lineNbr": 7,
"author": {
"id": 16203
},
"writtenOn": "2015-11-13T09:58:49Z",
"side": 1,
"message": "Why?",
"revId": "156d8c747caa3914c1c6228591c1cc7618c4e657",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da85f559_01409f06",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 5
},
"lineNbr": 17,
"author": {
"id": 16203
},
"writtenOn": "2015-11-13T09:58:49Z",
"side": 1,
"message": "Didn\u0027t see where to specify protection defintions.",
"revId": "156d8c747caa3914c1c6228591c1cc7618c4e657",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da85f559_e8ac6037",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 5
},
"lineNbr": 22,
"author": {
"id": 16203
},
"writtenOn": "2015-11-13T09:58:49Z",
"side": 1,
"message": "This API only support create one plan at a time.\nSo is it necessary to return plan info within a list?",
"revId": "156d8c747caa3914c1c6228591c1cc7618c4e657",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da85f559_81f00fcb",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 5
},
"lineNbr": 79,
"author": {
"id": 16203
},
"writtenOn": "2015-11-13T09:58:49Z",
"side": 1,
"message": "plan-\u003edefinition",
"revId": "156d8c747caa3914c1c6228591c1cc7618c4e657",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da85f559_c1cdb787",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 5
},
"lineNbr": 80,
"author": {
"id": 16203
},
"writtenOn": "2015-11-13T09:58:49Z",
"side": 1,
"message": "plan-\u003edefinition",
"revId": "156d8c747caa3914c1c6228591c1cc7618c4e657",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da85f559_61088b92",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 5
},
"lineNbr": 81,
"author": {
"id": 16203
},
"writtenOn": "2015-11-13T09:58:49Z",
"side": 1,
"message": "Why resource type is dict?",
"revId": "156d8c747caa3914c1c6228591c1cc7618c4e657",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da85f559_fcb2e205",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 5
},
"lineNbr": 153,
"author": {
"id": 16203
},
"writtenOn": "2015-11-13T09:58:49Z",
"side": 1,
"message": "\u0026lt;key\u0026gt;[:\u0026lt;direction\u0026gt;] -\u003e \u003ckey\u003e[:\u003cdirection\u003e]",
"revId": "156d8c747caa3914c1c6228591c1cc7618c4e657",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "da85f559_1cd566b8",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 5
},
"lineNbr": 177,
"author": {
"id": 16203
},
"writtenOn": "2015-11-13T09:58:49Z",
"side": 1,
"message": "Didn\u0027t understand why user need to know what bank plugins available. The api \"List available banks\" below isn\u0027t enough?",
"revId": "156d8c747caa3914c1c6228591c1cc7618c4e657",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}