openstack
/
karbor
Code Issues Proposed changes

Use proper assert check 

This patch includes changes:
  1. use assertTrue instead of assertEqual(True, ...)
  2. use assertIn instead of assertEqual(True, a in b)

Change-Id: Icb97be90d3f4da89e2b7091de1acf809947b343e
This commit is contained in:
Jeremy Liu 2016-11-25 15:51:14 +08:00
parent 1b0e8778d7
commit f918159979
5 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
karbor/tests/unit/db/test_models.py
View File

@ -200,7 +200,7 @@ class ScheduledOperationTestCase(base.TestCase):
def test_scheduled_operation_create(self):
operation_ref = self._create_scheduled_operation()
self.assertEqual('protect', operation_ref['operation_type'])
self.assertEqual(True, operation_ref['enabled'])
self.assertTrue(operation_ref['enabled'])
def test_scheduled_operation_delete(self):
operation_ref = self._create_scheduled_operation()

2
karbor/tests/unit/protection/test_checkpoint.py
View File

@ -91,4 +91,4 @@ class CheckpointTest(base.TestCase):
)
self.assertEqual(len(resource_graph), len(cp.resource_graph))
for start_node in resource_graph:
self.assertEqual(True, start_node in cp.resource_graph)
self.assertIn(start_node, cp.resource_graph)

2
karbor/tests/unit/protection/test_graph.py
View File

@ -176,7 +176,7 @@ class GraphBuilderTest(base.TestCase):
unpacked_graph = graph.unpack_graph(packed_graph)
self.assertEqual(len(test_graph), len(unpacked_graph))
for start_node in test_graph:
self.assertEqual(True, start_node in unpacked_graph)
self.assertIn(start_node, unpacked_graph)
class _TestGraphWalkerListener(graph.GraphWalkerListener):

2
karbor/tests/unit/protection/test_resource_graph.py
View File

@ -68,4 +68,4 @@ class SerializeResourceGraphTest(base.TestCase):
serialized_resource_graph)
self.assertEqual(len(resource_graph), len(deserialized_resource_graph))
for start_node in resource_graph:
self.assertEqual(True, start_node in deserialized_resource_graph)
self.assertIn(start_node, deserialized_resource_graph)

4
karbor/tests/unit/test_context.py
View File

@ -20,13 +20,13 @@ class ContextTestCase(base.TestCase):
ctxt = context.RequestContext('111',
'222',
roles=['admin', 'weasel'])
self.assertEqual(True, ctxt.is_admin)
self.assertTrue(ctxt.is_admin)
def test_request_context_sets_is_admin_upcase(self):
ctxt = context.RequestContext('111',
'222',
roles=['Admin', 'weasel'])
self.assertEqual(True, ctxt.is_admin)
self.assertTrue(ctxt.is_admin)
def test_request_context_read_deleted(self):
ctxt = context.RequestContext('111',