openstack/karbor
Code Issues Proposed changes

Update patch set 14

Browse Source 
Patch Set 14:

(5 comments)

Patch-set: 14
This commit is contained in:
Gerrit User 13070 2015-12-18 14:02:11 +00:00 committed by Gerrit Code Review
parent 715324eebc
commit ffac7acb11
1 changed files with 90 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

90
48826446cd8e40c616b0851e7540c5caa677405c
View File

@ -17,6 +17,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false "unresolved": false
}, },
{
"key": {
"uuid": "3a7e1126_65beec66",
"filename": "doc/source/api/bank.md",
"patchSetId": 14
},
"lineNbr": 14,
"author": {
"id": 13070
},
"writtenOn": "2015-12-18T14:02:11Z",
"side": 1,
"message": "Done",
"parentUuid": "7a740942_187491cd",
"revId": "48826446cd8e40c616b0851e7540c5caa677405c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{ {
"key": { "key": {
"uuid": "7a740942_db19237b", "uuid": "7a740942_db19237b",
@ -34,6 +52,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false "unresolved": false
}, },
{
"key": {
"uuid": "3a7e1126_f0fa9874",
"filename": "doc/source/api/bank.md",
"patchSetId": 14
},
"lineNbr": 30,
"author": {
"id": 13070
},
"writtenOn": "2015-12-18T14:02:11Z",
"side": 1,
"message": "Yes thanks you are right we should add the time zone info\n\n do you mean ISO 8601?\n\nWe could use 8601 or RFC 2822 time \n\nI will fix it at the moment to ISO 8601 UTC --\n 2015-12-18T13:41:02Z",
"parentUuid": "7a740942_db19237b",
"revId": "48826446cd8e40c616b0851e7540c5caa677405c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{ {
"key": { "key": {
"uuid": "7a740942_bbb8d72b", "uuid": "7a740942_bbb8d72b",
@ -51,6 +87,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false "unresolved": false
}, },
{
"key": {
"uuid": "3a7e1126_10dba4ed",
"filename": "doc/source/api/bank.md",
"patchSetId": 14
},
"lineNbr": 31,
"author": {
"id": 13070
},
"writtenOn": "2015-12-18T14:02:11Z",
"side": 1,
"message": "Done",
"parentUuid": "7a740942_bbb8d72b",
"revId": "48826446cd8e40c616b0851e7540c5caa677405c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{ {
"key": { "key": {
"uuid": "7a740942_004968d0", "uuid": "7a740942_004968d0",
@ -68,6 +122,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false "unresolved": false
}, },
{
"key": {
"uuid": "3a7e1126_30b4a080",
"filename": "doc/source/api/bank.md",
"patchSetId": 14
},
"lineNbr": 59,
"author": {
"id": 13070
},
"writtenOn": "2015-12-18T14:02:11Z",
"side": 1,
"message": "You are right it is missing we will add that",
"parentUuid": "7a740942_004968d0",
"revId": "48826446cd8e40c616b0851e7540c5caa677405c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{ {
"key": { "key": {
"uuid": "7a740942_f34b5b85", "uuid": "7a740942_f34b5b85",
@ -121,6 +193,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false "unresolved": false
}, },
{
"key": {
"uuid": "3a7e1126_4b23c1a7",
"filename": "doc/source/api/bank.md",
"patchSetId": 14
},
"lineNbr": 64,
"author": {
"id": 13070
},
"writtenOn": "2015-12-18T14:02:11Z",
"side": 1,
"message": "Lets discuss this in the next IRC ,meeting I will add this to the agenda",
"parentUuid": "7a740942_8a024e6e",
"revId": "48826446cd8e40c616b0851e7540c5caa677405c",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{ {
"key": { "key": {
"uuid": "7a740942_18896675", "uuid": "7a740942_18896675",