openstack/karbor
Code Issues Proposed changes
ffac7acb11
karbor/e6a2a4513fa76b094ba61849a20e41a92dbb50a5
Gerrit User 16983 1345efcb5e Update patch set 11 
Patch Set 11:

(2 comments)

Patch-set: 11
Label: Verified=0
2015-11-23 12:47:22 +00:00

418 lines
13 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"key": {
"uuid": "ba8a016a_a8e564a4",
"filename": "doc/source/api/bank.md",
"patchSetId": 11
},
"lineNbr": 32,
"author": {
"id": 16203
},
"writtenOn": "2015-11-19T03:41:21Z",
"side": 1,
"message": "Including the operation action info may be better.",
"revId": "e6a2a4513fa76b094ba61849a20e41a92dbb50a5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_8e498962",
"filename": "doc/source/api/bank.md",
"patchSetId": 11
},
"lineNbr": 44,
"author": {
"id": 16203
},
"writtenOn": "2015-11-19T03:41:21Z",
"side": 1,
"message": "The example content below seems to only have static info, such as dependencies, nothing to do with the transaction.\nThen why need a transaction_id in the path?",
"revId": "e6a2a4513fa76b094ba61849a20e41a92dbb50a5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_177996fc",
"filename": "doc/source/api/bank.md",
"patchSetId": 11
},
"lineNbr": 44,
"author": {
"id": 2023
},
"writtenOn": "2015-11-23T11:48:52Z",
"side": 1,
"message": "It\u0027s not static. The \u003cother_protection_definition_id\u003e is specific to the transaction. Also the dependencies might have changed on the original resource since the transaction was created.",
"parentUuid": "ba8a016a_8e498962",
"revId": "e6a2a4513fa76b094ba61849a20e41a92dbb50a5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_2e85fd05",
"filename": "doc/source/api/bank.md",
"patchSetId": 11
},
"lineNbr": 126,
"author": {
"id": 16203
},
"writtenOn": "2015-11-19T03:41:21Z",
"side": 1,
"message": "This step seems duplicated, cause step 5 below describes the same functionality.",
"revId": "e6a2a4513fa76b094ba61849a20e41a92dbb50a5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_bcc9917b",
"filename": "doc/source/api/bank.md",
"patchSetId": 11
},
"lineNbr": 126,
"author": {
"id": 2023
},
"writtenOn": "2015-11-23T11:48:52Z",
"side": 1,
"message": "Maybe there is a better way to express that but 4 is when you start remove indexes. Step 5 is an example. calling it step 4.1. might have been clearer. I\u0027ll change that.",
"parentUuid": "ba8a016a_2e85fd05",
"revId": "e6a2a4513fa76b094ba61849a20e41a92dbb50a5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_d143b040",
"filename": "doc/source/api/class_diagram.pu",
"patchSetId": 11
},
"lineNbr": 12,
"author": {
"id": 16203
},
"writtenOn": "2015-11-19T03:41:21Z",
"side": 1,
"message": "Should contain \u0027ID: UUID\u0027 as well.",
"revId": "e6a2a4513fa76b094ba61849a20e41a92dbb50a5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_2e389d3c",
"filename": "doc/source/api/class_diagram.pu",
"patchSetId": 11
},
"lineNbr": 15,
"author": {
"id": 16203
},
"writtenOn": "2015-11-19T03:41:21Z",
"side": 1,
"message": "The BankInfo is an API entity of Bank interface, shouldn\u0027t there be an interface object in this class definition? Like \u0027interface: Bank\u0027 or something?",
"revId": "e6a2a4513fa76b094ba61849a20e41a92dbb50a5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_37bffa61",
"filename": "doc/source/api/class_diagram.pu",
"patchSetId": 11
},
"lineNbr": 15,
"author": {
"id": 2023
},
"writtenOn": "2015-11-23T11:48:52Z",
"side": 1,
"message": "Not exactly, the API doesn\u0027t expose the Bank interface.\nWe use the BankInfo to initialize a new Bank instance internally.",
"parentUuid": "ba8a016a_2e389d3c",
"revId": "e6a2a4513fa76b094ba61849a20e41a92dbb50a5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_6e67854d",
"filename": "doc/source/api/class_diagram.pu",
"patchSetId": 11
},
"lineNbr": 35,
"author": {
"id": 16203
},
"writtenOn": "2015-11-19T03:41:21Z",
"side": 1,
"message": "Maybe should contain action type as well.",
"revId": "e6a2a4513fa76b094ba61849a20e41a92dbb50a5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_5e63b241",
"filename": "doc/source/api/class_diagram.pu",
"patchSetId": 11
},
"lineNbr": 35,
"author": {
"id": 16983
},
"writtenOn": "2015-11-23T12:47:22Z",
"side": 1,
"message": "what is meant by \"action type\"?\nthis is a Trigger class... it is decoupled from the action(s) that run when it triggers the scheduler",
"parentUuid": "ba8a016a_6e67854d",
"revId": "e6a2a4513fa76b094ba61849a20e41a92dbb50a5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_7a6d5f98",
"filename": "doc/source/api/class_diagram.pu",
"patchSetId": 11
},
"lineNbr": 48,
"author": {
"id": 16983
},
"writtenOn": "2015-11-23T12:47:22Z",
"side": 1,
"message": "SubVault is not such a good name for this.\nI suggest to call it a \"Compartment\" or \"Locker\" or \"Pocket\" or \"Parcel\"",
"revId": "e6a2a4513fa76b094ba61849a20e41a92dbb50a5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_2ea2dd4b",
"filename": "doc/source/api/class_diagram.pu",
"patchSetId": 11
},
"lineNbr": 59,
"author": {
"id": 16203
},
"writtenOn": "2015-11-19T03:41:21Z",
"side": 1,
"message": "Shouldn\u0027t the return value definition be the form Resource[]?",
"revId": "e6a2a4513fa76b094ba61849a20e41a92dbb50a5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_43e99d19",
"filename": "doc/source/api/class_diagram.pu",
"patchSetId": 11
},
"lineNbr": 59,
"author": {
"id": 2023
},
"writtenOn": "2015-11-23T11:48:52Z",
"side": 1,
"message": "No, it\u0027s a map between a key and a resource.\n\nEg.\n\n {\n \"vol1\": {id\u003d11, type\u003d\"OS::Cinder::Volume\"},\n \"vol2\": {id\u003d11, type\u003d\"OS::Cinder::Volume\"}\n }",
"parentUuid": "ba8a016a_2ea2dd4b",
"revId": "e6a2a4513fa76b094ba61849a20e41a92dbb50a5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_8e042918",
"filename": "doc/source/api/class_diagram.pu",
"patchSetId": 11
},
"lineNbr": 60,
"author": {
"id": 16203
},
"writtenOn": "2015-11-19T03:41:21Z",
"side": 1,
"message": "Why the parameter is SubVault? ProtectionPlugin seems not related to Bank.",
"revId": "e6a2a4513fa76b094ba61849a20e41a92dbb50a5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_836c659d",
"filename": "doc/source/api/class_diagram.pu",
"patchSetId": 11
},
"lineNbr": 60,
"author": {
"id": 2023
},
"writtenOn": "2015-11-23T11:48:52Z",
"side": 1,
"message": "A plugin get\u0027s as an input it\u0027s own section in the bank (SubVault), Reads it and returns a value corresponding to the extenden_info_schema.",
"parentUuid": "ba8a016a_8e042918",
"revId": "e6a2a4513fa76b094ba61849a20e41a92dbb50a5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_b12f0c87",
"filename": "doc/source/api/class_diagram.pu",
"patchSetId": 11
},
"lineNbr": 95,
"author": {
"id": 16203
},
"writtenOn": "2015-11-19T03:41:21Z",
"side": 1,
"message": "Should contain \u0027ID: UUID\u0027 as well.",
"revId": "e6a2a4513fa76b094ba61849a20e41a92dbb50a5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_f1127456",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 11
},
"lineNbr": 110,
"author": {
"id": 18266
},
"writtenOn": "2015-11-19T07:07:48Z",
"side": 1,
"message": "Is resource_id more explicit?",
"revId": "e6a2a4513fa76b094ba61849a20e41a92dbb50a5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_ed9cdec1",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 11
},
"lineNbr": 244,
"author": {
"id": 18266
},
"writtenOn": "2015-11-19T01:40:26Z",
"side": 1,
"message": "parameter miss plugin_id?",
"revId": "e6a2a4513fa76b094ba61849a20e41a92dbb50a5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_02100858",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 11
},
"lineNbr": 306,
"author": {
"id": 18266
},
"writtenOn": "2015-11-19T07:07:48Z",
"side": 1,
"message": "Is bank_plugin_id more explicit?",
"revId": "e6a2a4513fa76b094ba61849a20e41a92dbb50a5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_22474c78",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 11
},
"lineNbr": 311,
"author": {
"id": 18266
},
"writtenOn": "2015-11-19T07:07:48Z",
"side": 1,
"message": "Is bank_plugin_id more explicit?\nDescription should be \"Id of the bank plugin\".",
"revId": "e6a2a4513fa76b094ba61849a20e41a92dbb50a5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_3debed14",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 11
},
"lineNbr": 355,
"author": {
"id": 18266
},
"writtenOn": "2015-11-19T07:07:48Z",
"side": 1,
"message": "Is bank_plugin_id more explicit?",
"revId": "e6a2a4513fa76b094ba61849a20e41a92dbb50a5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_1d12a909",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 11
},
"lineNbr": 374,
"author": {
"id": 18266
},
"writtenOn": "2015-11-19T07:07:48Z",
"side": 1,
"message": "Is more explicit by changing \"for this bank instance\" to \"to create this bank instance\"?",
"revId": "e6a2a4513fa76b094ba61849a20e41a92dbb50a5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_5d9cb10e",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 11
},
"lineNbr": 452,
"author": {
"id": 18266
},
"writtenOn": "2015-11-19T07:07:48Z",
"side": 1,
"message": "Is \"Create scheduled operation\" more explicit?",
"revId": "e6a2a4513fa76b094ba61849a20e41a92dbb50a5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "ba8a016a_ed75be97",
"filename": "doc/source/api/smaug_api.v1.md",
"patchSetId": 11
},
"lineNbr": 593,
"author": {
"id": 18266
},
"writtenOn": "2015-11-19T01:40:26Z",
"side": 1,
"message": "description is not corresponding to the bank_id, but to the tenant_id",
"revId": "e6a2a4513fa76b094ba61849a20e41a92dbb50a5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}
View Git Blame Copy Permalink