openstack/kayobe
Code Issues Proposed changes

Fix passwords.yml generation when parent directory doesn't exist

Browse Source 
Fixes an issue where generation of passwords.yml for Kolla Ansible
could fail if the directory containing the file does not exist. This is
typical in a multiple environment setup, when creating a new
environment.

Story: 2010293
Task: 46275
Closes-Bug: #2015093
Change-Id: I9dce73a8a205c0c0ad02eba3a10e02b82f5b191d
This commit is contained in:
Mark Goddard 2022-08-23 16:46:29 +01:00 committed by Maksim Malchuk
parent a2f9801034
commit 5287083116
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
ansible/roles/kolla-ansible/library/kolla_passwords.py
View File

@ -22,6 +22,7 @@ short_description: Generates a kolla-ansible passwords file
from ansible.module_utils.basic import * from ansible.module_utils.basic import *
import os
import os.path import os.path
import shutil import shutil
import tempfile import tempfile
@ -154,6 +155,8 @@ def kolla_passwords(module):
checksum_temp_file = module.sha1(temp_file_path) checksum_temp_file = module.sha1(temp_file_path)
changed = checksum_dest != checksum_temp_file changed = checksum_dest != checksum_temp_file
else: else:
os.makedirs(os.path.dirname(module.params['dest']),
exist_ok=True)
changed = True changed = True
# Encrypt the file. # Encrypt the file.

8
releasenotes/notes/fix-kolla-passwords-f1b5d051c494b4d8.yaml Normal file
View File

@ -0,0 +1,8 @@
---
fixes:
- |
Fixes an issue where generation of ``passwords.yml`` for Kolla Ansible
could fail if the directory containing the file does not exist. This is
typical in a multiple environment setup, when creating a new environment.
See `story 2010293 <https://storyboard.openstack.org/#!/story/2010293>`_
for details.