openstack/kayobe
Code Issues Proposed changes

Fix --check argument for overcloud host configure

Browse Source 
When running 'kayobe overcloud host configure', there are some tasks
that we need to run even in check mode, to ensure that subsequent tasks
can execute. These tasks should not change the target systems.

Change-Id: Id912ccd7c4bf2a4ccff8d16f2a9aa6ed2127a335
Story: 2004798
Task: 28951
This commit is contained in:
Mark Goddard 2021-07-08 11:08:36 +01:00
parent e9a3733e24
commit 533e9ca912
3 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ansible/kayobe-ansible-user.yml
View File

@ -17,6 +17,7 @@
module: command ssh -o BatchMode=yes -p {{ ssh_port }} {{ ssh_user }}@{{ ssh_host }} hostname module: command ssh -o BatchMode=yes -p {{ ssh_port }} {{ ssh_user }}@{{ ssh_host }} hostname
failed_when: false failed_when: false
changed_when: false changed_when: false
check_mode: no
register: ssh_result register: ssh_result
vars: vars:
ssh_user: "{{ ansible_user }}" ssh_user: "{{ ansible_user }}"

1
ansible/roles/disable-glean/tasks/main.yml
View File

@ -3,6 +3,7 @@
command: systemctl list-units glean*.service --no-legend --no-pager --state=loaded command: systemctl list-units glean*.service --no-legend --no-pager --state=loaded
register: glean_services register: glean_services
changed_when: False changed_when: False
check_mode: no
- name: Ensure Glean services are stopped and disabled - name: Ensure Glean services are stopped and disabled
service: service:

6
releasenotes/notes/fix-check-mode-c0f8e1fcb09f730b.yaml Normal file
View File

@ -0,0 +1,6 @@
---
fixes:
- |
Fixes some issues seen when using the ``--check`` argument with ``kayobe
overcloud host configure``. See `story 2004798
<https://storyboard.openstack.org/#!/story/2004798>`__.