4acbf52867
Kolla (container images) and kolla-ansible (container deployment) are separate concerns, and should be treated as such. Configuration variables have been added for kolla-ansible which were previously shared between the two projects: kolla_venv -> kolla_ansible_venv kolla_ctl_install_type -> kolla_ansible_ctl_install_type Also, we introduce specific variables for the source code repository checkout paths, which were previously both based on source_checkout_path: kolla_source_path kolla_ansible_source_path These changes help us to cleanly separate the configuration of paths on the local (Ansible control) host, from those on the managed (target) hosts. This is important because the local paths may be specific to the environment in which the user is running kayobe, but the remote paths are relatively fixed and specific to the cluster.
188 lines
7.5 KiB
Python
188 lines
7.5 KiB
Python
# Copyright (c) 2017 StackHPC Ltd.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import argparse
|
|
import os
|
|
import subprocess
|
|
import unittest
|
|
|
|
import mock
|
|
|
|
from kayobe import kolla_ansible
|
|
from kayobe import utils
|
|
from kayobe import vault
|
|
|
|
|
|
@mock.patch.object(os, "getcwd", new=lambda: "/path/to/cwd")
|
|
class TestCase(unittest.TestCase):
|
|
|
|
@mock.patch.object(utils, "run_command")
|
|
@mock.patch.object(kolla_ansible, "_validate_args")
|
|
def test_run(self, mock_validate, mock_run):
|
|
parser = argparse.ArgumentParser()
|
|
kolla_ansible.add_args(parser)
|
|
vault.add_args(parser)
|
|
parsed_args = parser.parse_args([])
|
|
kolla_ansible.run(parsed_args, "command", "overcloud")
|
|
expected_cmd = [
|
|
".", "/path/to/cwd/venvs/kolla-ansible/bin/activate", "&&",
|
|
"kolla-ansible", "command",
|
|
"--inventory", "/etc/kolla/inventory/overcloud",
|
|
]
|
|
expected_cmd = " ".join(expected_cmd)
|
|
mock_run.assert_called_once_with(expected_cmd, shell=True, quiet=False)
|
|
|
|
@mock.patch.object(utils, "run_command")
|
|
@mock.patch.object(kolla_ansible, "_validate_args")
|
|
def test_run_all_the_args(self, mock_validate, mock_run):
|
|
parser = argparse.ArgumentParser()
|
|
kolla_ansible.add_args(parser)
|
|
vault.add_args(parser)
|
|
args = [
|
|
"--kolla-config-path", "/path/to/config",
|
|
"-ke", "ev_name1=ev_value1",
|
|
"-ki", "/path/to/inventory",
|
|
"-kl", "host1:host2",
|
|
"-kt", "tag1,tag2",
|
|
]
|
|
parsed_args = parser.parse_args(args)
|
|
kolla_ansible.run(parsed_args, "command", "overcloud")
|
|
expected_cmd = [
|
|
".", "/path/to/cwd/venvs/kolla-ansible/bin/activate", "&&",
|
|
"kolla-ansible", "command",
|
|
"--inventory", "/path/to/inventory",
|
|
"--configdir", "/path/to/config",
|
|
"--passwords", "/path/to/config/passwords.yml",
|
|
"-e", "ev_name1=ev_value1",
|
|
"--limit", "host1:host2",
|
|
"--tags", "tag1,tag2",
|
|
]
|
|
expected_cmd = " ".join(expected_cmd)
|
|
mock_run.assert_called_once_with(expected_cmd, shell=True, quiet=False)
|
|
|
|
@mock.patch.object(utils, "run_command")
|
|
@mock.patch.object(kolla_ansible, "_validate_args")
|
|
def test_run_all_the_long_args(self, mock_validate, mock_run):
|
|
parser = argparse.ArgumentParser()
|
|
kolla_ansible.add_args(parser)
|
|
vault.add_args(parser)
|
|
args = [
|
|
"--ask-vault-pass",
|
|
"--kolla-config-path", "/path/to/config",
|
|
"--kolla-extra-vars", "ev_name1=ev_value1",
|
|
"--kolla-inventory", "/path/to/inventory",
|
|
"--kolla-limit", "host1:host2",
|
|
"--kolla-tags", "tag1,tag2",
|
|
]
|
|
parsed_args = parser.parse_args(args)
|
|
kolla_ansible.run(parsed_args, "command", "overcloud")
|
|
expected_cmd = [
|
|
".", "/path/to/cwd/venvs/kolla-ansible/bin/activate", "&&",
|
|
"kolla-ansible", "command",
|
|
"--inventory", "/path/to/inventory",
|
|
"--configdir", "/path/to/config",
|
|
"--passwords", "/path/to/config/passwords.yml",
|
|
"-e", "ev_name1=ev_value1",
|
|
"--limit", "host1:host2",
|
|
"--tags", "tag1,tag2",
|
|
]
|
|
expected_cmd = " ".join(expected_cmd)
|
|
mock_run.assert_called_once_with(expected_cmd, shell=True, quiet=False)
|
|
|
|
@mock.patch.object(utils, "run_command")
|
|
@mock.patch.object(kolla_ansible, "_validate_args")
|
|
def test_run_vault_password_file(self, mock_validate, mock_run):
|
|
parser = argparse.ArgumentParser()
|
|
kolla_ansible.add_args(parser)
|
|
vault.add_args(parser)
|
|
args = [
|
|
"--vault-password-file", "/path/to/vault/pw",
|
|
]
|
|
parsed_args = parser.parse_args(args)
|
|
kolla_ansible.run(parsed_args, "command", "overcloud")
|
|
expected_cmd = [
|
|
".", "/path/to/cwd/venvs/kolla-ansible/bin/activate", "&&",
|
|
"kolla-ansible", "command",
|
|
"--key", "/path/to/vault/pw",
|
|
"--inventory", "/etc/kolla/inventory/overcloud",
|
|
]
|
|
expected_cmd = " ".join(expected_cmd)
|
|
mock_run.assert_called_once_with(expected_cmd, shell=True, quiet=False)
|
|
|
|
@mock.patch.dict(os.environ, {"KAYOBE_VAULT_PASSWORD": "test-pass"})
|
|
@mock.patch.object(utils, "run_command")
|
|
@mock.patch.object(kolla_ansible, "_validate_args")
|
|
def test_run_vault_password_helper(self, mock_vars, mock_run):
|
|
mock_vars.return_value = []
|
|
parser = argparse.ArgumentParser()
|
|
mock_run.return_value = "/path/to/kayobe-vault-password-helper"
|
|
kolla_ansible.add_args(parser)
|
|
vault.add_args(parser)
|
|
mock_run.assert_called_once_with(
|
|
["which", "kayobe-vault-password-helper"], check_output=True)
|
|
mock_run.reset_mock()
|
|
parsed_args = parser.parse_args([])
|
|
kolla_ansible.run(parsed_args, "command", "overcloud")
|
|
expected_cmd = [
|
|
".", "/path/to/cwd/venvs/kolla-ansible/bin/activate", "&&",
|
|
"kolla-ansible", "command",
|
|
"--key", "/path/to/kayobe-vault-password-helper",
|
|
"--inventory", "/etc/kolla/inventory/overcloud",
|
|
]
|
|
expected_cmd = " ".join(expected_cmd)
|
|
mock_run.assert_called_once_with(expected_cmd, shell=True, quiet=False)
|
|
|
|
@mock.patch.object(utils, "run_command")
|
|
@mock.patch.object(kolla_ansible, "_validate_args")
|
|
def test_run_func_args(self, mock_validate, mock_run):
|
|
parser = argparse.ArgumentParser()
|
|
kolla_ansible.add_args(parser)
|
|
vault.add_args(parser)
|
|
args = [
|
|
"--kolla-extra-vars", "ev_name1=ev_value1",
|
|
"--kolla-tags", "tag1,tag2",
|
|
]
|
|
parsed_args = parser.parse_args(args)
|
|
kwargs = {
|
|
"extra_vars": {"ev_name2": "ev_value2"},
|
|
"tags": "tag3,tag4",
|
|
"verbose_level": 1,
|
|
"extra_args": ["--arg1", "--arg2"],
|
|
}
|
|
kolla_ansible.run(parsed_args, "command", "overcloud", **kwargs)
|
|
expected_cmd = [
|
|
".", "/path/to/cwd/venvs/kolla-ansible/bin/activate", "&&",
|
|
"kolla-ansible", "command",
|
|
"-v",
|
|
"--inventory", "/etc/kolla/inventory/overcloud",
|
|
"-e", "ev_name1=ev_value1",
|
|
"-e", "ev_name2=ev_value2",
|
|
"--tags", "tag1,tag2,tag3,tag4",
|
|
"--arg1", "--arg2",
|
|
]
|
|
expected_cmd = " ".join(expected_cmd)
|
|
mock_run.assert_called_once_with(expected_cmd, shell=True, quiet=False)
|
|
|
|
@mock.patch.object(utils, "run_command")
|
|
@mock.patch.object(kolla_ansible, "_validate_args")
|
|
def test_run_failure(self, mock_validate, mock_run):
|
|
parser = argparse.ArgumentParser()
|
|
kolla_ansible.add_args(parser)
|
|
vault.add_args(parser)
|
|
parsed_args = parser.parse_args([])
|
|
mock_run.side_effect = subprocess.CalledProcessError(1, "dummy")
|
|
self.assertRaises(SystemExit,
|
|
kolla_ansible.run, parsed_args, "command",
|
|
"overcloud")
|