f639ad0b35
By default, Ansible injects a variable for every fact, prefixed with ansible_. This can result in a large number of variables for each host, which at scale can incur a performance penalty. Ansible provides a configuration option [0] that can be set to False to prevent this injection of facts. In this case, facts should be referenced via ansible_facts.<fact>. This change updates all references to Ansible facts within Kayobe from using individual fact variables to using the items in the ansible_facts dictionary. This allows users to disable fact variable injection in their Ansible configuration, which may provide some performance improvement. This change disables fact variable injection in the ansible configuration used in CI, to catch any attempts to use the injected variables. [0] https://docs.ansible.com/ansible/latest/reference_appendices/config.html#inject-facts-as-vars Story: 2007993 Task: 42464 Depends-On: https://review.opendev.org/c/openstack/kolla-ansible/+/791276 Change-Id: I14db53ed6e57d37bbd28dd5819e432e3fe6628b2
67 lines
2.5 KiB
YAML
67 lines
2.5 KiB
YAML
---
|
|
# For some currently unknown reason, overcloud hosts end up with multiple
|
|
# entries in /etc/hosts that map their own hostname to their admin
|
|
# network IP address, in addition to one that maps their own hostname to their
|
|
# internal network IP address. This causes RabbitMQ upgrades to fail, as
|
|
# RabbitMQ expects the system's hostname to resolve to the IP address on
|
|
# which it is listening. As a workaround, we remove the stale entries from
|
|
# /etc/hosts. See https://github.com/stackhpc/kayobe/issues/14.
|
|
|
|
- name: Ensure overcloud hosts' /etc/hosts does not contain incorrect IPs
|
|
hosts: overcloud
|
|
tags:
|
|
- etc-hosts-fixup
|
|
tasks:
|
|
# Remove any entries from /etc/hosts that map the current hostname to an IP
|
|
# other than the host's IP on the internal API network.
|
|
- name: Ensure overcloud hosts' /etc/hosts does not contain incorrect IPs
|
|
lineinfile:
|
|
dest: /etc/hosts
|
|
regexp: "^(?!{{ internal_net_name | net_ip | regex_escape }})[0-9]+\\.[0-9]+\\.[0-9]+\\.[0-9]+[ \t]*{{ ansible_facts.hostname }}"
|
|
state: absent
|
|
# Ensure that the correct entry is present.
|
|
validate: "grep -E '^({{ internal_net_name | net_ip | regex_escape }}).*{{ ansible_facts.hostname }}' %s"
|
|
become: True
|
|
|
|
- name: Ensure rabbitmq containers' /etc/hosts does not contain incorrect IPs
|
|
hosts: overcloud
|
|
tags:
|
|
- etc-hosts-fixup
|
|
vars:
|
|
rabbitmq_containers:
|
|
- rabbitmq
|
|
- outward_rabbitmq
|
|
tasks:
|
|
- name: Check whether rabbitmq container is running
|
|
command: docker inspect -f {{ '{{.Id}}' }} {{ item }}
|
|
changed_when: False
|
|
failed_when: False
|
|
with_items: "{{ rabbitmq_containers }}"
|
|
register: ps_result
|
|
|
|
- name: Copy /etc/hosts into rabbitmq containers
|
|
command: docker cp /etc/hosts {{ item.item }}:/tmp/hosts
|
|
with_items: "{{ ps_result.results }}"
|
|
when: item.rc == 0
|
|
changed_when: false
|
|
|
|
- name: Ensure rabbitmq containers' /etc/hosts does not contain incorrect IPs
|
|
command: >
|
|
docker exec -u root {{ item.item }}
|
|
bash -c
|
|
'if ! diff -q /tmp/hosts /etc/hosts >/dev/null; then
|
|
cp /tmp/hosts /etc/hosts &&
|
|
echo changed
|
|
fi &&
|
|
rm /tmp/hosts'
|
|
changed_when: "'changed' in sed_result.stdout"
|
|
with_items: "{{ ps_result.results }}"
|
|
when: item.rc == 0
|
|
register: sed_result
|
|
|
|
- name: Check that RabbitMQ client works
|
|
command: docker exec {{ item.item }} rabbitmqctl status
|
|
with_items: "{{ ps_result.results }}"
|
|
when: item.rc == 0
|
|
changed_when: false
|