openstack
/
keystone
Code Issues Proposed changes

Remove unused variables from federation tests 

A test method in test_v3_federation.py didn't do anything with the
output it received because it was expecting the call to return a
failure status code, which is check with `expected_status`. This
commit just removes the unused variables since they aren't
asserting anything about the test behavior.

Change-Id: I5eb374f8504a2818384d2631f905dc323d548f60
This commit is contained in:
Lance Bragstad 2016-12-22 15:15:35 +00:00
parent 9f570b6a89
commit 0145084b2f
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
keystone/tests/unit/test_v3_federation.py
View File

@ -1324,10 +1324,9 @@ class FederatedIdentityProviderTests(test_v3.RestfulTestCase):
resp, idp_id, proto = self._assign_protocol_to_idp(proto='saml2',
url=url, **kwargs)
kwargs = {'expected_status': http_client.CONFLICT}
resp, idp_id, proto = self._assign_protocol_to_idp(idp_id=idp_id,
proto='saml2',
validate=False,
url=url, **kwargs)
self._assign_protocol_to_idp(
idp_id=idp_id, proto='saml2', validate=False, url=url, **kwargs
)
def test_assign_protocol_to_nonexistent_idp(self):
"""Assign protocol to IdP that doesn't exist.