openstack/keystone
Code Issues Proposed changes

Mark the implied role API as stable

Browse Source 
This API has been in keystone for a long time and we never updated it
to stable, yet we treat it like a stable API. This change updates the
JSON home document to reflect that. This is also consistent with
discussions during the Rocky PTG:

  https://etherpad.openstack.org/p/keystone-rocky-ptg-json-home

Change-Id: I0b5aef233d9e51799595802d0812015866727987
This commit is contained in:
Lance Bragstad 2018-03-07 21:24:54 +00:00
parent 6077dd1a45
commit 07a66b9c2e
3 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
keystone/assignment/routers.py
View File

@ -62,7 +62,6 @@ class Routers(wsgi.RoutersBase):
path='/roles/{prior_role_id}/implies', path='/roles/{prior_role_id}/implies',
rel=json_home.build_v3_resource_relation('implied_roles'), rel=json_home.build_v3_resource_relation('implied_roles'),
get_head_action='list_implied_roles', get_head_action='list_implied_roles',
status=json_home.Status.EXPERIMENTAL,
path_vars={ path_vars={
'prior_role_id': json_home.Parameters.ROLE_ID, 'prior_role_id': json_home.Parameters.ROLE_ID,
} }
@ -76,7 +75,6 @@ class Routers(wsgi.RoutersBase):
head_action='check_implied_role', head_action='check_implied_role',
get_action='get_implied_role', get_action='get_implied_role',
rel=json_home.build_v3_resource_relation('implied_role'), rel=json_home.build_v3_resource_relation('implied_role'),
status=json_home.Status.EXPERIMENTAL,
path_vars={ path_vars={
'prior_role_id': json_home.Parameters.ROLE_ID, 'prior_role_id': json_home.Parameters.ROLE_ID,
'implied_role_id': json_home.Parameters.ROLE_ID 'implied_role_id': json_home.Parameters.ROLE_ID
@ -87,7 +85,6 @@ class Routers(wsgi.RoutersBase):
path='/role_inferences', path='/role_inferences',
get_head_action='list_role_inference_rules', get_head_action='list_role_inference_rules',
rel=json_home.build_v3_resource_relation('role_inferences'), rel=json_home.build_v3_resource_relation('role_inferences'),
status=json_home.Status.EXPERIMENTAL,
path_vars={} path_vars={}
) )

8
keystone/tests/unit/test_versions.py
View File

@ -365,8 +365,8 @@ V3_JSON_HOME_RESOURCES = {
json_home.build_v3_resource_relation('implied_roles'): { json_home.build_v3_resource_relation('implied_roles'): {
'href-template': '/roles/{prior_role_id}/implies', 'href-template': '/roles/{prior_role_id}/implies',
'href-vars': { 'href-vars': {
'prior_role_id': json_home.Parameters.ROLE_ID}, 'prior_role_id': json_home.Parameters.ROLE_ID}
'hints': {'status': 'experimental'}}, },
json_home.build_v3_resource_relation('implied_role'): { json_home.build_v3_resource_relation('implied_role'): {
'href-template': 'href-template':
'/roles/{prior_role_id}/implies/{implied_role_id}', '/roles/{prior_role_id}/implies/{implied_role_id}',
@ -374,10 +374,10 @@ V3_JSON_HOME_RESOURCES = {
'prior_role_id': json_home.Parameters.ROLE_ID, 'prior_role_id': json_home.Parameters.ROLE_ID,
'implied_role_id': json_home.Parameters.ROLE_ID, 'implied_role_id': json_home.Parameters.ROLE_ID,
}, },
'hints': {'status': 'experimental'}}, },
json_home.build_v3_resource_relation('role_inferences'): { json_home.build_v3_resource_relation('role_inferences'): {
'href': '/role_inferences', 'href': '/role_inferences',
'hints': {'status': 'experimental'}}, },
json_home.build_v3_resource_relation('role_assignments'): { json_home.build_v3_resource_relation('role_assignments'): {
'href': '/role_assignments'}, 'href': '/role_assignments'},
json_home.build_v3_resource_relation('roles'): {'href': '/roles'}, json_home.build_v3_resource_relation('roles'): {'href': '/roles'},

7
releasenotes/notes/implied-roles-stable-8b293e187c5620ad.yaml Normal file
View File

@ -0,0 +1,7 @@
---
other:
- |
The `implied roles API <https://developer.openstack.org/api-ref/identity/v3/index.html#roles>`_
has been marked as stable. This API was originally implemented in Mitaka
and marked as experimental. There haven't been any backwards incompatible
updates since then. As a result, the API is being marked as stable.